From 71aa4033a4f7a6eb0f9f3c23a2e995963ad28f0c Mon Sep 17 00:00:00 2001
From: Chris van Marle <chris.vanmarle@ncsc.nl>
Date: Mon, 29 May 2017 14:59:06 +0200
Subject: [PATCH 1/3] Add numeric sorting

---
 src/core/operations/SeqUtils.js | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

diff --git a/src/core/operations/SeqUtils.js b/src/core/operations/SeqUtils.js
index 96fae0aa..351b0afe 100755
--- a/src/core/operations/SeqUtils.js
+++ b/src/core/operations/SeqUtils.js
@@ -26,7 +26,7 @@ const SeqUtils = {
      * @constant
      * @default
      */
-    SORT_ORDER: ["Alphabetical (case sensitive)", "Alphabetical (case insensitive)", "IP address"],
+    SORT_ORDER: ["Alphabetical (case sensitive)", "Alphabetical (case insensitive)", "IP address", "Numeric"],
 
     /**
      * Sort operation.
@@ -47,6 +47,8 @@ const SeqUtils = {
             sorted = sorted.sort(SeqUtils._caseInsensitiveSort);
         } else if (order === "IP address") {
             sorted = sorted.sort(SeqUtils._ipSort);
+        } else if (order === "Numeric") {
+            sorted = sorted.sort(SeqUtils._numericSort);
         }
 
         if (sortReverse) sorted.reverse();
@@ -221,6 +223,33 @@ const SeqUtils = {
         return a_ - b_;
     },
 
+    /**
+     * Comparison operation for sorting of numeric values.
+     *
+     * @private
+     * @param {string} a
+     * @param {string} b
+     * @returns {number}
+     */
+    _numericSort: function _numericSort(a, b) {
+        let a_ = a.split(/([^\d]+)/),
+            b_ = b.split(/([^\d]+)/);
+
+        for (let i=0; i<a_.length && i<b.length; ++i) {
+            if (isNaN(a_[i]) && !isNaN(b_[i])) return 1; // Numbers after non-numbers
+            if (!isNaN(a_[i]) && isNaN(b_[i])) return -1;
+            if (isNaN(a_[i]) && isNaN(b_[i])) {
+                let ret = a_[i].localeCompare(b_[i]); // Compare strings
+                if (ret !== 0) return ret;
+            }
+            if (!isNaN(a_[i]) && !isNaN(a_[i])) { // Compare numbers
+                if (a_[i] - b_[i] !== 0) return a_[i] - b_[i];
+            }
+        }
+
+        return 0;
+    },
+
 };
 
 export default SeqUtils;

From c6391d958d2a6d9e828b3ba04178639cbf70b116 Mon Sep 17 00:00:00 2001
From: Chris van Marle <chris.vanmarle@ncsc.nl>
Date: Tue, 30 May 2017 08:53:18 +0200
Subject: [PATCH 2/3] Add numeric sorting tests

---
 test/index.js                     |  1 +
 test/tests/operations/SeqUtils.js | 33 +++++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+)
 create mode 100644 test/tests/operations/SeqUtils.js

diff --git a/test/index.js b/test/index.js
index 4e0c6d43..dba360ca 100644
--- a/test/index.js
+++ b/test/index.js
@@ -20,6 +20,7 @@ import "./tests/operations/FlowControl.js";
 import "./tests/operations/Image.js";
 import "./tests/operations/MorseCode.js";
 import "./tests/operations/StrUtils.js";
+import "./tests/operations/SeqUtils.js";
 
 let allTestsPassing = true;
 const testStatusCounts = {
diff --git a/test/tests/operations/SeqUtils.js b/test/tests/operations/SeqUtils.js
new file mode 100644
index 00000000..7fc2c066
--- /dev/null
+++ b/test/tests/operations/SeqUtils.js
@@ -0,0 +1,33 @@
+/**
+ * SeqUtils tests.
+ *
+ * @author Chris van Marle
+ * @copyright Copyright 2017
+ * @license Apache-2.0
+ */
+import TestRegister from "../../TestRegister.js";
+
+TestRegister.addTests([
+    {
+        name: "SeqUtils - Numeric sort photos",
+        input: "Photo-1.jpg\nPhoto-4.jpg\nPhoto-2.jpg\nPhoto-3.jpg\n",
+        expectedOutput: "Photo-1.jpg\nPhoto-2.jpg\nPhoto-3.jpg\nPhoto-4.jpg\n",
+        recipeConfig: [
+            {
+                "op": "Sort",
+                "args": ["Line feed", false, "Numeric"]
+            }
+        ],
+    },
+    {
+        name: "SeqUtils - Numeric sort CVE IDs",
+        input: "CVE-2017-1234,CVE-2017-9999,CVE-2017-10000,CVE-2017-10001,CVE-2017-12345,CVE-2016-1234,CVE-2016-4321,CVE-2016-10000,CVE-2016-9999,CVE-2016-10001",
+        expectedOutput: "CVE-2017-12345,CVE-2017-10001,CVE-2017-10000,CVE-2017-9999,CVE-2017-1234,CVE-2016-10001,CVE-2016-10000,CVE-2016-9999,CVE-2016-4321,CVE-2016-1234",
+        recipeConfig: [
+            {
+                "op": "Sort",
+                "args": ["Comma", true, "Numeric"]
+            }
+        ],
+    },
+]);

From ea3630e018e368d2776d8fe62f383fa756ba7aba Mon Sep 17 00:00:00 2001
From: n1474335 <n1474335@gmail.com>
Date: Thu, 1 Jun 2017 10:21:10 +0000
Subject: [PATCH 3/3] Tidied _numericSort and added @author tag

---
 src/core/operations/SeqUtils.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/core/operations/SeqUtils.js b/src/core/operations/SeqUtils.js
index 351b0afe..70207e00 100755
--- a/src/core/operations/SeqUtils.js
+++ b/src/core/operations/SeqUtils.js
@@ -223,9 +223,11 @@ const SeqUtils = {
         return a_ - b_;
     },
 
+
     /**
      * Comparison operation for sorting of numeric values.
      *
+     * @author Chris van Marle
      * @private
      * @param {string} a
      * @param {string} b
@@ -235,7 +237,7 @@ const SeqUtils = {
         let a_ = a.split(/([^\d]+)/),
             b_ = b.split(/([^\d]+)/);
 
-        for (let i=0; i<a_.length && i<b.length; ++i) {
+        for (let i = 0; i < a_.length && i < b.length; ++i) {
             if (isNaN(a_[i]) && !isNaN(b_[i])) return 1; // Numbers after non-numbers
             if (!isNaN(a_[i]) && isNaN(b_[i])) return -1;
             if (isNaN(a_[i]) && isNaN(b_[i])) {