From dbdcb460e542ce57199dd550e76f51d7d50ecb83 Mon Sep 17 00:00:00 2001
From: Ashleigh Carr <ashcorr20@gmail.com>
Date: Tue, 6 Feb 2024 10:29:20 +0000
Subject: [PATCH] Remove unecessary `if: success()` from Github release
 workflow

---
 .github/workflows/releases.yml | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/.github/workflows/releases.yml b/.github/workflows/releases.yml
index f00e44f6..f3895f8c 100644
--- a/.github/workflows/releases.yml
+++ b/.github/workflows/releases.yml
@@ -37,17 +37,14 @@ jobs:
         npm run testnodeconsumer
 
     - name: Production Build
-      if: success()
       run: npx grunt prod
 
     - name: UI Tests
-      if: success()
       run: |
         sudo apt-get install xvfb
         xvfb-run --server-args="-screen 0 1200x800x24" npx grunt testui
 
     - name: Image Metadata
-      if: success()
       id: image-metadata
       uses: docker/metadata-action@v4
       with:
@@ -58,7 +55,6 @@ jobs:
           type=semver,pattern={{version}}
 
     - name: Production Image Build
-      if: success()
       id: build-image
       uses: redhat-actions/buildah-build@v2
       with:
@@ -74,7 +70,6 @@ jobs:
 
 
     - name: Upload Release Assets
-      if: success()
       id: upload-release-assets
       uses: svenstaro/upload-release-action@v2
       with:
@@ -86,13 +81,11 @@ jobs:
         body: "See the [CHANGELOG](https://github.com/gchq/CyberChef/blob/master/CHANGELOG.md) and [commit messages](https://github.com/gchq/CyberChef/commits/master) for details."
 
     - name: Publish to NPM
-      if: success()
       uses: JS-DevTools/npm-publish@v1
       with:
         token: ${{ secrets.NPM_TOKEN }}
 
     - name: Publish to GHCR
-      if: success()
       uses: redhat-actions/push-to-registry@v2
       with:
         image: ${{ steps.build-image.outputs.image }}