From 0529155faa1aebed06042292f61f9d0f0bcd63ed Mon Sep 17 00:00:00 2001 From: WerWolv Date: Tue, 16 Aug 2022 11:49:40 +0200 Subject: [PATCH] fix: Import/Export bookmarks menu items being disabled when they shouldn't be --- plugins/builtin/source/content/views/view_bookmarks.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/plugins/builtin/source/content/views/view_bookmarks.cpp b/plugins/builtin/source/content/views/view_bookmarks.cpp index 7521c6ffe..170b57ab3 100644 --- a/plugins/builtin/source/content/views/view_bookmarks.cpp +++ b/plugins/builtin/source/content/views/view_bookmarks.cpp @@ -325,16 +325,15 @@ namespace hex::plugin::builtin { ContentRegistry::Interface::addMenuItem("hex.builtin.menu.file", 4000, [&] { bool providerValid = ImHexApi::Provider::isValid(); - auto selection = ImHexApi::HexEditor::getSelection(); - if (ImGui::MenuItem("hex.builtin.menu.file.bookmark.import"_lang, nullptr, false, selection.has_value() && providerValid)) { + if (ImGui::MenuItem("hex.builtin.menu.file.bookmark.import"_lang, nullptr, false, providerValid)) { fs::openFileBrowser(fs::DialogMode::Open, { { "Bookmarks File", "hexbm"} }, [&](const std::fs::path &path) { try { importBookmarks(ImHexApi::Provider::get(), nlohmann::json::parse(fs::File(path, fs::File::Mode::Read).readString())); } catch (...) { } }); } - if (ImGui::MenuItem("hex.builtin.menu.file.bookmark.export"_lang, nullptr, false, selection.has_value() && providerValid)) { + if (ImGui::MenuItem("hex.builtin.menu.file.bookmark.export"_lang, nullptr, false, providerValid && !ProviderExtraData::getCurrent().bookmarks.empty())) { fs::openFileBrowser(fs::DialogMode::Save, { { "Bookmarks File", "hexbm"} }, [&](const std::fs::path &path) { nlohmann::json json; exportBookmarks(ImHexApi::Provider::get(), json);