Cool_Tools/ImHex
1
0
Fork 0
mirror of synced 2025-02-17 18:59:21 +01:00
Code Releases Wiki Activity

impr: Add a link to the "Find" view in the search popup (#1665)

Browse Source 
### Problem description
This PR adds a shortcut link on the Search (Ctrl+F) popup to the more
advanced "Find" view that is normally accessible at the `View > Find`
menu.

### Implementation description
I added a simple `ImGuiExt::IconHyperlink` link to the `draw()` function
of the `PopupFind` class to display the hyperlink. Clicking the link
will open the Find view, bring it into focus and close the current
popup.

### Screenshots
Before:

![image](https://github.com/WerWolv/ImHex/assets/45818400/0961f594-0548-426a-8622-20093d4a165e)

After:

![image](https://github.com/WerWolv/ImHex/assets/45818400/d40d78f4-1a5d-4bf6-97a4-ff7ab40d0cef)


### Additional things
- Localization keys were added to all .json files, but only `en_US` is
populated for now.
This commit is contained in:
SparkyTD 2024-05-11 01:15:17 -07:00 committed by GitHub
parent 3c91cb09e3
commit 09bffb6745
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
10 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
plugins/builtin/romfs/lang/de_DE.json
View File

@ -799,6 +799,7 @@
"hex.builtin.view.hex_editor.search.find": "Suchen",
"hex.builtin.view.hex_editor.search.hex": "Hex",
"hex.builtin.view.hex_editor.search.no_more_results": "Keine weiteren Ergebnisse",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "String",
"hex.builtin.view.hex_editor.search.string.encoding": "Kodierung",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",

1
plugins/builtin/romfs/lang/en_US.json
View File

@ -805,6 +805,7 @@
"hex.builtin.view.hex_editor.search.string.endianness.little": "Little",
"hex.builtin.view.hex_editor.search.string.endianness.big": "Big",
"hex.builtin.view.hex_editor.search.no_more_results": "No more results",
"hex.builtin.view.hex_editor.search.advanced": "Advanced Search...",
"hex.builtin.view.hex_editor.select.offset.begin": "Begin",
"hex.builtin.view.hex_editor.select.offset.end": "End",
"hex.builtin.view.hex_editor.select.offset.region": "Region",

1
plugins/builtin/romfs/lang/es_ES.json
View File

@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "Buscar",
"hex.builtin.view.hex_editor.search.hex": "Hexadecimal",
"hex.builtin.view.hex_editor.search.no_more_results": "No se encontraron más resultados",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "Cadena",
"hex.builtin.view.hex_editor.search.string.encoding": "Codificación",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",

1
plugins/builtin/romfs/lang/it_IT.json
View File

@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "Cerca",
"hex.builtin.view.hex_editor.search.hex": "Hex",
"hex.builtin.view.hex_editor.search.no_more_results": "Nessun risultato trovato",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "Stringa",
"hex.builtin.view.hex_editor.search.string.encoding": "Codifica",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",

1
plugins/builtin/romfs/lang/ja_JP.json
View File

@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "検索",
"hex.builtin.view.hex_editor.search.hex": "16進数",
"hex.builtin.view.hex_editor.search.no_more_results": "結果がありません",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "文字列",
"hex.builtin.view.hex_editor.search.string.encoding": "エンコード",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",

1
plugins/builtin/romfs/lang/ko_KR.json
View File

@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "찾기",
"hex.builtin.view.hex_editor.search.hex": "헥스",
"hex.builtin.view.hex_editor.search.no_more_results": "더이상 결과 없음",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "문자열",
"hex.builtin.view.hex_editor.search.string.encoding": "エンコード",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",

1
plugins/builtin/romfs/lang/pt_BR.json
View File

@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "Buscar",
"hex.builtin.view.hex_editor.search.hex": "Hex",
"hex.builtin.view.hex_editor.search.no_more_results": "Não há mais resultados",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "String",
"hex.builtin.view.hex_editor.search.string.encoding": "Codificação",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",

1
plugins/builtin/romfs/lang/zh_CN.json
View File

@ -839,6 +839,7 @@
"hex.builtin.view.hex_editor.search.find": "查找",
"hex.builtin.view.hex_editor.search.hex": "Hex",
"hex.builtin.view.hex_editor.search.no_more_results": "没有更多结果",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "字符串",
"hex.builtin.view.hex_editor.search.string.encoding": "编码",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",

1
plugins/builtin/romfs/lang/zh_TW.json
View File

@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "尋找",
"hex.builtin.view.hex_editor.search.hex": "十六進位",
"hex.builtin.view.hex_editor.search.no_more_results": "沒有更多結果",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "字串",
"hex.builtin.view.hex_editor.search.string.encoding": "編碼",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",

7
plugins/builtin/source/content/popups/hex_editor/popup_hex_editor_find.cpp
View File

@ -46,6 +46,13 @@ namespace hex::plugin::builtin {
ImGui::EndTabBar();
}
if(ImGuiExt::IconHyperlink(ICON_VS_SEARCH, "hex.builtin.view.hex_editor.search.advanced"_lang)) {
const auto& view = ContentRegistry::Views::getViewByName("hex.builtin.view.find.name");
view->getWindowOpenState() = true;
ImGui::SetWindowFocus(view->getName().c_str());
editor->closePopup();
}
if (lastMode != *s_searchMode) {
m_requestFocus = true;
s_inputString->clear();