Cool_Tools/ImHex
1
0
Fork 0
mirror of synced 2025-02-18 03:09:18 +01:00
Code Releases Wiki Activity

Make strings view less laggy

Browse Source
This commit is contained in:
WerWolv 2020-11-15 03:51:59 +01:00
parent 9320ffdbbd
commit 0b8b887978
1 changed files with 68 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
source/views/view_strings.cpp
View File

@ -24,9 +24,6 @@ namespace hex {
if (!this->m_windowOpen)
return;
if (this->m_dataProvider == nullptr || !this->m_dataProvider->isReadable())
return;
if (this->m_shouldInvalidate) {
this->m_shouldInvalidate = false;
@ -60,7 +57,9 @@ namespace hex {
}
}
if (ImGui::Begin("Strings", &this->m_windowOpen)) {
if (this->m_dataProvider != nullptr && this->m_dataProvider->isReadable()) {
if (ImGui::InputInt("Minimum length", &this->m_minimumLength, 1, 0))
this->m_shouldInvalidate = true;
@ -71,7 +70,9 @@ namespace hex {
ImGui::BeginChild("##scrolling", ImVec2(0, 0), false, ImGuiWindowFlags_NoMove | ImGuiWindowFlags_NoNav);
if (ImGui::BeginTable("##strings", 3, ImGuiTableFlags_Borders | ImGuiTableFlags_Resizable | ImGuiTableFlags_Sortable | ImGuiTableFlags_Reorderable | ImGuiTableFlags_RowBg)) {
if (ImGui::BeginTable("##strings", 3,
ImGuiTableFlags_Borders | ImGuiTableFlags_Resizable | ImGuiTableFlags_Sortable |
ImGuiTableFlags_Reorderable | ImGuiTableFlags_RowBg)) {
ImGui::TableSetupColumn("Position", 0, -1, ImGui::GetID("position"));
ImGui::TableSetupColumn("Size", 0, -1, ImGui::GetID("size"));
ImGui::TableSetupColumn("String", 0, -1, ImGui::GetID("string"));
@ -79,20 +80,19 @@ namespace hex {
auto sortSpecs = ImGui::TableGetSortSpecs();
if (sortSpecs->SpecsDirty) {
std::sort(this->m_foundStrings.begin(), this->m_foundStrings.end(), [this, &sortSpecs](FoundString &left, FoundString&right) -> bool {
std::sort(this->m_foundStrings.begin(), this->m_foundStrings.end(),
[this, &sortSpecs](FoundString &left, FoundString &right) -> bool {
if (sortSpecs->Specs->ColumnUserID == ImGui::GetID("position")) {
if (sortSpecs->Specs->SortDirection == ImGuiSortDirection_Ascending)
return left.offset > right.offset;
else
return left.offset < right.offset;
}
else if (sortSpecs->Specs->ColumnUserID == ImGui::GetID("size")) {
} else if (sortSpecs->Specs->ColumnUserID == ImGui::GetID("size")) {
if (sortSpecs->Specs->SortDirection == ImGuiSortDirection_Ascending)
return left.size > right.size;
else
return left.size < right.size;
}
else if (sortSpecs->Specs->ColumnUserID == ImGui::GetID("string")) {
} else if (sortSpecs->Specs->ColumnUserID == ImGui::GetID("string")) {
if (sortSpecs->Specs->SortDirection == ImGuiSortDirection_Ascending)
return left.string > right.string;
else
@ -107,7 +107,14 @@ namespace hex {
ImGui::TableHeadersRow();
u32 rowCount = 0;
for (auto &foundString : this->m_foundStrings) {
ImGuiListClipper clipper;
clipper.Begin(this->m_foundStrings.size(), 14);
clipper.Step();
for (u64 i = clipper.DisplayStart; i < clipper.DisplayEnd; i++) {
auto &foundString = this->m_foundStrings[i];
if (strlen(this->m_filter) != 0 && foundString.string.find(this->m_filter) == std::string::npos)
continue;
@ -118,15 +125,19 @@ namespace hex {
ImGui::Text("%08lx", foundString.size);
ImGui::TableNextColumn();
ImGui::Text("%s", foundString.string.c_str());
ImGui::TableSetBgColor(ImGuiTableBgTarget_RowBg0, ((rowCount % 2) == 0) ? 0xFF101010 : 0xFF303030);
ImGui::TableSetBgColor(ImGuiTableBgTarget_RowBg0,
((rowCount % 2) == 0) ? 0xFF101010 : 0xFF303030);
rowCount++;
}
clipper.Step();
clipper.End();
ImGui::EndTable();
}
ImGui::EndChild();
}
}
ImGui::End();
}