Cool_Tools/ImHex
1
0
Fork 0
mirror of synced 2025-02-25 22:08:34 +01:00
Code Releases Wiki Activity

impr: Optimize time it takes to find favorites in patterns

Browse Source
This commit is contained in:
WerWolv 2024-07-24 19:41:12 +02:00
parent 5ca3222e5b
commit 416889f49d
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/ui/source/ui/pattern_drawer.cpp
View File

@ -1382,6 +1382,8 @@ namespace hex::ui {
for (auto &pattern : patterns) { for (auto &pattern : patterns) {
std::vector<std::string> patternPath; std::vector<std::string> patternPath;
size_t startFavoriteCount = m_favorites.size();
traversePatternTree(*pattern, patternPath, [&, this](const pl::ptrn::Pattern &currPattern) { traversePatternTree(*pattern, patternPath, [&, this](const pl::ptrn::Pattern &currPattern) {
if (currPattern.hasAttribute("hex::favorite")) if (currPattern.hasAttribute("hex::favorite"))
m_favorites.insert({ patternPath, currPattern.clone() }); m_favorites.insert({ patternPath, currPattern.clone() });
@ -1394,12 +1396,15 @@ namespace hex::ui {
m_groups[groupName].push_back(currPattern.clone()); m_groups[groupName].push_back(currPattern.clone());
} }
task.update();
}); });
if (updatedFavorites == m_favorites.size())
task.interrupt();
task.update(); task.update();
if (startFavoriteCount == m_favorites.size())
continue;
patternPath.clear(); patternPath.clear();
traversePatternTree(*pattern, patternPath, [&, this](const pl::ptrn::Pattern &currPattern) { traversePatternTree(*pattern, patternPath, [&, this](const pl::ptrn::Pattern &currPattern) {
for (auto &[path, favoritePattern] : m_favorites) { for (auto &[path, favoritePattern] : m_favorites) {