Cool_Tools/ImHex
1
0
Fork 0
mirror of synced 2024-09-24 11:38:26 +02:00
Code Releases Wiki Activity

fix: Error popup now showing up immediately after click (#1272)

Browse Source 
From #1265, Looks like Error Popup doesn't handle properly in some
circumstances.

---------

Co-authored-by: iTrooz <hey@itrooz.fr>
Co-authored-by: WerWolv <werwolv98@gmail.com>
This commit is contained in:
Imron jehleh 2023-09-16 18:09:24 +07:00 committed by GitHub
parent 691df0fc83
commit 64a30a45d5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dist/compiling/windows.md vendored
View File

@ -7,6 +7,7 @@ On Windows, ImHex is built through [msys2 / mingw](https://www.msys2.org/)'s gcc
3. Clone the repo using `git clone https://github.com/WerWolv/ImHex --recurse-submodules`
4. Install all the dependencies using `./ImHex/dist/get_deps_msys2.sh`
5. Build ImHex itself using the following commands:
```sh
cd ImHex
mkdir build
@ -20,3 +21,5 @@ ninja install
```
ImHex will look for any extra resources either in various folders directly next to the executable or in `%localappdata%/imhex`
For low RAM-usage system, you can use `mingw32-make -j N install` instead, to reduce RAM usage at compile time. Where `N` is amount of jobs you are willling to run at once. Roughly ~1 GB of RAM usage per job.

1
plugins/builtin/source/content/views/view_provider_settings.cpp
View File

@ -43,6 +43,7 @@ namespace hex::plugin::builtin {
ImGui::CloseCurrentPopup();
}
else {
ImGui::CloseCurrentPopup();
auto errorMessage = provider->getErrorMessage();
if (errorMessage.empty()) {
PopupError::open("hex.builtin.view.provider_settings.load_error"_lang);