1
0
mirror of synced 2024-11-28 09:30:51 +01:00

fix: Updater not renaming file correctly

This commit is contained in:
WerWolv 2024-01-05 18:12:46 +01:00
parent dbdc900e94
commit 76a58cd843

View File

@ -8,7 +8,7 @@ using namespace std::literals::string_literals;
std::string getUpdateUrl(std::string_view versionType, std::string_view operatingSystem) { std::string getUpdateUrl(std::string_view versionType, std::string_view operatingSystem) {
// Get the latest version info from the ImHex API // Get the latest version info from the ImHex API
auto response = hex::HttpRequest("GET", const auto response = hex::HttpRequest("GET",
ImHexApiURL + fmt::format("/update/{}/{}", ImHexApiURL + fmt::format("/update/{}/{}",
versionType, versionType,
operatingSystem operatingSystem
@ -29,7 +29,7 @@ std::string getUpdateUrl(std::string_view versionType, std::string_view operatin
std::optional<std::fs::path> downloadUpdate(const std::string &url) { std::optional<std::fs::path> downloadUpdate(const std::string &url) {
// Download the update // Download the update
auto response = hex::HttpRequest("GET", url).downloadFile().get(); const auto response = hex::HttpRequest("GET", url).downloadFile().get();
// Make sure we got a valid response // Make sure we got a valid response
if (!response.isSuccess()) { if (!response.isSuccess()) {
@ -106,8 +106,9 @@ int installUpdate(const std::string &type, std::fs::path updatePath) {
for (const auto &handler : UpdateHandlers) { for (const auto &handler : UpdateHandlers) {
if (type == handler.type) { if (type == handler.type) {
// Rename the update file to the correct extension // Rename the update file to the correct extension
const auto originalPath = updatePath;
updatePath.replace_extension(handler.extension); updatePath.replace_extension(handler.extension);
std::fs::rename(updatePath, updatePath); std::fs::rename(originalPath, updatePath);
// Install the update using the correct command // Install the update using the correct command
hex::startProgram(hex::format(handler.command, updatePath.string())); hex::startProgram(hex::format(handler.command, updatePath.string()));
@ -158,7 +159,7 @@ int main(int argc, char **argv) {
hex::log::info("Update URL found: {}", updateUrl); hex::log::info("Update URL found: {}", updateUrl);
// Download the update file // Download the update file
auto updatePath = downloadUpdate(updateUrl); const auto updatePath = downloadUpdate(updateUrl);
if (!updatePath.has_value()) if (!updatePath.has_value())
return EXIT_FAILURE; return EXIT_FAILURE;