Cool_Tools/ImHex
1
0
Fork 0
mirror of synced 2024-11-24 07:40:17 +01:00
Code Releases Wiki Activity

fix: remove TODO + show error message when reading/write in process provider (#1516)

Browse Source
This commit is contained in:
iTrooz 2024-01-26 19:44:52 +01:00 committed by GitHub
parent d23d382038
commit a4d6932ed8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
main/gui/source/messaging/win.cpp
View File

@ -45,8 +45,6 @@ namespace hex::messaging {
HWND imHexWindow = *getImHexWindow();
// Create the message
// TODO actually send all arguments and not just the eventName
std::vector<u8> fulleventData(eventName.begin(), eventName.end());
fulleventData.push_back('\0');

4
plugins/builtin/source/content/providers/process_memory_provider.cpp
View File

@ -63,7 +63,7 @@ namespace hex::plugin::builtin {
auto read = process_vm_readv(m_processId, &local, 1, &remote, 1, 0);
if (read == -1) {
// TODO error handling strerror(errno)
log::error("Process memory provider failed to read data: {}", strerror(errno));
}
#endif
}
@ -82,7 +82,7 @@ namespace hex::plugin::builtin {
auto read = process_vm_writev(m_processId, &local, 1, &remote, 1, 0);
if (read == -1) {
// TODO error handling strerror(errno)
log::error("Process memory provider failed to write data: {}", strerror(errno));
}
#endif
}