Cool_Tools/ImHex
1
0
Fork 0
mirror of synced 2025-01-31 03:53:44 +01:00
Code Releases Wiki Activity

impr: Better detection of Intel GPUs with really bad driver bugs

Browse Source
This commit is contained in:
WerWolv 2024-06-22 22:58:45 +02:00
parent 65dfd4da0f
commit a9915579a0
4 changed files with 52 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/libimhex/include/hex/api/imhex_api.hpp
View File

@ -434,6 +434,7 @@ namespace hex {
void setInitialWindowProperties(InitialWindowProperties properties);
void setGPUVendor(const std::string &vendor);
void setGLRenderer(const std::string &renderer);
void addInitArgument(const std::string &key, const std::string &value = { });
@ -573,6 +574,12 @@ namespace hex {
*/
const std::string& getGPUVendor();
/**
* @brief Gets the current GPU vendor
* @return The current GPU vendor
*/
const std::string& getGLRenderer();
/**
* @brief Checks if ImHex is running in portable mode
* @return Whether ImHex is running in portable mode

9
lib/libimhex/source/api/imhex_api.cpp
View File

@ -532,6 +532,11 @@ namespace hex {
s_gpuVendor = vendor;
}
static AutoReset<std::string> s_glRenderer;
void setGLRenderer(const std::string &renderer) {
s_glRenderer = renderer;
}
static AutoReset<std::map<std::string, std::string>> s_initArguments;
void addInitArgument(const std::string &key, const std::string &value) {
static std::mutex initArgumentsMutex;
@ -676,6 +681,10 @@ namespace hex {
return impl::s_gpuVendor;
}
const std::string &getGLRenderer() {
return impl::s_glRenderer;
}
bool isPortableVersion() {
static std::optional<bool> portable;
if (portable.has_value())

1
main/gui/source/init/splash_window.cpp
View File

@ -56,6 +56,7 @@ namespace hex::init {
log::debug("OpenGL Shading Language Version: '{}'", glShadingLanguageVersion);
ImHexApi::System::impl::setGPUVendor(glVendor);
ImHexApi::System::impl::setGLRenderer(glRenderer);
}
RequestAddInitTask::subscribe([this](const std::string& name, bool async, const TaskFunction &function){

46
plugins/builtin/source/content/settings_entries.cpp
View File

@ -656,22 +656,46 @@ namespace hex::plugin::builtin {
bool getDefaultBorderlessWindowMode() {
bool result = false;
bool result;
#if defined (OS_WINDOWS) || defined(OS_MACOS)
#if defined (OS_WINDOWS)
result = true;
#endif
// Intel's OpenGL driver has weird bugs that cause the drawn window to be offset to the bottom right.
// This can be fixed by either using Mesa3D's OpenGL Software renderer or by simply disabling it.
// If you want to try if it works anyways on your GPU, set the hex.builtin.setting.interface.force_borderless_window_mode setting to 1
if (ImHexApi::System::isBorderlessWindowModeEnabled()) {
// Intel's OpenGL driver is extremely buggy. Its issues can manifest in lots of different ways
// such as "colorful snow" appearing on the screen or, the most annoying issue,
// it might draw the window content slightly offset to the bottom right as seen in issue #1625
// The latter issue can be circumvented by using the native OS decorations or by using the software renderer.
// This code here tries to detect if the user has a problematic Intel GPU and if so, it will default to the native OS decorations.
// This doesn't actually solve the issue at all but at least it makes ImHex usable on these GPUs.
const bool isIntelGPU = hex::containsIgnoreCase(ImHexApi::System::getGPUVendor(), "Intel");
if (isIntelGPU) {
log::warn("Intel GPU detected! Intel's OpenGL GPU drivers are extremely buggy and can cause issues when using ImHex. If you experience any rendering bugs, please enable the Native OS Decoration setting or try the software rendererd -NoGPU release.");
result = !isIntelGPU;
if (isIntelGPU)
log::warn("Intel GPU detected! Intel's OpenGL driver has bugs that can cause issues when using ImHex. If you experience any rendering bugs, please enable the Native OS Decoration setting or try the software rendererd -NoGPU release.");
}
// Non-exhaustive list of bad GPUs.
// If more GPUs are found to be problematic, they can be added here.
constexpr static std::array BadGPUs = {
// Sandy Bridge Series, Second Gen HD Graphics
"HD Graphics 2000",
"HD Graphics 3000"
};
const auto &glRenderer = ImHexApi::System::getGLRenderer();
for (const auto &badGPU : BadGPUs) {
if (hex::containsIgnoreCase(glRenderer, badGPU)) {
result = false;
break;
}
}
}
#elif defined(OS_MACOS)
result = true;
#elif defined(OS_LINUX)
// On Linux, things like Window snapping and moving is hard to implement
// without hacking e.g. libdecor, therefor we default to the native window decorations.
result = false;
#endif
return result;
}