fix: Crash when restarting ImHex more than once

lib/libimhex/include/hex/api/imhex_api.hpp

@@ -19,6 +19,8 @@ struct GLFWwindow;
 
 namespace hex {
 
+    class AutoResetBase;
+
     namespace prv {
         class Provider;
     }
@@ -407,6 +409,9 @@ namespace hex {
 
                 bool isWindowResizable();
 
+                void addAutoResetObject(AutoResetBase *object);
+                void cleanup();
+
             }
 
             /**

lib/libimhex/include/hex/helpers/auto_reset.hpp

@@ -1,22 +1,23 @@
 #pragma once
 
 #include <hex/api/event_manager.hpp>
+#include <hex/api/imhex_api.hpp>
 
 namespace hex {
 
+    class AutoResetBase {
+    public:
+        virtual ~AutoResetBase() = default;
+        virtual void reset() = 0;
+    };
+
     template<typename T>
-    class AutoReset {
+    class AutoReset : AutoResetBase {
     public:
         using Type = T;
 
         AutoReset() {
-            EventImHexClosing::subscribe(this, [this] {
+            ImHexApi::System::impl::addAutoResetObject(this);
-                this->reset();
-            });
-        }
-
-        ~AutoReset() {
-            EventImHexClosing::unsubscribe(this);
         }
 
         T* operator->() {
@@ -53,8 +54,16 @@ namespace hex {
             return m_value;
         }
 
-        void reset() {
+        void reset() override {
-            m_value = T();
+            if constexpr (requires { m_value.reset(); }) {
+                m_value.reset();
+            } else if constexpr (requires { m_value.clear(); }) {
+                m_value.clear();
+            } else if constexpr (requires(T t) { t = nullptr; }) {
+                m_value = nullptr;
+            } else {
+                m_value = { };
+            }
         }
 
     private:

lib/libimhex/source/api/content_registry.cpp

@@ -106,13 +106,15 @@ namespace hex {
                     if (!loaded)
                         store();
 
-                    for (const auto &[category, rest] : *impl::s_onChangeCallbacks) {
+                    TaskManager::doLater([] {
-                        for (const auto &[name, callbacks] : rest) {
+                        for (const auto &[category, rest] : *impl::s_onChangeCallbacks) {
-                            for (const auto &[id, callback] : callbacks) {
+                            for (const auto &[name, callbacks] : rest) {
-                                callback(getSetting(category, name, {}));
+                                for (const auto &[id, callback] : callbacks) {
+                                    callback(getSetting(category, name, {}));
+                                }
                             }
                         }
-                    }
+                    });
                 }
 
                 void store() {

lib/libimhex/source/api/imhex_api.cpp

@@ -471,6 +471,16 @@ namespace hex {
                 return s_windowResizable;
             }
 
+            static std::vector<AutoResetBase*> s_autoResetObjects;
+            void addAutoResetObject(AutoResetBase *object) {
+                s_autoResetObjects.emplace_back(object);
+            }
+
+            void cleanup() {
+                for (const auto &object : s_autoResetObjects)
+                    object->reset();
+            }
+
 
         }
 

main/gui/source/init/tasks.cpp

@@ -80,6 +80,7 @@ namespace hex::init {
             log::fatal("To the person fixing this, read the comment above this message for more information.");
         });
 
+        ImHexApi::System::impl::cleanup();
         EventImHexClosing::post();
         EventManager::clear();