Cool_Tools/ImHex
1
0
Fork 0
mirror of synced 2025-02-06 22:24:24 +01:00
Code Releases Wiki Activity

fix: Data processor recursion detector triggering too soon

Browse Source
This commit is contained in:
WerWolv 2023-10-19 23:34:05 +02:00
parent b4ee02b725
commit c9cd7ad4a6
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/libimhex/include/hex/data_processor/node.hpp
View File

@ -109,6 +109,10 @@ namespace hex::dp {
throwNodeError("Recursion detected!"); throwNodeError("Recursion detected!");
} }
void unmarkInputProcessed(u32 index) {
this->m_processedInputs.erase(index);
}
protected: protected:
[[noreturn]] void throwNodeError(const std::string &message) { [[noreturn]] void throwNodeError(const std::string &message) {
throw NodeError { this, message }; throw NodeError { this, message };

3
lib/libimhex/source/data_processor/node.cpp
View File

@ -29,6 +29,7 @@ namespace hex::dp {
markInputProcessed(index); markInputProcessed(index);
attribute->getParentNode()->process(); attribute->getParentNode()->process();
unmarkInputProcessed(index);
auto &outputData = attribute->getOutputData(); auto &outputData = attribute->getOutputData();
@ -48,6 +49,7 @@ namespace hex::dp {
markInputProcessed(index); markInputProcessed(index);
attribute->getParentNode()->process(); attribute->getParentNode()->process();
unmarkInputProcessed(index);
return attribute->getOutputData(); return attribute->getOutputData();
} else { } else {
@ -74,6 +76,7 @@ namespace hex::dp {
markInputProcessed(index); markInputProcessed(index);
attribute->getParentNode()->process(); attribute->getParentNode()->process();
unmarkInputProcessed(index);
return attribute->getOutputData(); return attribute->getOutputData();
} else { } else {