From daffa4e555568c7bbc27bc2ffccd232ea6408483 Mon Sep 17 00:00:00 2001 From: WerWolv Date: Sat, 23 Jul 2022 21:17:17 +0200 Subject: [PATCH] fix: Edit -> Create Bookmark shortcut creating bookmark at wrong address --- plugins/builtin/source/content/main_menu_items.cpp | 5 +---- plugins/builtin/source/content/ui_items.cpp | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/plugins/builtin/source/content/main_menu_items.cpp b/plugins/builtin/source/content/main_menu_items.cpp index e66b505c5..b975cebf2 100644 --- a/plugins/builtin/source/content/main_menu_items.cpp +++ b/plugins/builtin/source/content/main_menu_items.cpp @@ -250,14 +250,11 @@ namespace hex::plugin::builtin { }); ContentRegistry::Interface::addMenuItem("hex.builtin.menu.edit", 1050, [&] { - auto provider = ImHexApi::Provider::get(); bool providerValid = ImHexApi::Provider::isValid(); auto selection = ImHexApi::HexEditor::getSelection(); if (ImGui::MenuItem("hex.builtin.menu.edit.bookmark"_lang, nullptr, false, selection.has_value() && providerValid)) { - auto base = provider->getBaseAddress(); - - ImHexApi::Bookmarks::add(base + selection->getStartAddress(), selection->size, {}, {}); + ImHexApi::Bookmarks::add(selection->getStartAddress(), selection->getSize(), {}, {}); } }); diff --git a/plugins/builtin/source/content/ui_items.cpp b/plugins/builtin/source/content/ui_items.cpp index 58dcd6a8e..9d9fda8de 100644 --- a/plugins/builtin/source/content/ui_items.cpp +++ b/plugins/builtin/source/content/ui_items.cpp @@ -286,7 +286,7 @@ namespace hex::plugin::builtin { auto region = ImHexApi::HexEditor::getSelection(); if (region.has_value()) - ImHexApi::Bookmarks::add(region->address, region->size, {}, {}); + ImHexApi::Bookmarks::add(region->getStartAddress(), region->getSize(), {}, {}); } } ImGui::EndDisabled();