Cool_Tools/ImHex
1
0
Fork 0
mirror of synced 2024-11-12 02:00:52 +01:00
Code Releases Wiki Activity

fix: Segfault when hashing regions spanning multiple MiBs (#1804)

Browse Source 
### Problem description

Attempting to do an MD5 hash of a large region (e.g. 2 MiB, ``u8
data[0x200000]``) crashes with a segfault.

### Implementation description

In ``hex::plugin::hashes::hashProviderRegionWithHashLib()``,
``hashFunction->TransformBytes()`` is called with an offset of 0,
because it iterates over ``data`` and not the entire region.
This commit is contained in:
Jean-François Nguyen 2024-07-21 20:35:38 +02:00 committed by GitHub
parent 75e5dbaaa4
commit e50b6733c4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/hashes/source/content/hashes.cpp
View File

@ -27,7 +27,7 @@ namespace hex::plugin::hashes {
u64 readSize = std::min<u64>(1_MiB, (region.getEndAddress() - address) + 1);
auto data = reader.read(address, readSize);
hashFunction->TransformBytes({ data.begin(), data.end() }, address - region.getStartAddress(), data.size());
hashFunction->TransformBytes({ data.begin(), data.end() }, 0, data.size());
}
auto result = hashFunction->TransformFinal();