Cool_Tools/ImHex
1
0
Fork 0
mirror of synced 2024-11-24 07:40:17 +01:00
Code Releases Wiki Activity

impr: Make settings tab bar always stick to top of window

Browse Source
This commit is contained in:
WerWolv 2023-11-17 16:05:45 +01:00
parent 36a352b096
commit e7bfa483f8
2 changed files with 41 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/libimhex/source/ui/imgui_imhex_extensions.cpp
View File

@ -882,7 +882,7 @@ namespace ImGuiExt {
const bool hasMenuBar = !std::string_view(label).empty();
ImGui::PushStyleVar(ImGuiStyleVar_ChildRounding, 5.0f);
if (ImGui::BeginChild(label, size, ImGuiChildFlags_Border | ImGuiChildFlags_AutoResizeY | flags, hasMenuBar ? ImGuiWindowFlags_MenuBar : ImGuiWindowFlags_None)) {
if (ImGui::BeginChild(hex::format("{}##SubWindow", label).c_str(), size, ImGuiChildFlags_Border | ImGuiChildFlags_AutoResizeY | flags, hasMenuBar ? ImGuiWindowFlags_MenuBar : ImGuiWindowFlags_None)) {
if (hasMenuBar && ImGui::BeginMenuBar()) {
ImGui::TextUnformatted(label);
ImGui::EndMenuBar();

77
plugins/builtin/source/content/views/view_settings.cpp
View File

@ -6,6 +6,7 @@
#include <nlohmann/json.hpp>
#include <content/popups/popup_question.hpp>
#include <wolv/utils/guards.hpp>
namespace hex::plugin::builtin {
@ -47,57 +48,59 @@ namespace hex::plugin::builtin {
// For each category, create a new tab
if (ImGui::BeginTabItem(LangEntry(category.unlocalizedName))) {
// Draw the category description
if (!category.unlocalizedDescription.empty()) {
ImGuiExt::TextFormattedWrapped("{}", LangEntry(category.unlocalizedDescription));
ImGui::NewLine();
}
if (ImGui::BeginChild("scrolling")) {
// Draw all settings of that category
for (auto &subCategory : category.subCategories) {
// Draw the category description
if (!category.unlocalizedDescription.empty()) {
ImGuiExt::TextFormattedWrapped("{}", LangEntry(category.unlocalizedDescription));
ImGui::NewLine();
}
// Skip empty subcategories
if (subCategory.entries.empty())
continue;
// Draw all settings of that category
for (auto &subCategory : category.subCategories) {
ImGuiExt::BeginSubWindow(LangEntry(subCategory.unlocalizedName));
{
for (auto &setting : subCategory.entries) {
ImGui::BeginDisabled(!setting.widget->isEnabled());
ImGui::PushItemWidth(-200_scaled);
bool settingChanged = setting.widget->draw(LangEntry(setting.unlocalizedName));
ImGui::PopItemWidth();
ImGui::EndDisabled();
// Skip empty subcategories
if (subCategory.entries.empty())
continue;
if (auto tooltip = setting.widget->getTooltip(); tooltip.has_value() && ImGui::IsItemHovered())
ImGuiExt::InfoTooltip(LangEntry(tooltip.value()));
ImGuiExt::BeginSubWindow(LangEntry(subCategory.unlocalizedName));
{
for (auto &setting : subCategory.entries) {
ImGui::BeginDisabled(!setting.widget->isEnabled());
ImGui::PushItemWidth(-200_scaled);
bool settingChanged = setting.widget->draw(LangEntry(setting.unlocalizedName));
ImGui::PopItemWidth();
ImGui::EndDisabled();
auto &widget = setting.widget;
if (auto tooltip = setting.widget->getTooltip(); tooltip.has_value() && ImGui::IsItemHovered())
ImGuiExt::InfoTooltip(LangEntry(tooltip.value()));
// Handle a setting being changed
if (settingChanged) {
auto newValue = widget->store();
auto &widget = setting.widget;
// Write new value to settings
ContentRegistry::Settings::write(category.unlocalizedName, setting.unlocalizedName, newValue);
// Handle a setting being changed
if (settingChanged) {
auto newValue = widget->store();
// Print a debug message
log::debug("Setting [{} / {}]: Value was changed to {}", category.unlocalizedName, setting.unlocalizedName, nlohmann::to_string(newValue));
// Write new value to settings
ContentRegistry::Settings::write(category.unlocalizedName, setting.unlocalizedName, newValue);
// Signal that the setting was changed
EventManager::post<EventSettingsChanged>();
widget->onChanged();
// Print a debug message
log::debug("Setting [{} / {}]: Value was changed to {}", category.unlocalizedName, setting.unlocalizedName, nlohmann::to_string(newValue));
// Request a restart if the setting requires it
if (widget->doesRequireRestart())
this->m_restartRequested = true;
// Signal that the setting was changed
EventManager::post<EventSettingsChanged>();
widget->onChanged();
// Request a restart if the setting requires it
if (widget->doesRequireRestart())
this->m_restartRequested = true;
}
}
}
ImGuiExt::EndSubWindow();
}
ImGuiExt::EndSubWindow();
}
ImGui::EndChild();
ImGui::EndTabItem();
}