Cool_Tools/ImHex
1
0
Fork 0
mirror of synced 2024-11-25 08:10:24 +01:00
Code Releases Wiki Activity

fix: Properly clear valid region when switching to a different provider

Browse Source
This commit is contained in:
WerWolv 2023-03-21 16:11:40 +01:00
parent be16b66ac0
commit f3f0dda3d4
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/builtin/include/ui/hex_editor.hpp
View File

@ -25,7 +25,10 @@ namespace hex::plugin::builtin::ui {
~HexEditor(); ~HexEditor();
void draw(float height = ImGui::GetContentRegionAvail().y); void draw(float height = ImGui::GetContentRegionAvail().y);
void setProvider(prv::Provider *provider) { this->m_provider = provider; } void setProvider(prv::Provider *provider) {
this->m_provider = provider;
this->m_currValidRegion = { Region::Invalid(), false };
}
void setUnknownDataCharacter(char character) { this->m_unknownDataCharacter = character; } void setUnknownDataCharacter(char character) { this->m_unknownDataCharacter = character; }
private: private:
enum class CellType { None, Hex, ASCII }; enum class CellType { None, Hex, ASCII };

2
plugins/builtin/source/ui/hex_editor.cpp
View File

@ -358,7 +358,7 @@ namespace hex::plugin::builtin::ui {
ImGui::TableNextColumn(); ImGui::TableNextColumn();
if (this->m_provider != nullptr && this->m_provider->isReadable()) { if (this->m_provider != nullptr && this->m_provider->isReadable()) {
const auto isCurrRegionValid = [this](u64 address){ const auto isCurrRegionValid = [this](u64 address) {
auto &[currRegion, currRegionValid] = this->m_currValidRegion; auto &[currRegion, currRegionValid] = this->m_currValidRegion;
if (!Region{ address, 1 }.isWithin(currRegion)) { if (!Region{ address, 1 }.isWithin(currRegion)) {
this->m_currValidRegion = this->m_provider->getRegionValidity(address); this->m_currValidRegion = this->m_provider->getRegionValidity(address);