b646ece14b
### Problem description This PR addresses issue #2013 that described a cluttered Event Manager. This is a DX issue and should not impact the users whatsoever. ### Implementation description The changes revolve around three main points: 1. the Event Manager (`event_manager.hpp`) was split into four categories: GUI, Interaction, Lifecycle, and Provider, and two types: Events, and Requests. This results in the following files: - `events_gui.hpp` - `events_interaction.hpp` - `events_lifecycle.hpp` - `events_provider.hpp` - `requests_gui.hpp` - `requests_interaction.hpp` - `requests_lifecycle.hpp` - `requests_provider.hpp` 2. Every event and request now has its own piece of documentation, with a `@brief`, accompanied by a longer comment if needed, and gets its `@param`s described. 3. The old `event_manager.hpp` import was removed and replaced by the correct imports wherever needed, as to reduce spread of those files only to where they are truly useful. ### Additional things The commits have been split into (chrono-)logical steps: - `feat`: split the Event Manager, and replace the imports - `refactor`, `chore`: make various small changes to match the required structure - `docs`: add documentation for events and requests Hopefully, this will help to review the PR. *Note: Beware of very long rebuild times in between the commits, use them sparingly! The Actions will ensure this PR builds anyways* Closes #2013 --------- Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com> Co-authored-by: Nik <werwolv98@gmail.com>
58 lines
1.4 KiB
C++
58 lines
1.4 KiB
C++
#include <hex.hpp>
|
|
|
|
#include <hex/helpers/utils.hpp>
|
|
#include <hex/helpers/logger.hpp>
|
|
#include <hex/test/tests.hpp>
|
|
#include <hex/api/plugin_manager.hpp>
|
|
#include <hex/api/task_manager.hpp>
|
|
#include <hex/api/events/events_lifecycle.hpp>
|
|
|
|
#include <cstdlib>
|
|
|
|
int test(int argc, char **argv) {
|
|
// Check if a test to run has been provided
|
|
if (argc != 2) {
|
|
hex::log::fatal("Invalid number of arguments specified! {}", argc);
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
// Check if that test exists
|
|
std::string testName = argv[1];
|
|
if (!hex::test::Tests::get().contains(testName)) {
|
|
hex::log::fatal("No test with name {} found!", testName);
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
auto test = hex::test::Tests::get()[testName];
|
|
|
|
auto result = test.function();
|
|
|
|
if (test.shouldFail) {
|
|
switch (result) {
|
|
case EXIT_SUCCESS:
|
|
return EXIT_FAILURE;
|
|
case EXIT_FAILURE:
|
|
return EXIT_SUCCESS;
|
|
default:
|
|
return result;
|
|
}
|
|
} else {
|
|
return result;
|
|
}
|
|
}
|
|
|
|
int main(int argc, char **argv) {
|
|
int result = test(argc, argv);
|
|
|
|
if (result == EXIT_SUCCESS)
|
|
hex::log::info("Success!");
|
|
else
|
|
hex::log::info("Failed!");
|
|
|
|
hex::TaskManager::exit();
|
|
hex::EventImHexClosing::post();
|
|
hex::EventManager::clear();
|
|
hex::PluginManager::unload();
|
|
|
|
return result;
|
|
} |