b646ece14b
### Problem description This PR addresses issue #2013 that described a cluttered Event Manager. This is a DX issue and should not impact the users whatsoever. ### Implementation description The changes revolve around three main points: 1. the Event Manager (`event_manager.hpp`) was split into four categories: GUI, Interaction, Lifecycle, and Provider, and two types: Events, and Requests. This results in the following files: - `events_gui.hpp` - `events_interaction.hpp` - `events_lifecycle.hpp` - `events_provider.hpp` - `requests_gui.hpp` - `requests_interaction.hpp` - `requests_lifecycle.hpp` - `requests_provider.hpp` 2. Every event and request now has its own piece of documentation, with a `@brief`, accompanied by a longer comment if needed, and gets its `@param`s described. 3. The old `event_manager.hpp` import was removed and replaced by the correct imports wherever needed, as to reduce spread of those files only to where they are truly useful. ### Additional things The commits have been split into (chrono-)logical steps: - `feat`: split the Event Manager, and replace the imports - `refactor`, `chore`: make various small changes to match the required structure - `docs`: add documentation for events and requests Hopefully, this will help to review the PR. *Note: Beware of very long rebuild times in between the commits, use them sparingly! The Actions will ensure this PR builds anyways* Closes #2013 --------- Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com> Co-authored-by: Nik <werwolv98@gmail.com>
79 lines
2.7 KiB
C++
79 lines
2.7 KiB
C++
#include "content/views/view_provider_settings.hpp"
|
|
|
|
#include <hex/api/content_registry.hpp>
|
|
#include <hex/api/task_manager.hpp>
|
|
#include <hex/api/events/events_provider.hpp>
|
|
|
|
#include <toasts/toast_notification.hpp>
|
|
|
|
namespace hex::plugin::builtin {
|
|
|
|
ViewProviderSettings::ViewProviderSettings() : View::Modal("hex.builtin.view.provider_settings.name") {
|
|
EventProviderCreated::subscribe(this, [this](const hex::prv::Provider *provider) {
|
|
if (provider->hasLoadInterface() && !provider->shouldSkipLoadInterface())
|
|
this->getWindowOpenState() = true;
|
|
});
|
|
|
|
ContentRegistry::Interface::addSidebarItem(ICON_VS_SERVER_PROCESS, [] {
|
|
auto provider = hex::ImHexApi::Provider::get();
|
|
|
|
if (provider != nullptr)
|
|
provider->drawInterface();
|
|
},
|
|
[] {
|
|
auto provider = hex::ImHexApi::Provider::get();
|
|
|
|
return provider != nullptr && provider->hasInterface() && provider->isAvailable();
|
|
});
|
|
}
|
|
|
|
ViewProviderSettings::~ViewProviderSettings() {
|
|
EventProviderCreated::unsubscribe(this);
|
|
}
|
|
|
|
void ViewProviderSettings::drawContent() {
|
|
auto provider = hex::ImHexApi::Provider::get();
|
|
if (provider != nullptr) {
|
|
bool settingsValid = provider->drawLoadInterface();
|
|
|
|
ImGui::NewLine();
|
|
ImGui::Separator();
|
|
|
|
ImGui::BeginDisabled(!settingsValid);
|
|
if (ImGui::Button("hex.ui.common.open"_lang)) {
|
|
if (provider->open()) {
|
|
EventProviderOpened::post(provider);
|
|
|
|
this->getWindowOpenState() = false;
|
|
ImGui::CloseCurrentPopup();
|
|
}
|
|
else {
|
|
this->getWindowOpenState() = false;
|
|
ImGui::CloseCurrentPopup();
|
|
auto errorMessage = provider->getErrorMessage();
|
|
if (errorMessage.empty()) {
|
|
ui::ToastError::open("hex.builtin.view.provider_settings.load_error"_lang);
|
|
} else {
|
|
ui::ToastError::open(hex::format("hex.builtin.view.provider_settings.load_error_details"_lang, errorMessage));
|
|
}
|
|
TaskManager::doLater([=] { ImHexApi::Provider::remove(provider); });
|
|
}
|
|
}
|
|
ImGui::EndDisabled();
|
|
|
|
ImGui::SameLine();
|
|
|
|
if (ImGui::Button("hex.ui.common.cancel"_lang)) {
|
|
ImGui::CloseCurrentPopup();
|
|
this->getWindowOpenState() = false;
|
|
TaskManager::doLater([=] { ImHexApi::Provider::remove(provider); });
|
|
}
|
|
}
|
|
}
|
|
|
|
bool ViewProviderSettings::hasViewMenuItemEntry() const {
|
|
return false;
|
|
}
|
|
|
|
}
|