2dcaf2c77b
### Problem description As described in #1846: - the `Edit the Hex` achievement doesn't unlock when it should - the `ROM Hacks` achievement is not using event-driven architecture (the functions call `unlockAchievement` themselves) ### Implementation description Firstly, for the `Edit the Hex` achievement: - replaced the old event listener on `EventPatchCreated` with a listener on `EventProviderDataModified`, which picks up bytes changes - ensured the provider data change comes from a File provider, else unlocking the achievement wouldn't make sense - *Note*: a discovered side effect is that the "Fill" function modifies the provider byte per byte (with a for loop) - there is no use in testing the size of the data change, as it is always 1 byte - the Fill function could probably be reworked to fill in whole regions at a time? About the `ROM Hacks` achievement: - implemented the new, still unused `EventPatchCreated` event. - signal signature is `const unsigned char *, u64, const IPSKind`: buffer pointer, buffer size, and IPS kind (IPS/IPS32) - make use of the `::post` and `::subscribe` methods on said event to unlock the achievement - **WARNING::behaviour change**: the event's `post` signal has been moved in the success branch of the IPS generation condition, meaning that achievement will only unlock if IPS patch export has worked. I felt it would make more sense than unlocking an achievement on an error, if there was any to raise. --------- Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>