SparkyTD 5f192d5dc7 impr: Don't move hex editor scroll position when jumping to address that's on-screen (#1660) ... ### Problem description This PR offers two improvements: 1) When selecting / jumping to an offset that falls within the current viewport of the scroll view, the scroll offset will no longer force the selected byte to the top of the view. Instead, the scroll offset will only be changed if the selected byte is outside the current view. 2) In case a wrong offset is entered into the Select or Goto dialog (e.g. and offset beyond EoF), the dialog's button will be disabled. ### Implementation description For the first change, I modified the logic that recalculates the `m_scrollPosition ` based on the current byte offset. For the second change, I added validation logic to both popups to ensure that the entered offsets are valid (using `provider->getActualSize()`). In case of the Select popup, I wrapped the button into an `ImGui::Begin/EndDisabled` to enforce the validation check.		2024-05-10 21:20:10 +02:00
..
hex_editor.cpp	impr: Don't move hex editor scroll position when jumping to address that's on-screen (#1660)	2024-05-10 21:20:10 +02:00
pattern_drawer.cpp	fix: Pattern data view rendering of bitfields within bitfields being broken	2024-05-07 23:32:51 +02:00