### Problem description This PR implements some rudimentary Xcode support for building and editing ImHex. ### Implementation description #### Problem 1: Xcode is a multi-configuration buildsystem The project is already rather CMake generator independent, thus it did not need to change much to support Xcode's multi-configuration paradigm: By default, CMake generates a `.xcodeproj` in which targets build their artifacts into the specified `<>_OUTPUT_DIRECTORY`, postfixed by the currently active configuration. To better fit the existing paradigm, I instead opted ot introduce `IMHEX_MAIN_OUTPUT_DIRECTORY`. This variable is equal to the previously used `RUNTIME_OUTPUT_DIRECTORY` when using other generators, and is changed to include a configuration specific _prefix_ when used with Xcode. The result is different output directories when using Xcode, and no changes when using any other generator. #### Problem 2: ImHex does not support AppleClang To allow building the codebase with Xcode, I have introduced `IMHEX_IDE_HELPERS_OVERRIDE_XCODE_COMPILER`. Specifying this option to `ON` will force CMake to honor the user specified compiler settings, even when using the Xcode generator. In practice this can be used together with the new "xcode" CMakePreset to build the project with mainline clang using `xcodebuild`, or Xcode itself by generating a buildsystem like so: ``` cmake --preset xcode -DCMAKE_PREFIX_PATH=/opt/homebrew/opt/llvm@17 ``` This solution is of course not without flaws. The inner workings are a particularly ugly hack, and mainline clang does not implement the necessary extensions to allow Xcode to index the code. Regardless this option is useful to enable future work in terms of bundling/signing macOS applications in the "intended" way using Xcode without additional source modifications. #### Problem 3: Vanilla CMake + Xcode = Bad developer UX By default, the CMake generated `.xcodeproj` is a mess. Tons of targets are scattered about, and source files are not organized beyond grouping them into a "Source Files" and "Header Files" group. Even "Header Files" is missing, because the ImHex build system does not regard private header files of libraries as sources of a target, and Xcode does not try to guess this information. The solution is twofold: * Additional code has been added which organizes the targets into a neat folder structure * Additional code was added behind a configuration flag `IMHEX_IDE_HELPERS_INTRUSIVE_IDE_TWEAKS` which automatically creates source file trees in Xcode targets, and discovers the non-declared header files via the folder convention. ### Screenshots N/A ### Additional things As a bonus: `IMHEX_OFFLINE_BUILD` assumes that ImHex-Patterns is cloned into the source tree. I have added an additional fallback that tries to locate it as a sibling folder of `${CMAKE_SOURCE_DIR}`, as this meshes better with my filesystem setup. The setup was tested with `CMake 3.29.2`, `Xcode 15.2`, and `llvm@17` from homebrew.
117 lines
5.0 KiB
CMake
117 lines
5.0 KiB
CMake
macro(add_imhex_plugin)
|
|
# Parse arguments
|
|
set(options LIBRARY_PLUGIN)
|
|
set(oneValueArgs NAME IMHEX_VERSION)
|
|
set(multiValueArgs SOURCES INCLUDES LIBRARIES FEATURES)
|
|
cmake_parse_arguments(IMHEX_PLUGIN "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
|
|
|
|
if (IMHEX_PLUGIN_IMHEX_VERSION)
|
|
message(STATUS "Compiling plugin ${IMHEX_PLUGIN_NAME} for ImHex Version ${IMHEX_PLUGIN_IMHEX_VERSION}")
|
|
set(IMHEX_VERSION_STRING "${IMHEX_PLUGIN_IMHEX_VERSION}")
|
|
endif()
|
|
|
|
if (IMHEX_STATIC_LINK_PLUGINS)
|
|
set(IMHEX_PLUGIN_LIBRARY_TYPE STATIC)
|
|
|
|
target_link_libraries(libimhex PUBLIC ${IMHEX_PLUGIN_NAME})
|
|
|
|
configure_file(${CMAKE_SOURCE_DIR}/dist/web/plugin-bundle.cpp.in ${CMAKE_CURRENT_BINARY_DIR}/plugin-bundle.cpp @ONLY)
|
|
target_sources(main PUBLIC ${CMAKE_CURRENT_BINARY_DIR}/plugin-bundle.cpp)
|
|
set(IMHEX_PLUGIN_SUFFIX ".hexplug")
|
|
else()
|
|
if (IMHEX_PLUGIN_LIBRARY_PLUGIN)
|
|
set(IMHEX_PLUGIN_LIBRARY_TYPE SHARED)
|
|
set(IMHEX_PLUGIN_SUFFIX ".hexpluglib")
|
|
else()
|
|
set(IMHEX_PLUGIN_LIBRARY_TYPE MODULE)
|
|
set(IMHEX_PLUGIN_SUFFIX ".hexplug")
|
|
endif()
|
|
endif()
|
|
|
|
# Define new project for plugin
|
|
project(${IMHEX_PLUGIN_NAME})
|
|
|
|
# Create a new shared library for the plugin source code
|
|
add_library(${IMHEX_PLUGIN_NAME} ${IMHEX_PLUGIN_LIBRARY_TYPE} ${IMHEX_PLUGIN_SOURCES})
|
|
|
|
# Add include directories and link libraries
|
|
target_include_directories(${IMHEX_PLUGIN_NAME} PUBLIC ${IMHEX_PLUGIN_INCLUDES})
|
|
target_link_libraries(${IMHEX_PLUGIN_NAME} PUBLIC ${IMHEX_PLUGIN_LIBRARIES})
|
|
target_link_libraries(${IMHEX_PLUGIN_NAME} PRIVATE libimhex ${FMT_LIBRARIES} imgui_all_includes libwolv)
|
|
addIncludesFromLibrary(${IMHEX_PLUGIN_NAME} libpl)
|
|
addIncludesFromLibrary(${IMHEX_PLUGIN_NAME} libpl-gen)
|
|
|
|
precompileHeaders(${IMHEX_PLUGIN_NAME} "${CMAKE_CURRENT_SOURCE_DIR}/include")
|
|
|
|
# Add IMHEX_PROJECT_NAME and IMHEX_VERSION define
|
|
target_compile_definitions(${IMHEX_PLUGIN_NAME} PRIVATE IMHEX_PROJECT_NAME="${IMHEX_PLUGIN_NAME}")
|
|
target_compile_definitions(${IMHEX_PLUGIN_NAME} PRIVATE IMHEX_VERSION="${IMHEX_VERSION_STRING}")
|
|
target_compile_definitions(${IMHEX_PLUGIN_NAME} PRIVATE IMHEX_PLUGIN_NAME=${IMHEX_PLUGIN_NAME})
|
|
|
|
# Enable required compiler flags
|
|
enableUnityBuild(${IMHEX_PLUGIN_NAME})
|
|
setupCompilerFlags(${IMHEX_PLUGIN_NAME})
|
|
|
|
# Configure build properties
|
|
set_target_properties(${IMHEX_PLUGIN_NAME}
|
|
PROPERTIES
|
|
RUNTIME_OUTPUT_DIRECTORY "${IMHEX_MAIN_OUTPUT_DIRECTORY}/plugins"
|
|
CXX_STANDARD 23
|
|
PREFIX ""
|
|
SUFFIX ${IMHEX_PLUGIN_SUFFIX}
|
|
)
|
|
|
|
# Set rpath of plugin libraries to the plugins folder
|
|
if (APPLE)
|
|
set_target_properties(${IMHEX_PLUGIN_NAME} PROPERTIES BUILD_RPATH "@executable_path/../Frameworks;@executable_path/plugins")
|
|
endif()
|
|
|
|
# Setup a romfs for the plugin
|
|
list(APPEND LIBROMFS_RESOURCE_LOCATION ${CMAKE_CURRENT_SOURCE_DIR}/romfs)
|
|
set(LIBROMFS_PROJECT_NAME ${IMHEX_PLUGIN_NAME})
|
|
add_subdirectory(${IMHEX_BASE_FOLDER}/lib/external/libromfs ${CMAKE_CURRENT_BINARY_DIR}/libromfs)
|
|
target_link_libraries(${IMHEX_PLUGIN_NAME} PRIVATE ${LIBROMFS_LIBRARY})
|
|
|
|
foreach(feature ${IMHEX_PLUGIN_FEATURES})
|
|
string(TOUPPER ${feature} feature)
|
|
add_definitions(-DIMHEX_PLUGIN_${IMHEX_PLUGIN_NAME}_FEATURE_${feature}=0)
|
|
endforeach()
|
|
|
|
# Add the new plugin to the main dependency list so it gets built by default
|
|
if (TARGET imhex_all)
|
|
add_dependencies(imhex_all ${IMHEX_PLUGIN_NAME})
|
|
endif()
|
|
|
|
if (IMHEX_EXTERNAL_PLUGIN_BUILD)
|
|
install(TARGETS ${IMHEX_PLUGIN_NAME} DESTINATION ".")
|
|
endif()
|
|
|
|
# Fix rpath
|
|
if (APPLE)
|
|
set_target_properties(${IMHEX_PLUGIN_NAME} PROPERTIES INSTALL_RPATH "@executable_path/../Frameworks;@executable_path/plugins")
|
|
elseif (UNIX)
|
|
set_target_properties(${IMHEX_PLUGIN_NAME} PROPERTIES INSTALL_RPATH_USE_ORIGIN ON INSTALL_RPATH "$ORIGIN/")
|
|
endif()
|
|
|
|
if (EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/tests/CMakeLists.txt AND IMHEX_ENABLE_UNIT_TESTS)
|
|
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/tests)
|
|
target_link_libraries(${IMHEX_PLUGIN_NAME} PUBLIC ${IMHEX_PLUGIN_NAME}_tests)
|
|
target_compile_definitions(${IMHEX_PLUGIN_NAME}_tests PRIVATE IMHEX_PROJECT_NAME="${IMHEX_PLUGIN_NAME}-tests")
|
|
endif()
|
|
endmacro()
|
|
|
|
macro(add_romfs_resource input output)
|
|
configure_file(${input} ${CMAKE_CURRENT_BINARY_DIR}/romfs/${output} COPYONLY)
|
|
|
|
list(APPEND LIBROMFS_RESOURCE_LOCATION ${CMAKE_CURRENT_BINARY_DIR}/romfs)
|
|
endmacro()
|
|
|
|
macro (enable_plugin_feature feature)
|
|
string(TOUPPER ${feature} feature)
|
|
if (NOT (feature IN_LIST IMHEX_PLUGIN_FEATURES))
|
|
message(FATAL_ERROR "Feature ${feature} is not enabled for plugin ${IMHEX_PLUGIN_NAME}")
|
|
endif()
|
|
|
|
remove_definitions(-DIMHEX_PLUGIN_${IMHEX_PLUGIN_NAME}_FEATURE_${feature}=0)
|
|
add_definitions(-DIMHEX_PLUGIN_${IMHEX_PLUGIN_NAME}_FEATURE_${feature}=1)
|
|
endmacro() |