1
0
mirror of synced 2024-11-14 19:17:42 +01:00
ImHex/lib/third_party/imgui
Sten Feldman d70f7422b7
feat: Support Copy/Paste on WASM build outside the application border (#1542)
### Problem description
WASM build does not support copy/paste beyond the application. Meaning,
there's no practical way of sending text back and forth across the
application border.

There are lengthy threads why this is a technical challenge in
WASM/Browser world, e.g:
- https://github.com/pthom/hello_imgui/issues/3
- https://github.com/emscripten-core/emscripten/pull/19510

### Implementation description
Implements a workaround solution as Header only C++ library, as proposed
and implemented at:
https://github.com/Armchair-Software/emscripten-browser-clipboard

Maybe there are cleaner ways of achieving the functionality. Definitely
would like to have some discussion around this. 👀

ℹ️ The proposed PR "works for me" on Windows, using CTRL-C/V shortcuts
to copy text from and to the application. On MacOS the system shortcut
to Paste is different from what ImHex has defined. This results in
system Paste shortcut of command-V triggering the browser callback to
synchronise the application clipboard, but no actual Paste takes place
within ImHex.

If there would be a clean way to trigger the paste command, that would
be wonderful (or get the context and references to write the data to the
cursor, but I was unable to find a clean solution). The only proposed
solutions in the referenced threads were about triggering paste event
internally via Key events. This seemed wonky 🙃 , so is not currently
implemented. At the moment the paste on MacOS is command+V followed by
control+V.

### Additional things
This is definitely a stopgap solution before the ImGui and Emscripten
take a more proper solution in enabling Copy/Paste outside the
application borders. However, I feel like this is a must have capability
to make the WASM build more useful, not just for trying out ImHex.

Cheers! 🍻

---------

Co-authored-by: Nik <werwolv98@gmail.com>
2024-02-13 20:30:18 +01:00
..
ColorTextEditor build: Fix various issues with linking, clang and unity builds 2024-01-29 22:57:39 +01:00
custom feat: Support Copy/Paste on WASM build outside the application border (#1542) 2024-02-13 20:30:18 +01:00
imgui build: Updated ImGui to the latest release 2024-02-11 00:11:56 +01:00
imnodes build: Fix various issues with linking, clang and unity builds 2024-01-29 22:57:39 +01:00
implot build: Fix various issues with linking, clang and unity builds 2024-01-29 22:57:39 +01:00
CMakeLists.txt impr: Restructure various components much better (#1520) 2024-01-28 22:14:59 +01:00