mirror of
https://github.com/GreemDev/Ryujinx.git
synced 2024-12-22 23:05:55 +01:00
1b28ecd63e
* Vulkan: Simplify waitable add/remove Removal of unnecessary hashset and dictionary * Thread safety for GetBufferData in PersistentFlushBuffer * Fix WaitForFencesImpl thread safety * Proper methods for risky reference increments * Wrong type of CB. * Address feedback
254 lines
9.3 KiB
C#
254 lines
9.3 KiB
C#
using Silk.NET.Vulkan;
|
|
using System;
|
|
|
|
namespace Ryujinx.Graphics.Vulkan
|
|
{
|
|
/// <summary>
|
|
/// Holder for multiple host GPU fences.
|
|
/// </summary>
|
|
class MultiFenceHolder
|
|
{
|
|
private static int BufferUsageTrackingGranularity = 4096;
|
|
|
|
private readonly FenceHolder[] _fences;
|
|
private BufferUsageBitmap _bufferUsageBitmap;
|
|
|
|
/// <summary>
|
|
/// Creates a new instance of the multiple fence holder.
|
|
/// </summary>
|
|
public MultiFenceHolder()
|
|
{
|
|
_fences = new FenceHolder[CommandBufferPool.MaxCommandBuffers];
|
|
}
|
|
|
|
/// <summary>
|
|
/// Creates a new instance of the multiple fence holder, with a given buffer size in mind.
|
|
/// </summary>
|
|
/// <param name="size">Size of the buffer</param>
|
|
public MultiFenceHolder(int size)
|
|
{
|
|
_fences = new FenceHolder[CommandBufferPool.MaxCommandBuffers];
|
|
_bufferUsageBitmap = new BufferUsageBitmap(size, BufferUsageTrackingGranularity);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Adds buffer usage information to the uses list.
|
|
/// </summary>
|
|
/// <param name="cbIndex">Index of the command buffer where the buffer is used</param>
|
|
/// <param name="offset">Offset of the buffer being used</param>
|
|
/// <param name="size">Size of the buffer region being used, in bytes</param>
|
|
public void AddBufferUse(int cbIndex, int offset, int size)
|
|
{
|
|
_bufferUsageBitmap.Add(cbIndex, offset, size);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Removes all buffer usage information for a given command buffer.
|
|
/// </summary>
|
|
/// <param name="cbIndex">Index of the command buffer where the buffer is used</param>
|
|
public void RemoveBufferUses(int cbIndex)
|
|
{
|
|
_bufferUsageBitmap?.Clear(cbIndex);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Checks if a given range of a buffer is being used by a command buffer still being processed by the GPU.
|
|
/// </summary>
|
|
/// <param name="cbIndex">Index of the command buffer where the buffer is used</param>
|
|
/// <param name="offset">Offset of the buffer being used</param>
|
|
/// <param name="size">Size of the buffer region being used, in bytes</param>
|
|
/// <returns>True if in use, false otherwise</returns>
|
|
public bool IsBufferRangeInUse(int cbIndex, int offset, int size)
|
|
{
|
|
return _bufferUsageBitmap.OverlapsWith(cbIndex, offset, size);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Checks if a given range of a buffer is being used by any command buffer still being processed by the GPU.
|
|
/// </summary>
|
|
/// <param name="offset">Offset of the buffer being used</param>
|
|
/// <param name="size">Size of the buffer region being used, in bytes</param>
|
|
/// <returns>True if in use, false otherwise</returns>
|
|
public bool IsBufferRangeInUse(int offset, int size)
|
|
{
|
|
return _bufferUsageBitmap.OverlapsWith(offset, size);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Adds a fence to the holder.
|
|
/// </summary>
|
|
/// <param name="cbIndex">Command buffer index of the command buffer that owns the fence</param>
|
|
/// <param name="fence">Fence to be added</param>
|
|
/// <returns>True if the command buffer's previous fence value was null</returns>
|
|
public bool AddFence(int cbIndex, FenceHolder fence)
|
|
{
|
|
ref FenceHolder fenceRef = ref _fences[cbIndex];
|
|
|
|
if (fenceRef == null)
|
|
{
|
|
fenceRef = fence;
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Removes a fence from the holder.
|
|
/// </summary>
|
|
/// <param name="cbIndex">Command buffer index of the command buffer that owns the fence</param>
|
|
public void RemoveFence(int cbIndex)
|
|
{
|
|
_fences[cbIndex] = null;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Determines if a fence referenced on the given command buffer.
|
|
/// </summary>
|
|
/// <param name="cbIndex">Index of the command buffer to check if it's used</param>
|
|
/// <returns>True if referenced, false otherwise</returns>
|
|
public bool HasFence(int cbIndex)
|
|
{
|
|
return _fences[cbIndex] != null;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Wait until all the fences on the holder are signaled.
|
|
/// </summary>
|
|
/// <param name="api">Vulkan API instance</param>
|
|
/// <param name="device">GPU device that the fences belongs to</param>
|
|
public void WaitForFences(Vk api, Device device)
|
|
{
|
|
WaitForFencesImpl(api, device, 0, 0, false, 0UL);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Wait until all the fences on the holder with buffer uses overlapping the specified range are signaled.
|
|
/// </summary>
|
|
/// <param name="api">Vulkan API instance</param>
|
|
/// <param name="device">GPU device that the fences belongs to</param>
|
|
/// <param name="offset">Start offset of the buffer range</param>
|
|
/// <param name="size">Size of the buffer range in bytes</param>
|
|
public void WaitForFences(Vk api, Device device, int offset, int size)
|
|
{
|
|
WaitForFencesImpl(api, device, offset, size, false, 0UL);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Wait until all the fences on the holder are signaled, or the timeout expires.
|
|
/// </summary>
|
|
/// <param name="api">Vulkan API instance</param>
|
|
/// <param name="device">GPU device that the fences belongs to</param>
|
|
/// <param name="timeout">Timeout in nanoseconds</param>
|
|
/// <returns>True if all fences were signaled, false otherwise</returns>
|
|
public bool WaitForFences(Vk api, Device device, ulong timeout)
|
|
{
|
|
return WaitForFencesImpl(api, device, 0, 0, true, timeout);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Wait until all the fences on the holder with buffer uses overlapping the specified range are signaled.
|
|
/// </summary>
|
|
/// <param name="api">Vulkan API instance</param>
|
|
/// <param name="device">GPU device that the fences belongs to</param>
|
|
/// <param name="offset">Start offset of the buffer range</param>
|
|
/// <param name="size">Size of the buffer range in bytes</param>
|
|
/// <param name="hasTimeout">Indicates if <paramref name="timeout"/> should be used</param>
|
|
/// <param name="timeout">Timeout in nanoseconds</param>
|
|
/// <returns>True if all fences were signaled before the timeout expired, false otherwise</returns>
|
|
private bool WaitForFencesImpl(Vk api, Device device, int offset, int size, bool hasTimeout, ulong timeout)
|
|
{
|
|
Span<FenceHolder> fenceHolders = new FenceHolder[CommandBufferPool.MaxCommandBuffers];
|
|
|
|
int count = size != 0 ? GetOverlappingFences(fenceHolders, offset, size) : GetFences(fenceHolders);
|
|
Span<Fence> fences = stackalloc Fence[count];
|
|
|
|
int fenceCount = 0;
|
|
|
|
for (int i = 0; i < count; i++)
|
|
{
|
|
if (fenceHolders[i].TryGet(out Fence fence))
|
|
{
|
|
fences[fenceCount] = fence;
|
|
|
|
if (fenceCount < i)
|
|
{
|
|
fenceHolders[fenceCount] = fenceHolders[i];
|
|
}
|
|
|
|
fenceCount++;
|
|
}
|
|
}
|
|
|
|
if (fenceCount == 0)
|
|
{
|
|
return true;
|
|
}
|
|
|
|
bool signaled = true;
|
|
|
|
if (hasTimeout)
|
|
{
|
|
signaled = FenceHelper.AllSignaled(api, device, fences.Slice(0, fenceCount), timeout);
|
|
}
|
|
else
|
|
{
|
|
FenceHelper.WaitAllIndefinitely(api, device, fences.Slice(0, fenceCount));
|
|
}
|
|
|
|
for (int i = 0; i < fenceCount; i++)
|
|
{
|
|
fenceHolders[i].Put();
|
|
}
|
|
|
|
return signaled;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Gets fences to wait for.
|
|
/// </summary>
|
|
/// <param name="storage">Span to store fences in</param>
|
|
/// <returns>Number of fences placed in storage</returns>
|
|
private int GetFences(Span<FenceHolder> storage)
|
|
{
|
|
int count = 0;
|
|
|
|
for (int i = 0; i < _fences.Length; i++)
|
|
{
|
|
var fence = _fences[i];
|
|
|
|
if (fence != null)
|
|
{
|
|
storage[count++] = fence;
|
|
}
|
|
}
|
|
|
|
return count;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Gets fences to wait for use of a given buffer region.
|
|
/// </summary>
|
|
/// <param name="storage">Span to store overlapping fences in</param>
|
|
/// <param name="offset">Offset of the range</param>
|
|
/// <param name="size">Size of the range in bytes</param>
|
|
/// <returns>Number of fences for the specified region placed in storage</returns>
|
|
private int GetOverlappingFences(Span<FenceHolder> storage, int offset, int size)
|
|
{
|
|
int count = 0;
|
|
|
|
for (int i = 0; i < _fences.Length; i++)
|
|
{
|
|
var fence = _fences[i];
|
|
|
|
if (fence != null && _bufferUsageBitmap.OverlapsWith(i, offset, size))
|
|
{
|
|
storage[count++] = fence;
|
|
}
|
|
}
|
|
|
|
return count;
|
|
}
|
|
}
|
|
}
|