Cool_Tools/bemanitools
1
0
Fork 0
mirror of https://github.com/djhackersdev/bemanitools.git synced 2024-12-02 18:17:16 +01:00
Code Releases Activity

Allow generic HID devices with broken(?) outputs to still work as inputs.

Browse Source 
Fixes Sony DualShock 4 not working
This commit is contained in:
ahnada 2023-11-12 18:00:03 -08:00 committed by icex2
parent 09b3a6c24a
commit 0fdde8b32d
1 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/main/geninput/hid-meta-out.c
View File

@ -48,7 +48,12 @@ arrays_fail:
hid_meta_out_fini_caps(meta); hid_meta_out_fini_caps(meta);
caps_fail: caps_fail:
return false; /**
* Still allow the device to be used as input.
* Useful for devices like the Sony DUALSHOCK 4, where it indicates it can receive outputs
* but it errors out when trying to initialize an output report.
*/
return true;
} }
static bool static bool
@ -99,9 +104,11 @@ hid_meta_out_init_caps(struct hid_meta_out *meta, PHIDP_PREPARSED_DATA ppd)
caps_val_fail: caps_val_fail:
free(meta->caps_val); free(meta->caps_val);
meta->caps_val = NULL;
caps_btn_fail: caps_btn_fail:
free(meta->caps_btn); free(meta->caps_btn);
meta->caps_btn = NULL;
caps_tlc_fail: caps_tlc_fail:
return false; return false;
@ -114,7 +121,6 @@ static bool hid_meta_out_init_arrays(struct hid_meta_out *meta)
bool *report_presence; bool *report_presence;
unsigned int nreports; unsigned int nreports;
unsigned int i; unsigned int i;
uint8_t *bytes;
size_t nbytes; size_t nbytes;
size_t count; size_t count;
@ -174,7 +180,6 @@ static bool hid_meta_out_init_arrays(struct hid_meta_out *meta)
for (i = 0; i < 0x100; i++) { for (i = 0; i < 0x100; i++) {
if (report_presence[i]) { if (report_presence[i]) {
nbytes = meta->caps_tlc.OutputReportByteLength; nbytes = meta->caps_tlc.OutputReportByteLength;
bytes = xmalloc(meta->caps_tlc.OutputReportByteLength);
if (!hid_report_out_init( if (!hid_report_out_init(
&meta->reports[meta->nreports], &meta->reports[meta->nreports],
@ -198,14 +203,22 @@ static bool hid_meta_out_init_arrays(struct hid_meta_out *meta)
return true; return true;
r_init_fail: r_init_fail:
free(bytes);
for (i = meta->nreports; i > 0; i--) { for (i = meta->nreports; i > 0; i--) {
hid_report_out_fini(&meta->reports[i - 1]); hid_report_out_fini(&meta->reports[i - 1]);
} }
free(report_presence); free(report_presence);
// Clear out all output/light data
meta->nreports = 0;
free(meta->reports); free(meta->reports);
meta->reports = NULL;
meta->nlights = 0;
meta->nbuttons = 0;
// Failed out before allocating memory
meta->lights = NULL;
meta->priv_lights = NULL;
return false; return false;
} }
@ -433,5 +446,8 @@ static void hid_meta_out_fini_arrays(struct hid_meta_out *meta)
static void hid_meta_out_fini_caps(struct hid_meta_out *meta) static void hid_meta_out_fini_caps(struct hid_meta_out *meta)
{ {
free(meta->caps_btn); free(meta->caps_btn);
meta->caps_btn = NULL;
free(meta->caps_val); free(meta->caps_val);
meta->caps_val = NULL;
} }