Cool_Tools/bemaniutils
1
0
Fork 0
mirror of synced 2024-11-27 23:50:47 +01:00
Code Releases Activity

Additional guardrails against remote user IDs in local DB.

Browse Source
This commit is contained in:
Jennifer Taylor 2023-08-19 18:02:07 +00:00
parent 2e8b08b296
commit dca2194a57
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
bemani/data/mysql/user.py
View File

@ -377,6 +377,10 @@ class UserData(BaseData):
userid - Integer user ID, as looked up by one of the above functions. userid - Integer user ID, as looked up by one of the above functions.
cardid - 16-digit card ID to add. cardid - 16-digit card ID to add.
""" """
if RemoteUser.is_remote(userid):
raise AccountCreationException(
"Should not add local cards to remote users!"
)
sql = "INSERT INTO card (userid, id) VALUES (:userid, :cardid)" sql = "INSERT INTO card (userid, id) VALUES (:userid, :cardid)"
self.execute(sql, {"userid": userid, "cardid": cardid}) self.execute(sql, {"userid": userid, "cardid": cardid})
@ -1315,7 +1319,9 @@ class UserData(BaseData):
if extid is not None: if extid is not None:
return extid return extid
else: else:
raise AccountCreationException() raise AccountCreationException(
"Failed to cteate a new refid/extid pair!"
)
def create_session(self, userid: UserID, expiration: int = (30 * 86400)) -> str: def create_session(self, userid: UserID, expiration: int = (30 * 86400)) -> str:
""" """
@ -1403,7 +1409,9 @@ class UserData(BaseData):
}, },
) )
if cursor.rowcount != 1: if cursor.rowcount != 1:
raise AccountCreationException() raise AccountCreationException(
"Failed to create and fetch a new refid!"
)
return refid return refid
except IntegrityError: except IntegrityError:
# We maybe lost the race? Look up the ID from another creation. Don't call get_refid # We maybe lost the race? Look up the ID from another creation. Don't call get_refid
@ -1416,7 +1424,7 @@ class UserData(BaseData):
result = cursor.fetchone() result = cursor.fetchone()
return result["refid"] return result["refid"]
# Shouldn't be possible, but here we are # Shouldn't be possible, but here we are
raise AccountCreationException() raise AccountCreationException("Failed to recover lost race refid!")
def create_account(self, cardid: str, pin: str) -> Optional[UserID]: def create_account(self, cardid: str, pin: str) -> Optional[UserID]:
""" """