Cool_Tools/imgui
1
0
Fork 0
mirror of https://github.com/ocornut/imgui.git synced 2025-02-11 16:33:11 +01:00
Code Releases Wiki Activity

ImDrawList: fixed 1 leak per ImDrawList using the ChannelsSplit() API (via Columns) (fix #318)

Browse Source
This commit is contained in:
ocornut 2015-09-03 23:42:08 +01:00
parent dbc7903da8
commit e34ad0a05a
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
imgui_draw.cpp
View File

@ -157,12 +157,22 @@ void ImDrawList::ChannelsSplit(int channels_count)
if (old_channels_count < channels_count) if (old_channels_count < channels_count)
_Channels.resize(channels_count); _Channels.resize(channels_count);
_ChannelsCount = channels_count; _ChannelsCount = channels_count;
for (int i = 0; i < channels_count; i++)
// _Channels[] (24 bytes each) hold storage that we'll swap with this->_CmdBuffer/_IdxBuffer
// The content of _Channels[0] at this point doesn't matter. We clear it to make state tidy in a debugger but we don't strictly need to.
// When we switch to the next channel, we'll copy _CmdBuffer/_IdxBuffer into _Channels[0] and then _Channels[1] into _CmdBuffer/_IdxBuffer
memset(&_Channels[0], 0, sizeof(ImDrawChannel));
for (int i = 1; i < channels_count; i++)
{ {
if (i >= old_channels_count) if (i >= old_channels_count)
{
new(&_Channels[i]) ImDrawChannel(); new(&_Channels[i]) ImDrawChannel();
else if (i > 0) }
_Channels[i].CmdBuffer.resize(0), _Channels[i].IdxBuffer.resize(0); else
{
_Channels[i].CmdBuffer.resize(0);
_Channels[i].IdxBuffer.resize(0);
}
if (_Channels[i].CmdBuffer.Size == 0) if (_Channels[i].CmdBuffer.Size == 0)
{ {
ImDrawCmd draw_cmd; ImDrawCmd draw_cmd;