From 94658ac221f917017a5c714a2ad04eb526a329ca Mon Sep 17 00:00:00 2001 From: Colin Basnett Date: Mon, 2 Oct 2023 22:59:58 -0700 Subject: [PATCH 1/3] Update issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 34 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 20 +++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 0000000..f2d30b6 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,34 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: '' +assignees: '' + +--- + +**Versions** +Blender: (example: 3.6.2) +io_scene_psk_psa: (example: 5.0.0) + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Files** +Please post attachments of the PSK and/or PSA files that you are using to encounter the bug, if any. + +**Additional context** +Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 0000000..bbcbbe7 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: '' +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. From 122e765bcad241b0b333d02f84c4e08f5555169e Mon Sep 17 00:00:00 2001 From: Colin Basnett Date: Thu, 19 Oct 2023 13:14:57 -0700 Subject: [PATCH 2/3] PSA sequences are now selected by default There were multiple bug reports from users who were getting mixed signals from the addon, believing that the bone name warnings were the cause of the sequences not being imported. The actual issue was that users didn't know they needed to manually select the sequences within the PSA. This should fix the poor UX around this, as just having it selected by default is more sensible for a wider audience. --- io_scene_psk_psa/__init__.py | 2 +- io_scene_psk_psa/psa/export/properties.py | 2 +- io_scene_psk_psa/psa/import_/properties.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/io_scene_psk_psa/__init__.py b/io_scene_psk_psa/__init__.py index 9f240c8..3e4774d 100644 --- a/io_scene_psk_psa/__init__.py +++ b/io_scene_psk_psa/__init__.py @@ -1,7 +1,7 @@ bl_info = { "name": "PSK/PSA Importer/Exporter", "author": "Colin Basnett, Yurii Ti", - "version": (5, 0, 5), + "version": (5, 0, 6), "blender": (3, 4, 0), "description": "PSK/PSA Import/Export (.psk/.psa)", "warning": "", diff --git a/io_scene_psk_psa/psa/export/properties.py b/io_scene_psk_psa/psa/export/properties.py index 1f75f74..a215501 100644 --- a/io_scene_psk_psa/psa/export/properties.py +++ b/io_scene_psk_psa/psa/export/properties.py @@ -19,7 +19,7 @@ empty_set = set() class PSA_PG_export_action_list_item(PropertyGroup): action: PointerProperty(type=Action) name: StringProperty() - is_selected: BoolProperty(default=False) + is_selected: BoolProperty(default=True) frame_start: IntProperty(options={'HIDDEN'}) frame_end: IntProperty(options={'HIDDEN'}) is_pose_marker: BoolProperty(options={'HIDDEN'}) diff --git a/io_scene_psk_psa/psa/import_/properties.py b/io_scene_psk_psa/psa/import_/properties.py index b90ade6..668e17b 100644 --- a/io_scene_psk_psa/psa/import_/properties.py +++ b/io_scene_psk_psa/psa/import_/properties.py @@ -10,7 +10,7 @@ empty_set = set() class PSA_PG_import_action_list_item(PropertyGroup): action_name: StringProperty(options=empty_set) - is_selected: BoolProperty(default=False, options=empty_set) + is_selected: BoolProperty(default=True, options=empty_set) class PSA_PG_bone(PropertyGroup): From 2a5a4b2a3df105f516e1229140fc7cc1b431d612 Mon Sep 17 00:00:00 2001 From: Colin Basnett Date: Thu, 19 Oct 2023 13:24:06 -0700 Subject: [PATCH 3/3] Added sanity check for populating the bone group list --- io_scene_psk_psa/helpers.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/io_scene_psk_psa/helpers.py b/io_scene_psk_psa/helpers.py index fe683e0..9f70ee8 100644 --- a/io_scene_psk_psa/helpers.py +++ b/io_scene_psk_psa/helpers.py @@ -59,6 +59,9 @@ def populate_bone_group_list(armature_object: Object, bone_group_list: bpy.props has_selected_groups = any([g.is_selected for g in bone_group_list]) unassigned_group_is_selected, selected_assigned_group_names = True, [] + if armature_object is None: + return + if has_selected_groups: # Preserve group selections before clearing the list. # We handle selections for the unassigned group separately to cover the edge case