From 72891b8bcb6f160ed0b4fd43c0697b64ebb0ce01 Mon Sep 17 00:00:00 2001
From: Benjamin Staneck <staneck@gmail.com>
Date: Wed, 18 Dec 2019 20:42:40 +0100
Subject: [PATCH] Improved Lighthouse score (#1391)

* a few accessibility fixes from lighthouse report

* add rel="noopener" to external links

* add title attribute to social links

* add mimetype to manifest link and allow it to work behind auth

* add font-display: swap to all the places where external fonts are used

* remove font-display: swap from icon fonts

* removed font-display from style blocks in base

* add target="_blank" to social links

* switch base fonts grabbed from Google back to display:fallback

As per recommendation from https://developers.google.com/web/updates/2016/02/font-display#fallback

* add target="_blank" to the footer links as well
---
 src/assets/stylesheets/base/_icons.scss | 1 -
 src/base.html                           | 2 +-
 src/partials/footer.html                | 4 ++--
 src/partials/header.html                | 3 ++-
 src/partials/nav.html                   | 2 +-
 src/partials/search.html                | 2 +-
 src/partials/social.html                | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/assets/stylesheets/base/_icons.scss b/src/assets/stylesheets/base/_icons.scss
index 8721fa5ba..a7024e66b 100644
--- a/src/assets/stylesheets/base/_icons.scss
+++ b/src/assets/stylesheets/base/_icons.scss
@@ -35,7 +35,6 @@
   line-height: 1;
   text-transform: none;
   white-space: nowrap;
-  speak: none;
   word-wrap: normal;
   direction: ltr;
 
diff --git a/src/base.html b/src/base.html
index 1e743d806..eb3344876 100644
--- a/src/base.html
+++ b/src/base.html
@@ -165,7 +165,7 @@
 
     <!-- Progressive Web App Manifest -->
     {% if config.extra.manifest %}
-      <link rel="manifest" href="{{ config.extra.manifest | url }}">
+      <link rel="manifest" type="application/manifest+json" href="{{ config.extra.manifest | url }}" crossorigin="use-credentials">
     {% endif %}
 
     <!-- Custom stylesheets -->
diff --git a/src/partials/footer.html b/src/partials/footer.html
index de9f0e8ad..95b7caca6 100644
--- a/src/partials/footer.html
+++ b/src/partials/footer.html
@@ -89,9 +89,9 @@
           </div>
         {% endif %}
         powered by
-        <a href="https://www.mkdocs.org">MkDocs</a>
+        <a href="https://www.mkdocs.org" target="_blank" rel="noopener">MkDocs</a>
         and
-        <a href="https://squidfunk.github.io/mkdocs-material/">
+        <a href="https://squidfunk.github.io/mkdocs-material/" target="_blank" rel="noopener">
           Material for MkDocs</a>
       </div>
 
diff --git a/src/partials/header.html b/src/partials/header.html
index b5167af91..806fa3b78 100644
--- a/src/partials/header.html
+++ b/src/partials/header.html
@@ -31,11 +31,12 @@
       <div class="md-flex__cell md-flex__cell--shrink">
         <a href="{{ config.site_url | default(nav.homepage.url, true) | url }}"
             title="{{ config.site_name }}"
+            aria-label="{{ config.site_name }}"
             class="md-header-nav__button md-logo">
           {% if config.theme.logo.icon %}
             <i class="md-icon">{{ config.theme.logo.icon }}</i>
           {% else %}
-            <img src="{{ config.theme.logo | url }}" width="24" height="24" />
+            <img alt="logo" src="{{ config.theme.logo | url }}" width="24" height="24" />
           {% endif %}
         </a>
       </div>
diff --git a/src/partials/nav.html b/src/partials/nav.html
index 5791d0916..72c2059d7 100644
--- a/src/partials/nav.html
+++ b/src/partials/nav.html
@@ -30,7 +30,7 @@
       {% if config.theme.logo.icon %}
         <i class="md-icon">{{ config.theme.logo.icon }}</i>
       {% else %}
-        <img src="{{ config.theme.logo | url }}" width="48" height="48" />
+        <img alt="logo" src="{{ config.theme.logo | url }}" width="48" height="48" />
       {% endif %}
     </a>
     {{ config.site_name }}
diff --git a/src/partials/search.html b/src/partials/search.html
index 6a2a270ff..6aa37ba53 100644
--- a/src/partials/search.html
+++ b/src/partials/search.html
@@ -27,7 +27,7 @@
   <label class="md-search__overlay" for="__search"></label>
   <div class="md-search__inner" role="search">
     <form class="md-search__form" name="search">
-      <input type="text" class="md-search__input" name="query"
+      <input type="text" class="md-search__input" aria-label="search" name="query"
           placeholder="{{ lang.t('search.placeholder') }}"
           autocapitalize="off" autocorrect="off" autocomplete="off"
           spellcheck="false" data-md-component="query"
diff --git a/src/partials/social.html b/src/partials/social.html
index 97fc14b79..8942005b8 100644
--- a/src/partials/social.html
+++ b/src/partials/social.html
@@ -26,7 +26,7 @@
     <link rel="stylesheet" type="text/css"
         href="{{ 'assets/fonts/font-awesome.css' | url }}" />
     {% for social in config.extra.social %}
-      <a href="{{ social.link }}" class="md-footer-social__link
+      <a href="{{ social.link }}" target="_blank" rel="noopener" title="{{ social.type }}" class="md-footer-social__link
             fa fa-{{ social.type }}"></a>
     {% endfor %}
   </div>