Cool_Tools/vgmstream
1
0
Fork 0
mirror of https://github.com/vgmstream/vgmstream.git synced 2025-02-21 12:51:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1467 from dr0biwan/patch-1

Browse Source 
Fixes a divide by zero crash in .asc
This commit is contained in:
bnnm 2024-01-03 23:32:33 +01:00 committed by GitHub
commit 9ea73c958e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/meta/dc_asd.c
View File

@ -8,6 +8,7 @@ VGMSTREAM * init_vgmstream_dc_asd(STREAMFILE *streamFile) {
off_t start_offset; off_t start_offset;
int loop_flag; int loop_flag;
int channel_count; int channel_count;
int sample_rate;
/* check extension, case insensitive */ /* check extension, case insensitive */
streamFile->get_name(streamFile,filename,sizeof(filename)); streamFile->get_name(streamFile,filename,sizeof(filename));
@ -18,9 +19,17 @@ VGMSTREAM * init_vgmstream_dc_asd(STREAMFILE *streamFile) {
we'll compare it... */ we'll compare it... */
if (read_32bitLE(0x0,streamFile) != read_32bitLE(0x4,streamFile)) if (read_32bitLE(0x0,streamFile) != read_32bitLE(0x4,streamFile))
goto fail; goto fail;
/* ableton related files can be incorrectly sent to this which don't have
the same style of header and unless we null check we get a divide by zero
crash... */
sample_rate = read_32bitLE(0xC,streamFile);
if (!sample_rate)
goto fail;
/* compare the frequency with the bitrate, if it doesn't match we'll close /* compare the frequency with the bitrate, if it doesn't match we'll close
the vgmstream... */ the vgmstream... */
if (read_32bitLE(0x10,streamFile)/read_32bitLE(0xC,streamFile) != (uint16_t)read_16bitLE(0xA,streamFile)*2) if (read_32bitLE(0x10,streamFile)/sample_rate != (uint16_t)read_16bitLE(0xA,streamFile)*2)
goto fail; goto fail;
loop_flag = 0; loop_flag = 0;
@ -33,7 +42,7 @@ VGMSTREAM * init_vgmstream_dc_asd(STREAMFILE *streamFile) {
/* fill in the vital statistics */ /* fill in the vital statistics */
start_offset = get_streamfile_size(streamFile) - read_32bitLE(0x0,streamFile); start_offset = get_streamfile_size(streamFile) - read_32bitLE(0x0,streamFile);
vgmstream->channels = channel_count; vgmstream->channels = channel_count;
vgmstream->sample_rate = read_32bitLE(0x0C,streamFile); vgmstream->sample_rate = sample_rate;
vgmstream->coding_type = coding_PCM16LE; vgmstream->coding_type = coding_PCM16LE;
vgmstream->num_samples = read_32bitLE(0x0,streamFile)/2/channel_count; vgmstream->num_samples = read_32bitLE(0x0,streamFile)/2/channel_count;
if (loop_flag) { if (loop_flag) {