From c8315cf8f66dbf20096407944c24171b783b02db Mon Sep 17 00:00:00 2001 From: undido Date: Thu, 25 Sep 2014 07:23:10 -0300 Subject: [PATCH] Changed the way create.php checks for existing usernames to be less intensive on the database --- create.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/create.php b/create.php index 447a33c9..12914ee1 100644 --- a/create.php +++ b/create.php @@ -72,12 +72,13 @@ foreach ($bannedWords as $i => $w) { error("Cannot create board matching banned pattern $w"); } } -$query = prepare('SELECT * FROM ``mods``'); +$query = prepare('SELECT ``username`` FROM ``mods`` WHERE ``username`` = :username'); +$query->bindValue(':username', $username); $query->execute() or error(db_error($query)); $users = $query->fetchAll(PDO::FETCH_ASSOC); -foreach ($users as $i => $user) { - if ($user['username'] == $username) - error('Username taken!'); + +if (sizeof($users) > 0){ +error('The username you\'ve tried to enter already exists!'); } $salt = generate_salt();