Cool_Tools/vichan
1
0
Fork 0
mirror of https://github.com/vichan-devel/vichan.git synced 2025-01-31 20:25:32 +01:00
Code Releases Wiki Activity

Merge pull request #744 from vichan-devel/RealAngeleno-httpsonly

Browse Source 
modify how https only works, disabling by default and allowing cloudflare.
This commit is contained in:
Lorenzo Yario 2024-05-11 04:46:58 -07:00 committed by GitHub
commit de91423a9f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
inc/config.php
View File

@ -194,9 +194,8 @@
// Whether or not you can access the mod cookie in JavaScript. Most users should not need to change this. // Whether or not you can access the mod cookie in JavaScript. Most users should not need to change this.
$config['cookies']['httponly'] = true; $config['cookies']['httponly'] = true;
// Do not allow logins via unencrypted HTTP. Should only be changed in testing environments or if you connect to a // Do not allow logins via unencrypted HTTP. If your website uses HTTPS, turn this on.
// load-balancer without encryption. $config['cookies']['secure_login_only'] = false;
$config['cookies']['secure_login_only'] = true;
// Used to salt secure tripcodes ("##trip") and poster IDs (if enabled). // Used to salt secure tripcodes ("##trip") and poster IDs (if enabled).
$config['secure_trip_salt'] = ')(*&^%$#@!98765432190zyxwvutsrqponmlkjihgfedcba'; $config['secure_trip_salt'] = ')(*&^%$#@!98765432190zyxwvutsrqponmlkjihgfedcba';

10
inc/functions/net.php
View File

@ -6,5 +6,13 @@ namespace Vichan\Functions\Net;
* @return bool Returns if the client-server connection is an encrypted one (HTTPS). * @return bool Returns if the client-server connection is an encrypted one (HTTPS).
*/ */
function is_connection_secure(): bool { function is_connection_secure(): bool {
return !empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off'; if (!empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off') {
return true;
}
elseif (isset($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] === 'https') {
return true;
}
else {
return false;
}
} }

5
install.php
View File

@ -5,11 +5,6 @@ define('VERSION', '5.2.0');
require 'inc/bootstrap.php'; require 'inc/bootstrap.php';
loadConfig(); loadConfig();
if (!is_writable('inc/secrets.php') || !is_writable('inc/')) {
echo 'install.php does not have permission to write to /inc/secrets.php and/or /inc/, without permission the installer cannot continue';
exit();
}
// Salt generators // Salt generators
class SaltGen { class SaltGen {
public $salt_length = 128; public $salt_length = 128;