From 9f77e04c76e36e1cbbf49bc9eb385fa6ef804b67 Mon Sep 17 00:00:00 2001 From: Kenshin9977 <33557877+Kenshin9977@users.noreply.github.com> Date: Sun, 23 Feb 2025 09:50:43 +0100 Subject: [PATCH] Fix external downloader availability when using `--ffmpeg-location` (#12318) This fix is only applicable to the CLI option Authored by: Kenshin9977 --- yt_dlp/downloader/external.py | 2 -- yt_dlp/postprocessor/ffmpeg.py | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/yt_dlp/downloader/external.py b/yt_dlp/downloader/external.py index 7f6b5b45cc..ee73ac043e 100644 --- a/yt_dlp/downloader/external.py +++ b/yt_dlp/downloader/external.py @@ -457,8 +457,6 @@ class FFmpegFD(ExternalFD): @classmethod def available(cls, path=None): - # TODO: Fix path for ffmpeg - # Fixme: This may be wrong when --ffmpeg-location is used return FFmpegPostProcessor().available def on_process_started(self, proc, stdin): diff --git a/yt_dlp/postprocessor/ffmpeg.py b/yt_dlp/postprocessor/ffmpeg.py index 8965806ae7..e59e9832bd 100644 --- a/yt_dlp/postprocessor/ffmpeg.py +++ b/yt_dlp/postprocessor/ffmpeg.py @@ -202,7 +202,7 @@ class FFmpegPostProcessor(PostProcessor): @property def available(self): - return self.basename is not None + return bool(self._ffmpeg_location.get()) or self.basename is not None @property def executable(self):