From fe346461ffe6b664f48d1d3335e34445695d6ed4 Mon Sep 17 00:00:00 2001 From: pukkandan Date: Sat, 15 May 2021 19:12:26 +0530 Subject: [PATCH] Fix `--check-formats` when there is network error --- yt_dlp/YoutubeDL.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/yt_dlp/YoutubeDL.py b/yt_dlp/YoutubeDL.py index 9fe591f75..80e017c96 100644 --- a/yt_dlp/YoutubeDL.py +++ b/yt_dlp/YoutubeDL.py @@ -1726,9 +1726,13 @@ def _check_formats(formats): expand_path(paths.get('home', '').strip()), expand_path(paths.get('temp', '').strip()), 'ytdl.%s.f%s.check-format' % (random_uuidv4(), f['format_id'])) - dl, _ = self.dl(temp_file, f, test=True) - if os.path.exists(temp_file): - os.remove(temp_file) + try: + dl, _ = self.dl(temp_file, f, test=True) + except (ExtractorError, IOError, OSError, ValueError) + network_exceptions: + dl = False + finally: + if os.path.exists(temp_file): + os.remove(temp_file) if dl: yield f else: @@ -2395,7 +2399,7 @@ def process_info(self, info_dict): self.dl(sub_filename, sub_info.copy(), subtitle=True) sub_info['filepath'] = sub_filename files_to_move[sub_filename] = sub_filename_final - except tuple([ExtractorError, IOError, OSError, ValueError] + network_exceptions) as err: + except (ExtractorError, IOError, OSError, ValueError) + network_exceptions as err: self.report_warning('Unable to download subtitle for "%s": %s' % (sub_lang, error_to_compat_str(err))) continue