Cool_Tools/yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

loader/nso: Resolve moves not occurring in DecompressSegment

Browse Source 
Given the std::vector was const, an automatic move out of the function
could not occur.

We can allow automatic return value optimizations to occur by making the
buffer non-const.
This commit is contained in:
Lioncash 2020-04-17 19:26:48 -04:00
parent b8f5c71f2d
commit 441a2812ed
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/loader/nso.cpp
View File

@ -37,7 +37,7 @@ static_assert(sizeof(MODHeader) == 0x1c, "MODHeader has incorrect size.");
std::vector<u8> DecompressSegment(const std::vector<u8>& compressed_data, std::vector<u8> DecompressSegment(const std::vector<u8>& compressed_data,
const NSOSegmentHeader& header) { const NSOSegmentHeader& header) {
const std::vector<u8> uncompressed_data = std::vector<u8> uncompressed_data =
Common::Compression::DecompressDataLZ4(compressed_data, header.size); Common::Compression::DecompressDataLZ4(compressed_data, header.size);
ASSERT_MSG(uncompressed_data.size() == header.size, "{} != {}", header.size, ASSERT_MSG(uncompressed_data.size() == header.size, "{} != {}", header.size,