Cool_Tools/yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hle: kernel: Use C++ style comments in KScheduler, etc.

Browse Source
This commit is contained in:
bunnei 2020-12-04 23:37:35 -08:00
parent bc59ca92b6
commit b1326d9230
4 changed files with 136 additions and 152 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
src/core/hle/kernel/k_priority_queue.h
View File

@ -87,15 +87,15 @@ public:
} }
constexpr bool PushBack(s32 core, Member* member) { constexpr bool PushBack(s32 core, Member* member) {
/* Get the entry associated with the member. */ // Get the entry associated with the member.
Entry& member_entry = member->GetPriorityQueueEntry(core); Entry& member_entry = member->GetPriorityQueueEntry(core);
/* Get the entry associated with the end of the queue. */ // Get the entry associated with the end of the queue.
Member* tail = this->root[core].GetPrev(); Member* tail = this->root[core].GetPrev();
Entry& tail_entry = Entry& tail_entry =
(tail != nullptr) ? tail->GetPriorityQueueEntry(core) : this->root[core]; (tail != nullptr) ? tail->GetPriorityQueueEntry(core) : this->root[core];
/* Link the entries. */ // Link the entries.
member_entry.SetPrev(tail); member_entry.SetPrev(tail);
member_entry.SetNext(nullptr); member_entry.SetNext(nullptr);
tail_entry.SetNext(member); tail_entry.SetNext(member);
@ -105,15 +105,15 @@ public:
} }
constexpr bool PushFront(s32 core, Member* member) { constexpr bool PushFront(s32 core, Member* member) {
/* Get the entry associated with the member. */ // Get the entry associated with the member.
Entry& member_entry = member->GetPriorityQueueEntry(core); Entry& member_entry = member->GetPriorityQueueEntry(core);
/* Get the entry associated with the front of the queue. */ // Get the entry associated with the front of the queue.
Member* head = this->root[core].GetNext(); Member* head = this->root[core].GetNext();
Entry& head_entry = Entry& head_entry =
(head != nullptr) ? head->GetPriorityQueueEntry(core) : this->root[core]; (head != nullptr) ? head->GetPriorityQueueEntry(core) : this->root[core];
/* Link the entries. */ // Link the entries.
member_entry.SetPrev(nullptr); member_entry.SetPrev(nullptr);
member_entry.SetNext(head); member_entry.SetNext(head);
head_entry.SetPrev(member); head_entry.SetPrev(member);
@ -123,10 +123,10 @@ public:
} }
constexpr bool Remove(s32 core, Member* member) { constexpr bool Remove(s32 core, Member* member) {
/* Get the entry associated with the member. */ // Get the entry associated with the member.
Entry& member_entry = member->GetPriorityQueueEntry(core); Entry& member_entry = member->GetPriorityQueueEntry(core);
/* Get the entries associated with next and prev. */ // Get the entries associated with next and prev.
Member* prev = member_entry.GetPrev(); Member* prev = member_entry.GetPrev();
Member* next = member_entry.GetNext(); Member* next = member_entry.GetNext();
Entry& prev_entry = Entry& prev_entry =
@ -134,7 +134,7 @@ public:
Entry& next_entry = Entry& next_entry =
(next != nullptr) ? next->GetPriorityQueueEntry(core) : this->root[core]; (next != nullptr) ? next->GetPriorityQueueEntry(core) : this->root[core];
/* Unlink. */ // Unlink.
prev_entry.SetNext(next); prev_entry.SetNext(next);
next_entry.SetPrev(prev); next_entry.SetPrev(prev);
@ -152,8 +152,7 @@ public:
Common::BitSet64<NumPriority> available_priorities[NumCores]; Common::BitSet64<NumPriority> available_priorities[NumCores];
public: public:
constexpr KPriorityQueueImpl() : queues(), available_priorities() { /* ... */ constexpr KPriorityQueueImpl() : queues(), available_priorities() {}
}
constexpr void PushBack(s32 priority, s32 core, Member* member) { constexpr void PushBack(s32 priority, s32 core, Member* member) {
ASSERT(IsValidCore(core)); ASSERT(IsValidCore(core));
@ -267,14 +266,14 @@ private:
constexpr void PushBack(s32 priority, Member* member) { constexpr void PushBack(s32 priority, Member* member) {
ASSERT(IsValidPriority(priority)); ASSERT(IsValidPriority(priority));
/* Push onto the scheduled queue for its core, if we can. */ // Push onto the scheduled queue for its core, if we can.
u64 affinity = member->GetAffinityMask().GetAffinityMask(); u64 affinity = member->GetAffinityMask().GetAffinityMask();
if (const s32 core = member->GetActiveCore(); core >= 0) { if (const s32 core = member->GetActiveCore(); core >= 0) {
this->scheduled_queue.PushBack(priority, core, member); this->scheduled_queue.PushBack(priority, core, member);
ClearAffinityBit(affinity, core); ClearAffinityBit(affinity, core);
} }
/* And suggest the thread for all other cores. */ // And suggest the thread for all other cores.
while (affinity) { while (affinity) {
this->suggested_queue.PushBack(priority, GetNextCore(affinity), member); this->suggested_queue.PushBack(priority, GetNextCore(affinity), member);
} }
@ -283,15 +282,15 @@ private:
constexpr void PushFront(s32 priority, Member* member) { constexpr void PushFront(s32 priority, Member* member) {
ASSERT(IsValidPriority(priority)); ASSERT(IsValidPriority(priority));
/* Push onto the scheduled queue for its core, if we can. */ // Push onto the scheduled queue for its core, if we can.
u64 affinity = member->GetAffinityMask().GetAffinityMask(); u64 affinity = member->GetAffinityMask().GetAffinityMask();
if (const s32 core = member->GetActiveCore(); core >= 0) { if (const s32 core = member->GetActiveCore(); core >= 0) {
this->scheduled_queue.PushFront(priority, core, member); this->scheduled_queue.PushFront(priority, core, member);
ClearAffinityBit(affinity, core); ClearAffinityBit(affinity, core);
} }
/* And suggest the thread for all other cores. */ // And suggest the thread for all other cores.
/* Note: Nintendo pushes onto the back of the suggested queue, not the front. */ // Note: Nintendo pushes onto the back of the suggested queue, not the front.
while (affinity) { while (affinity) {
this->suggested_queue.PushBack(priority, GetNextCore(affinity), member); this->suggested_queue.PushBack(priority, GetNextCore(affinity), member);
} }
@ -300,24 +299,24 @@ private:
constexpr void Remove(s32 priority, Member* member) { constexpr void Remove(s32 priority, Member* member) {
ASSERT(IsValidPriority(priority)); ASSERT(IsValidPriority(priority));
/* Remove from the scheduled queue for its core. */ // Remove from the scheduled queue for its core.
u64 affinity = member->GetAffinityMask().GetAffinityMask(); u64 affinity = member->GetAffinityMask().GetAffinityMask();
if (const s32 core = member->GetActiveCore(); core >= 0) { if (const s32 core = member->GetActiveCore(); core >= 0) {
this->scheduled_queue.Remove(priority, core, member); this->scheduled_queue.Remove(priority, core, member);
ClearAffinityBit(affinity, core); ClearAffinityBit(affinity, core);
} }
/* Remove from the suggested queue for all other cores. */ // Remove from the suggested queue for all other cores.
while (affinity) { while (affinity) {
this->suggested_queue.Remove(priority, GetNextCore(affinity), member); this->suggested_queue.Remove(priority, GetNextCore(affinity), member);
} }
} }
public: public:
constexpr KPriorityQueue() : scheduled_queue(), suggested_queue() { /* ... */ constexpr KPriorityQueue() : scheduled_queue(), suggested_queue() { // ...
} }
/* Getters. */ // Getters.
constexpr Member* GetScheduledFront(s32 core) const { constexpr Member* GetScheduledFront(s32 core) const {
return this->scheduled_queue.GetFront(core); return this->scheduled_queue.GetFront(core);
} }
@ -346,7 +345,7 @@ public:
return member->GetPriorityQueueEntry(core).GetNext(); return member->GetPriorityQueueEntry(core).GetNext();
} }
/* Mutators. */ // Mutators.
constexpr void PushBack(Member* member) { constexpr void PushBack(Member* member) {
this->PushBack(member->GetPriority(), member); this->PushBack(member->GetPriority(), member);
} }
@ -364,15 +363,15 @@ public:
member); member);
} }
/* First class fancy operations. */ // First class fancy operations.
constexpr void ChangePriority(s32 prev_priority, bool is_running, Member* member) { constexpr void ChangePriority(s32 prev_priority, bool is_running, Member* member) {
ASSERT(IsValidPriority(prev_priority)); ASSERT(IsValidPriority(prev_priority));
/* Remove the member from the queues. */ // Remove the member from the queues.
const s32 new_priority = member->GetPriority(); const s32 new_priority = member->GetPriority();
this->Remove(prev_priority, member); this->Remove(prev_priority, member);
/* And enqueue. If the member is running, we want to keep it running. */ // And enqueue. If the member is running, we want to keep it running.
if (is_running) { if (is_running) {
this->PushFront(new_priority, member); this->PushFront(new_priority, member);
} else { } else {
@ -382,12 +381,12 @@ public:
constexpr void ChangeAffinityMask(s32 prev_core, const AffinityMaskType& prev_affinity, constexpr void ChangeAffinityMask(s32 prev_core, const AffinityMaskType& prev_affinity,
Member* member) { Member* member) {
/* Get the new information. */ // Get the new information.
const s32 priority = member->GetPriority(); const s32 priority = member->GetPriority();
const AffinityMaskType& new_affinity = member->GetAffinityMask(); const AffinityMaskType& new_affinity = member->GetAffinityMask();
const s32 new_core = member->GetActiveCore(); const s32 new_core = member->GetActiveCore();
/* Remove the member from all queues it was in before. */ // Remove the member from all queues it was in before.
for (s32 core = 0; core < static_cast<s32>(NumCores); core++) { for (s32 core = 0; core < static_cast<s32>(NumCores); core++) {
if (prev_affinity.GetAffinity(core)) { if (prev_affinity.GetAffinity(core)) {
if (core == prev_core) { if (core == prev_core) {
@ -398,7 +397,7 @@ public:
} }
} }
/* And add the member to all queues it should be in now. */ // And add the member to all queues it should be in now.
for (s32 core = 0; core < static_cast<s32>(NumCores); core++) { for (s32 core = 0; core < static_cast<s32>(NumCores); core++) {
if (new_affinity.GetAffinity(core)) { if (new_affinity.GetAffinity(core)) {
if (core == new_core) { if (core == new_core) {
@ -411,18 +410,18 @@ public:
} }
constexpr void ChangeCore(s32 prev_core, Member* member, bool to_front = false) { constexpr void ChangeCore(s32 prev_core, Member* member, bool to_front = false) {
/* Get the new information. */ // Get the new information.
const s32 new_core = member->GetActiveCore(); const s32 new_core = member->GetActiveCore();
const s32 priority = member->GetPriority(); const s32 priority = member->GetPriority();
/* We don't need to do anything if the core is the same. */ // We don't need to do anything if the core is the same.
if (prev_core != new_core) { if (prev_core != new_core) {
/* Remove from the scheduled queue for the previous core. */ // Remove from the scheduled queue for the previous core.
if (prev_core >= 0) { if (prev_core >= 0) {
this->scheduled_queue.Remove(priority, prev_core, member); this->scheduled_queue.Remove(priority, prev_core, member);
} }
/* Remove from the suggested queue and add to the scheduled queue for the new core. */ // Remove from the suggested queue and add to the scheduled queue for the new core.
if (new_core >= 0) { if (new_core >= 0) {
this->suggested_queue.Remove(priority, new_core, member); this->suggested_queue.Remove(priority, new_core, member);
if (to_front) { if (to_front) {
@ -432,7 +431,7 @@ public:
} }
} }
/* Add to the suggested queue for the previous core. */ // Add to the suggested queue for the previous core.
if (prev_core >= 0) { if (prev_core >= 0) {
this->suggested_queue.PushBack(priority, prev_core, member); this->suggested_queue.PushBack(priority, prev_core, member);
} }

203
src/core/hle/kernel/k_scheduler.cpp
View File

@ -84,35 +84,20 @@ u64 KScheduler::UpdateHighestPriorityThread(Thread* highest_thread) {
/*static*/ u64 KScheduler::UpdateHighestPriorityThreadsImpl(KernelCore& kernel) { /*static*/ u64 KScheduler::UpdateHighestPriorityThreadsImpl(KernelCore& kernel) {
ASSERT(kernel.GlobalSchedulerContext().IsLocked()); ASSERT(kernel.GlobalSchedulerContext().IsLocked());
/* Clear that we need to update. */ // Clear that we need to update.
ClearSchedulerUpdateNeeded(kernel); ClearSchedulerUpdateNeeded(kernel);
u64 cores_needing_scheduling = 0, idle_cores = 0; u64 cores_needing_scheduling = 0, idle_cores = 0;
Thread* top_threads[Core::Hardware::NUM_CPU_CORES]; Thread* top_threads[Core::Hardware::NUM_CPU_CORES];
auto& priority_queue = GetPriorityQueue(kernel); auto& priority_queue = GetPriorityQueue(kernel);
/* We want to go over all cores, finding the highest priority thread and determining if /// We want to go over all cores, finding the highest priority thread and determining if
* scheduling is needed for that core. */ /// scheduling is needed for that core.
for (size_t core_id = 0; core_id < Core::Hardware::NUM_CPU_CORES; core_id++) { for (size_t core_id = 0; core_id < Core::Hardware::NUM_CPU_CORES; core_id++) {
Thread* top_thread = priority_queue.GetScheduledFront((s32)core_id); Thread* top_thread = priority_queue.GetScheduledFront((s32)core_id);
if (top_thread != nullptr) { if (top_thread != nullptr) {
///* If the thread has no waiters, we need to check if the process has a thread pinned. // If the thread has no waiters, we need to check if the process has a thread pinned.
///*/ // TODO(bunnei): Implement thread pinning
// if (top_thread->GetNumKernelWaiters() == 0) {
// if (Process* parent = top_thread->GetOwnerProcess(); parent != nullptr) {
// if (Thread* pinned = parent->GetPinnedThread(core_id);
// pinned != nullptr && pinned != top_thread) {
// /* We prefer our parent's pinned thread if possible. However, we also
// don't
// * want to schedule un-runnable threads. */
// if (pinned->GetRawState() == Thread::ThreadState_Runnable) {
// top_thread = pinned;
// } else {
// top_thread = nullptr;
// }
// }
// }
//}
} else { } else {
idle_cores |= (1ULL << core_id); idle_cores |= (1ULL << core_id);
} }
@ -122,27 +107,27 @@ u64 KScheduler::UpdateHighestPriorityThread(Thread* highest_thread) {
kernel.Scheduler(core_id).UpdateHighestPriorityThread(top_threads[core_id]); kernel.Scheduler(core_id).UpdateHighestPriorityThread(top_threads[core_id]);
} }
/* Idle cores are bad. We're going to try to migrate threads to each idle core in turn. */ // Idle cores are bad. We're going to try to migrate threads to each idle core in turn.
while (idle_cores != 0) { while (idle_cores != 0) {
u32 core_id = Common::CountTrailingZeroes64(idle_cores); u32 core_id = Common::CountTrailingZeroes64(idle_cores);
if (Thread* suggested = priority_queue.GetSuggestedFront(core_id); suggested != nullptr) { if (Thread* suggested = priority_queue.GetSuggestedFront(core_id); suggested != nullptr) {
s32 migration_candidates[Core::Hardware::NUM_CPU_CORES]; s32 migration_candidates[Core::Hardware::NUM_CPU_CORES];
size_t num_candidates = 0; size_t num_candidates = 0;
/* While we have a suggested thread, try to migrate it! */ // While we have a suggested thread, try to migrate it!
while (suggested != nullptr) { while (suggested != nullptr) {
/* Check if the suggested thread is the top thread on its core. */ // Check if the suggested thread is the top thread on its core.
const s32 suggested_core = suggested->GetActiveCore(); const s32 suggested_core = suggested->GetActiveCore();
if (Thread* top_thread = if (Thread* top_thread =
(suggested_core >= 0) ? top_threads[suggested_core] : nullptr; (suggested_core >= 0) ? top_threads[suggested_core] : nullptr;
top_thread != suggested) { top_thread != suggested) {
/* Make sure we're not dealing with threads too high priority for migration. */ // Make sure we're not dealing with threads too high priority for migration.
if (top_thread != nullptr && if (top_thread != nullptr &&
top_thread->GetPriority() < HighestCoreMigrationAllowedPriority) { top_thread->GetPriority() < HighestCoreMigrationAllowedPriority) {
break; break;
} }
/* The suggested thread isn't bound to its core, so we can migrate it! */ // The suggested thread isn't bound to its core, so we can migrate it!
suggested->SetActiveCore(core_id); suggested->SetActiveCore(core_id);
priority_queue.ChangeCore(suggested_core, suggested); priority_queue.ChangeCore(suggested_core, suggested);
@ -152,30 +137,30 @@ u64 KScheduler::UpdateHighestPriorityThread(Thread* highest_thread) {
break; break;
} }
/* Note this core as a candidate for migration. */ // Note this core as a candidate for migration.
ASSERT(num_candidates < Core::Hardware::NUM_CPU_CORES); ASSERT(num_candidates < Core::Hardware::NUM_CPU_CORES);
migration_candidates[num_candidates++] = suggested_core; migration_candidates[num_candidates++] = suggested_core;
suggested = priority_queue.GetSuggestedNext(core_id, suggested); suggested = priority_queue.GetSuggestedNext(core_id, suggested);
} }
/* If suggested is nullptr, we failed to migrate a specific thread. So let's try all our // If suggested is nullptr, we failed to migrate a specific thread. So let's try all our
* candidate cores' top threads. */ // candidate cores' top threads.
if (suggested == nullptr) { if (suggested == nullptr) {
for (size_t i = 0; i < num_candidates; i++) { for (size_t i = 0; i < num_candidates; i++) {
/* Check if there's some other thread that can run on the candidate core. */ // Check if there's some other thread that can run on the candidate core.
const s32 candidate_core = migration_candidates[i]; const s32 candidate_core = migration_candidates[i];
suggested = top_threads[candidate_core]; suggested = top_threads[candidate_core];
if (Thread* next_on_candidate_core = if (Thread* next_on_candidate_core =
priority_queue.GetScheduledNext(candidate_core, suggested); priority_queue.GetScheduledNext(candidate_core, suggested);
next_on_candidate_core != nullptr) { next_on_candidate_core != nullptr) {
/* The candidate core can run some other thread! We'll migrate its current // The candidate core can run some other thread! We'll migrate its current
* top thread to us. */ // top thread to us.
top_threads[candidate_core] = next_on_candidate_core; top_threads[candidate_core] = next_on_candidate_core;
cores_needing_scheduling |= cores_needing_scheduling |=
kernel.Scheduler(candidate_core) kernel.Scheduler(candidate_core)
.UpdateHighestPriorityThread(top_threads[candidate_core]); .UpdateHighestPriorityThread(top_threads[candidate_core]);
/* Perform the migration. */ // Perform the migration.
suggested->SetActiveCore(core_id); suggested->SetActiveCore(core_id);
priority_queue.ChangeCore(candidate_core, suggested); priority_queue.ChangeCore(candidate_core, suggested);
@ -199,20 +184,20 @@ u64 KScheduler::UpdateHighestPriorityThread(Thread* highest_thread) {
u32 old_state) { u32 old_state) {
ASSERT(kernel.GlobalSchedulerContext().IsLocked()); ASSERT(kernel.GlobalSchedulerContext().IsLocked());
/* Check if the state has changed, because if it hasn't there's nothing to do. */ // Check if the state has changed, because if it hasn't there's nothing to do.
const auto cur_state = thread->scheduling_state; const auto cur_state = thread->scheduling_state;
if (cur_state == old_state) { if (cur_state == old_state) {
return; return;
} }
/* Update the priority queues. */ // Update the priority queues.
if (old_state == static_cast<u32>(ThreadSchedStatus::Runnable)) { if (old_state == static_cast<u32>(ThreadSchedStatus::Runnable)) {
/* If we were previously runnable, then we're not runnable now, and we should remove. */ // If we were previously runnable, then we're not runnable now, and we should remove.
GetPriorityQueue(kernel).Remove(thread); GetPriorityQueue(kernel).Remove(thread);
IncrementScheduledCount(thread); IncrementScheduledCount(thread);
SetSchedulerUpdateNeeded(kernel); SetSchedulerUpdateNeeded(kernel);
} else if (cur_state == static_cast<u32>(ThreadSchedStatus::Runnable)) { } else if (cur_state == static_cast<u32>(ThreadSchedStatus::Runnable)) {
/* If we're now runnable, then we weren't previously, and we should add. */ // If we're now runnable, then we weren't previously, and we should add.
GetPriorityQueue(kernel).PushBack(thread); GetPriorityQueue(kernel).PushBack(thread);
IncrementScheduledCount(thread); IncrementScheduledCount(thread);
SetSchedulerUpdateNeeded(kernel); SetSchedulerUpdateNeeded(kernel);
@ -224,7 +209,7 @@ u64 KScheduler::UpdateHighestPriorityThread(Thread* highest_thread) {
ASSERT(kernel.GlobalSchedulerContext().IsLocked()); ASSERT(kernel.GlobalSchedulerContext().IsLocked());
/* If the thread is runnable, we want to change its priority in the queue. */ // If the thread is runnable, we want to change its priority in the queue.
if (thread->scheduling_state == static_cast<u32>(ThreadSchedStatus::Runnable)) { if (thread->scheduling_state == static_cast<u32>(ThreadSchedStatus::Runnable)) {
GetPriorityQueue(kernel).ChangePriority( GetPriorityQueue(kernel).ChangePriority(
old_priority, thread == kernel.CurrentScheduler()->GetCurrentThread(), thread); old_priority, thread == kernel.CurrentScheduler()->GetCurrentThread(), thread);
@ -238,7 +223,7 @@ u64 KScheduler::UpdateHighestPriorityThread(Thread* highest_thread) {
s32 old_core) { s32 old_core) {
ASSERT(kernel.GlobalSchedulerContext().IsLocked()); ASSERT(kernel.GlobalSchedulerContext().IsLocked());
/* If the thread is runnable, we want to change its affinity in the queue. */ // If the thread is runnable, we want to change its affinity in the queue.
if (thread->scheduling_state == static_cast<u32>(ThreadSchedStatus::Runnable)) { if (thread->scheduling_state == static_cast<u32>(ThreadSchedStatus::Runnable)) {
GetPriorityQueue(kernel).ChangeAffinityMask(old_core, old_affinity, thread); GetPriorityQueue(kernel).ChangeAffinityMask(old_core, old_affinity, thread);
IncrementScheduledCount(thread); IncrementScheduledCount(thread);
@ -249,11 +234,11 @@ u64 KScheduler::UpdateHighestPriorityThread(Thread* highest_thread) {
void KScheduler::RotateScheduledQueue(s32 core_id, s32 priority) { void KScheduler::RotateScheduledQueue(s32 core_id, s32 priority) {
ASSERT(system.GlobalSchedulerContext().IsLocked()); ASSERT(system.GlobalSchedulerContext().IsLocked());
/* Get a reference to the priority queue. */ // Get a reference to the priority queue.
auto& kernel = system.Kernel(); auto& kernel = system.Kernel();
auto& priority_queue = GetPriorityQueue(kernel); auto& priority_queue = GetPriorityQueue(kernel);
/* Rotate the front of the queue to the end. */ // Rotate the front of the queue to the end.
Thread* top_thread = priority_queue.GetScheduledFront(core_id, priority); Thread* top_thread = priority_queue.GetScheduledFront(core_id, priority);
Thread* next_thread = nullptr; Thread* next_thread = nullptr;
if (top_thread != nullptr) { if (top_thread != nullptr) {
@ -264,27 +249,27 @@ void KScheduler::RotateScheduledQueue(s32 core_id, s32 priority) {
} }
} }
/* While we have a suggested thread, try to migrate it! */ // While we have a suggested thread, try to migrate it!
{ {
Thread* suggested = priority_queue.GetSuggestedFront(core_id, priority); Thread* suggested = priority_queue.GetSuggestedFront(core_id, priority);
while (suggested != nullptr) { while (suggested != nullptr) {
/* Check if the suggested thread is the top thread on its core. */ // Check if the suggested thread is the top thread on its core.
const s32 suggested_core = suggested->GetActiveCore(); const s32 suggested_core = suggested->GetActiveCore();
if (Thread* top_on_suggested_core = if (Thread* top_on_suggested_core =
(suggested_core >= 0) ? priority_queue.GetScheduledFront(suggested_core) (suggested_core >= 0) ? priority_queue.GetScheduledFront(suggested_core)
: nullptr; : nullptr;
top_on_suggested_core != suggested) { top_on_suggested_core != suggested) {
/* If the next thread is a new thread that has been waiting longer than our // If the next thread is a new thread that has been waiting longer than our
* suggestion, we prefer it to our suggestion. */ // suggestion, we prefer it to our suggestion.
if (top_thread != next_thread && next_thread != nullptr && if (top_thread != next_thread && next_thread != nullptr &&
next_thread->GetLastScheduledTick() < suggested->GetLastScheduledTick()) { next_thread->GetLastScheduledTick() < suggested->GetLastScheduledTick()) {
suggested = nullptr; suggested = nullptr;
break; break;
} }
/* If we're allowed to do a migration, do one. */ // If we're allowed to do a migration, do one.
/* NOTE: Unlike migrations in UpdateHighestPriorityThread, this moves the suggestion // NOTE: Unlike migrations in UpdateHighestPriorityThread, this moves the suggestion
* to the front of the queue. */ // to the front of the queue.
if (top_on_suggested_core == nullptr || if (top_on_suggested_core == nullptr ||
top_on_suggested_core->GetPriority() >= HighestCoreMigrationAllowedPriority) { top_on_suggested_core->GetPriority() >= HighestCoreMigrationAllowedPriority) {
suggested->SetActiveCore(core_id); suggested->SetActiveCore(core_id);
@ -294,38 +279,38 @@ void KScheduler::RotateScheduledQueue(s32 core_id, s32 priority) {
} }
} }
/* Get the next suggestion. */ // Get the next suggestion.
suggested = priority_queue.GetSamePriorityNext(core_id, suggested); suggested = priority_queue.GetSamePriorityNext(core_id, suggested);
} }
} }
/* Now that we might have migrated a thread with the same priority, check if we can do better. // Now that we might have migrated a thread with the same priority, check if we can do better.
*/
{ {
Thread* best_thread = priority_queue.GetScheduledFront(core_id); Thread* best_thread = priority_queue.GetScheduledFront(core_id);
if (best_thread == GetCurrentThread()) { if (best_thread == GetCurrentThread()) {
best_thread = priority_queue.GetScheduledNext(core_id, best_thread); best_thread = priority_queue.GetScheduledNext(core_id, best_thread);
} }
/* If the best thread we can choose has a priority the same or worse than ours, try to // If the best thread we can choose has a priority the same or worse than ours, try to
* migrate a higher priority thread. */ // migrate a higher priority thread.
if (best_thread != nullptr && best_thread->GetPriority() >= static_cast<u32>(priority)) { if (best_thread != nullptr && best_thread->GetPriority() >= static_cast<u32>(priority)) {
Thread* suggested = priority_queue.GetSuggestedFront(core_id); Thread* suggested = priority_queue.GetSuggestedFront(core_id);
while (suggested != nullptr) { while (suggested != nullptr) {
/* If the suggestion's priority is the same as ours, don't bother. */ // If the suggestion's priority is the same as ours, don't bother.
if (suggested->GetPriority() >= best_thread->GetPriority()) { if (suggested->GetPriority() >= best_thread->GetPriority()) {
break; break;
} }
/* Check if the suggested thread is the top thread on its core. */ // Check if the suggested thread is the top thread on its core.
const s32 suggested_core = suggested->GetActiveCore(); const s32 suggested_core = suggested->GetActiveCore();
if (Thread* top_on_suggested_core = if (Thread* top_on_suggested_core =
(suggested_core >= 0) ? priority_queue.GetScheduledFront(suggested_core) (suggested_core >= 0) ? priority_queue.GetScheduledFront(suggested_core)
: nullptr; : nullptr;
top_on_suggested_core != suggested) { top_on_suggested_core != suggested) {
/* If we're allowed to do a migration, do one. */ // If we're allowed to do a migration, do one.
/* NOTE: Unlike migrations in UpdateHighestPriorityThread, this moves the // NOTE: Unlike migrations in UpdateHighestPriorityThread, this moves the
* suggestion to the front of the queue. */ // suggestion to the front of the queue.
if (top_on_suggested_core == nullptr || if (top_on_suggested_core == nullptr ||
top_on_suggested_core->GetPriority() >= top_on_suggested_core->GetPriority() >=
HighestCoreMigrationAllowedPriority) { HighestCoreMigrationAllowedPriority) {
@ -336,13 +321,13 @@ void KScheduler::RotateScheduledQueue(s32 core_id, s32 priority) {
} }
} }
/* Get the next suggestion. */ // Get the next suggestion.
suggested = priority_queue.GetSuggestedNext(core_id, suggested); suggested = priority_queue.GetSuggestedNext(core_id, suggested);
} }
} }
} }
/* After a rotation, we need a scheduler update. */ // After a rotation, we need a scheduler update.
SetSchedulerUpdateNeeded(kernel); SetSchedulerUpdateNeeded(kernel);
} }
@ -392,38 +377,38 @@ void KScheduler::RotateScheduledQueue(s32 core_id, s32 priority) {
void KScheduler::YieldWithoutCoreMigration() { void KScheduler::YieldWithoutCoreMigration() {
auto& kernel = system.Kernel(); auto& kernel = system.Kernel();
/* Validate preconditions. */ // Validate preconditions.
ASSERT(CanSchedule(kernel)); ASSERT(CanSchedule(kernel));
ASSERT(kernel.CurrentProcess() != nullptr); ASSERT(kernel.CurrentProcess() != nullptr);
/* Get the current thread and process. */ // Get the current thread and process.
Thread& cur_thread = *GetCurrentThread(); Thread& cur_thread = *GetCurrentThread();
Process& cur_process = *kernel.CurrentProcess(); Process& cur_process = *kernel.CurrentProcess();
/* If the thread's yield count matches, there's nothing for us to do. */ // If the thread's yield count matches, there's nothing for us to do.
if (cur_thread.GetYieldScheduleCount() == cur_process.GetScheduledCount()) { if (cur_thread.GetYieldScheduleCount() == cur_process.GetScheduledCount()) {
return; return;
} }
/* Get a reference to the priority queue. */ // Get a reference to the priority queue.
auto& priority_queue = GetPriorityQueue(kernel); auto& priority_queue = GetPriorityQueue(kernel);
/* Perform the yield. */ // Perform the yield.
{ {
KScopedSchedulerLock lock(kernel); KScopedSchedulerLock lock(kernel);
const auto cur_state = cur_thread.scheduling_state; const auto cur_state = cur_thread.scheduling_state;
if (cur_state == static_cast<u32>(ThreadSchedStatus::Runnable)) { if (cur_state == static_cast<u32>(ThreadSchedStatus::Runnable)) {
/* Put the current thread at the back of the queue. */ // Put the current thread at the back of the queue.
Thread* next_thread = priority_queue.MoveToScheduledBack(std::addressof(cur_thread)); Thread* next_thread = priority_queue.MoveToScheduledBack(std::addressof(cur_thread));
IncrementScheduledCount(std::addressof(cur_thread)); IncrementScheduledCount(std::addressof(cur_thread));
/* If the next thread is different, we have an update to perform. */ // If the next thread is different, we have an update to perform.
if (next_thread != std::addressof(cur_thread)) { if (next_thread != std::addressof(cur_thread)) {
SetSchedulerUpdateNeeded(kernel); SetSchedulerUpdateNeeded(kernel);
} else { } else {
/* Otherwise, set the thread's yield count so that we won't waste work until the // Otherwise, set the thread's yield count so that we won't waste work until the
* process is scheduled again. */ // process is scheduled again.
cur_thread.SetYieldScheduleCount(cur_process.GetScheduledCount()); cur_thread.SetYieldScheduleCount(cur_process.GetScheduledCount());
} }
} }
@ -433,40 +418,40 @@ void KScheduler::YieldWithoutCoreMigration() {
void KScheduler::YieldWithCoreMigration() { void KScheduler::YieldWithCoreMigration() {
auto& kernel = system.Kernel(); auto& kernel = system.Kernel();
/* Validate preconditions. */ // Validate preconditions.
ASSERT(CanSchedule(kernel)); ASSERT(CanSchedule(kernel));
ASSERT(kernel.CurrentProcess() != nullptr); ASSERT(kernel.CurrentProcess() != nullptr);
/* Get the current thread and process. */ // Get the current thread and process.
Thread& cur_thread = *GetCurrentThread(); Thread& cur_thread = *GetCurrentThread();
Process& cur_process = *kernel.CurrentProcess(); Process& cur_process = *kernel.CurrentProcess();
/* If the thread's yield count matches, there's nothing for us to do. */ // If the thread's yield count matches, there's nothing for us to do.
if (cur_thread.GetYieldScheduleCount() == cur_process.GetScheduledCount()) { if (cur_thread.GetYieldScheduleCount() == cur_process.GetScheduledCount()) {
return; return;
} }
/* Get a reference to the priority queue. */ // Get a reference to the priority queue.
auto& priority_queue = GetPriorityQueue(kernel); auto& priority_queue = GetPriorityQueue(kernel);
/* Perform the yield. */ // Perform the yield.
{ {
KScopedSchedulerLock lock(kernel); KScopedSchedulerLock lock(kernel);
const auto cur_state = cur_thread.scheduling_state; const auto cur_state = cur_thread.scheduling_state;
if (cur_state == static_cast<u32>(ThreadSchedStatus::Runnable)) { if (cur_state == static_cast<u32>(ThreadSchedStatus::Runnable)) {
/* Get the current active core. */ // Get the current active core.
const s32 core_id = cur_thread.GetActiveCore(); const s32 core_id = cur_thread.GetActiveCore();
/* Put the current thread at the back of the queue. */ // Put the current thread at the back of the queue.
Thread* next_thread = priority_queue.MoveToScheduledBack(std::addressof(cur_thread)); Thread* next_thread = priority_queue.MoveToScheduledBack(std::addressof(cur_thread));
IncrementScheduledCount(std::addressof(cur_thread)); IncrementScheduledCount(std::addressof(cur_thread));
/* While we have a suggested thread, try to migrate it! */ // While we have a suggested thread, try to migrate it!
bool recheck = false; bool recheck = false;
Thread* suggested = priority_queue.GetSuggestedFront(core_id); Thread* suggested = priority_queue.GetSuggestedFront(core_id);
while (suggested != nullptr) { while (suggested != nullptr) {
/* Check if the suggested thread is the thread running on its core. */ // Check if the suggested thread is the thread running on its core.
const s32 suggested_core = suggested->GetActiveCore(); const s32 suggested_core = suggested->GetActiveCore();
if (Thread* running_on_suggested_core = if (Thread* running_on_suggested_core =
@ -474,10 +459,10 @@ void KScheduler::YieldWithCoreMigration() {
? kernel.Scheduler(suggested_core).state.highest_priority_thread ? kernel.Scheduler(suggested_core).state.highest_priority_thread
: nullptr; : nullptr;
running_on_suggested_core != suggested) { running_on_suggested_core != suggested) {
/* If the current thread's priority is higher than our suggestion's we prefer // If the current thread's priority is higher than our suggestion's we prefer
* the next thread to the suggestion. */ // the next thread to the suggestion. We also prefer the next thread when the
/* We also prefer the next thread when the current thread's priority is equal to // current thread's priority is equal to the suggestions, but the next thread
* the suggestions, but the next thread has been waiting longer. */ // has been waiting longer.
if ((suggested->GetPriority() > cur_thread.GetPriority()) || if ((suggested->GetPriority() > cur_thread.GetPriority()) ||
(suggested->GetPriority() == cur_thread.GetPriority() && (suggested->GetPriority() == cur_thread.GetPriority() &&
next_thread != std::addressof(cur_thread) && next_thread != std::addressof(cur_thread) &&
@ -486,9 +471,9 @@ void KScheduler::YieldWithCoreMigration() {
break; break;
} }
/* If we're allowed to do a migration, do one. */ // If we're allowed to do a migration, do one.
/* NOTE: Unlike migrations in UpdateHighestPriorityThread, this moves the // NOTE: Unlike migrations in UpdateHighestPriorityThread, this moves the
* suggestion to the front of the queue. */ // suggestion to the front of the queue.
if (running_on_suggested_core == nullptr || if (running_on_suggested_core == nullptr ||
running_on_suggested_core->GetPriority() >= running_on_suggested_core->GetPriority() >=
HighestCoreMigrationAllowedPriority) { HighestCoreMigrationAllowedPriority) {
@ -497,23 +482,23 @@ void KScheduler::YieldWithCoreMigration() {
IncrementScheduledCount(suggested); IncrementScheduledCount(suggested);
break; break;
} else { } else {
/* We couldn't perform a migration, but we should check again on a future // We couldn't perform a migration, but we should check again on a future
* yield. */ // yield.
recheck = true; recheck = true;
} }
} }
/* Get the next suggestion. */ // Get the next suggestion.
suggested = priority_queue.GetSuggestedNext(core_id, suggested); suggested = priority_queue.GetSuggestedNext(core_id, suggested);
} }
/* If we still have a suggestion or the next thread is different, we have an update to // If we still have a suggestion or the next thread is different, we have an update to
* perform. */ // perform.
if (suggested != nullptr || next_thread != std::addressof(cur_thread)) { if (suggested != nullptr || next_thread != std::addressof(cur_thread)) {
SetSchedulerUpdateNeeded(kernel); SetSchedulerUpdateNeeded(kernel);
} else if (!recheck) { } else if (!recheck) {
/* Otherwise if we don't need to re-check, set the thread's yield count so that we // Otherwise if we don't need to re-check, set the thread's yield count so that we
* won't waste work until the process is scheduled again. */ // won't waste work until the process is scheduled again.
cur_thread.SetYieldScheduleCount(cur_process.GetScheduledCount()); cur_thread.SetYieldScheduleCount(cur_process.GetScheduledCount());
} }
} }
@ -523,48 +508,48 @@ void KScheduler::YieldWithCoreMigration() {
void KScheduler::YieldToAnyThread() { void KScheduler::YieldToAnyThread() {
auto& kernel = system.Kernel(); auto& kernel = system.Kernel();
/* Validate preconditions. */ // Validate preconditions.
ASSERT(CanSchedule(kernel)); ASSERT(CanSchedule(kernel));
ASSERT(kernel.CurrentProcess() != nullptr); ASSERT(kernel.CurrentProcess() != nullptr);
/* Get the current thread and process. */ // Get the current thread and process.
Thread& cur_thread = *GetCurrentThread(); Thread& cur_thread = *GetCurrentThread();
Process& cur_process = *kernel.CurrentProcess(); Process& cur_process = *kernel.CurrentProcess();
/* If the thread's yield count matches, there's nothing for us to do. */ // If the thread's yield count matches, there's nothing for us to do.
if (cur_thread.GetYieldScheduleCount() == cur_process.GetScheduledCount()) { if (cur_thread.GetYieldScheduleCount() == cur_process.GetScheduledCount()) {
return; return;
} }
/* Get a reference to the priority queue. */ // Get a reference to the priority queue.
auto& priority_queue = GetPriorityQueue(kernel); auto& priority_queue = GetPriorityQueue(kernel);
/* Perform the yield. */ // Perform the yield.
{ {
KScopedSchedulerLock lock(kernel); KScopedSchedulerLock lock(kernel);
const auto cur_state = cur_thread.scheduling_state; const auto cur_state = cur_thread.scheduling_state;
if (cur_state == static_cast<u32>(ThreadSchedStatus::Runnable)) { if (cur_state == static_cast<u32>(ThreadSchedStatus::Runnable)) {
/* Get the current active core. */ // Get the current active core.
const s32 core_id = cur_thread.GetActiveCore(); const s32 core_id = cur_thread.GetActiveCore();
/* Migrate the current thread to core -1. */ // Migrate the current thread to core -1.
cur_thread.SetActiveCore(-1); cur_thread.SetActiveCore(-1);
priority_queue.ChangeCore(core_id, std::addressof(cur_thread)); priority_queue.ChangeCore(core_id, std::addressof(cur_thread));
IncrementScheduledCount(std::addressof(cur_thread)); IncrementScheduledCount(std::addressof(cur_thread));
/* If there's nothing scheduled, we can try to perform a migration. */ // If there's nothing scheduled, we can try to perform a migration.
if (priority_queue.GetScheduledFront(core_id) == nullptr) { if (priority_queue.GetScheduledFront(core_id) == nullptr) {
/* While we have a suggested thread, try to migrate it! */ // While we have a suggested thread, try to migrate it!
Thread* suggested = priority_queue.GetSuggestedFront(core_id); Thread* suggested = priority_queue.GetSuggestedFront(core_id);
while (suggested != nullptr) { while (suggested != nullptr) {
/* Check if the suggested thread is the top thread on its core. */ // Check if the suggested thread is the top thread on its core.
const s32 suggested_core = suggested->GetActiveCore(); const s32 suggested_core = suggested->GetActiveCore();
if (Thread* top_on_suggested_core = if (Thread* top_on_suggested_core =
(suggested_core >= 0) ? priority_queue.GetScheduledFront(suggested_core) (suggested_core >= 0) ? priority_queue.GetScheduledFront(suggested_core)
: nullptr; : nullptr;
top_on_suggested_core != suggested) { top_on_suggested_core != suggested) {
/* If we're allowed to do a migration, do one. */ // If we're allowed to do a migration, do one.
if (top_on_suggested_core == nullptr || if (top_on_suggested_core == nullptr ||
top_on_suggested_core->GetPriority() >= top_on_suggested_core->GetPriority() >=
HighestCoreMigrationAllowedPriority) { HighestCoreMigrationAllowedPriority) {
@ -573,25 +558,25 @@ void KScheduler::YieldToAnyThread() {
IncrementScheduledCount(suggested); IncrementScheduledCount(suggested);
} }
/* Regardless of whether we migrated, we had a candidate, so we're done. */ // Regardless of whether we migrated, we had a candidate, so we're done.
break; break;
} }
/* Get the next suggestion. */ // Get the next suggestion.
suggested = priority_queue.GetSuggestedNext(core_id, suggested); suggested = priority_queue.GetSuggestedNext(core_id, suggested);
} }
/* If the suggestion is different from the current thread, we need to perform an // If the suggestion is different from the current thread, we need to perform an
* update. */ // update.
if (suggested != std::addressof(cur_thread)) { if (suggested != std::addressof(cur_thread)) {
SetSchedulerUpdateNeeded(kernel); SetSchedulerUpdateNeeded(kernel);
} else { } else {
/* Otherwise, set the thread's yield count so that we won't waste work until the // Otherwise, set the thread's yield count so that we won't waste work until the
* process is scheduled again. */ // process is scheduled again.
cur_thread.SetYieldScheduleCount(cur_process.GetScheduledCount()); cur_thread.SetYieldScheduleCount(cur_process.GetScheduledCount());
} }
} else { } else {
/* Otherwise, we have an update to perform. */ // Otherwise, we have an update to perform.
SetSchedulerUpdateNeeded(kernel); SetSchedulerUpdateNeeded(kernel);
} }
} }

16
src/core/hle/kernel/k_scheduler_lock.h
View File

@ -34,19 +34,19 @@ public:
void Lock() { void Lock() {
if (this->IsLockedByCurrentThread()) { if (this->IsLockedByCurrentThread()) {
/* If we already own the lock, we can just increment the count. */ // If we already own the lock, we can just increment the count.
ASSERT(this->lock_count > 0); ASSERT(this->lock_count > 0);
this->lock_count++; this->lock_count++;
} else { } else {
/* Otherwise, we want to disable scheduling and acquire the spinlock. */ // Otherwise, we want to disable scheduling and acquire the spinlock.
SchedulerType::DisableScheduling(kernel); SchedulerType::DisableScheduling(kernel);
this->spin_lock.lock(); this->spin_lock.lock();
/* For debug, ensure that our state is valid. */ // For debug, ensure that our state is valid.
ASSERT(this->lock_count == 0); ASSERT(this->lock_count == 0);
ASSERT(this->owner_thread == Core::EmuThreadHandle::InvalidHandle()); ASSERT(this->owner_thread == Core::EmuThreadHandle::InvalidHandle());
/* Increment count, take ownership. */ // Increment count, take ownership.
this->lock_count = 1; this->lock_count = 1;
this->owner_thread = kernel.GetCurrentEmuThreadID(); this->owner_thread = kernel.GetCurrentEmuThreadID();
} }
@ -56,18 +56,18 @@ public:
ASSERT(this->IsLockedByCurrentThread()); ASSERT(this->IsLockedByCurrentThread());
ASSERT(this->lock_count > 0); ASSERT(this->lock_count > 0);
/* Release an instance of the lock. */ // Release an instance of the lock.
if ((--this->lock_count) == 0) { if ((--this->lock_count) == 0) {
/* We're no longer going to hold the lock. Take note of what cores need scheduling. */ // We're no longer going to hold the lock. Take note of what cores need scheduling.
const u64 cores_needing_scheduling = const u64 cores_needing_scheduling =
SchedulerType::UpdateHighestPriorityThreads(kernel); SchedulerType::UpdateHighestPriorityThreads(kernel);
Core::EmuThreadHandle leaving_thread = owner_thread; Core::EmuThreadHandle leaving_thread = owner_thread;
/* Note that we no longer hold the lock, and unlock the spinlock. */ // Note that we no longer hold the lock, and unlock the spinlock.
this->owner_thread = Core::EmuThreadHandle::InvalidHandle(); this->owner_thread = Core::EmuThreadHandle::InvalidHandle();
this->spin_lock.unlock(); this->spin_lock.unlock();
/* Enable scheduling, and perform a rescheduling operation. */ // Enable scheduling, and perform a rescheduling operation.
SchedulerType::EnableScheduling(kernel, cores_needing_scheduling, leaving_thread); SchedulerType::EnableScheduling(kernel, cores_needing_scheduling, leaving_thread);
} }
} }

6
src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h
View File

@ -28,17 +28,17 @@ public:
: kernel(kernel), event_handle(event_handle), thread(t), timeout_tick(timeout) { : kernel(kernel), event_handle(event_handle), thread(t), timeout_tick(timeout) {
event_handle = InvalidHandle; event_handle = InvalidHandle;
/* Lock the scheduler. */ // Lock the scheduler.
kernel.GlobalSchedulerContext().scheduler_lock.Lock(); kernel.GlobalSchedulerContext().scheduler_lock.Lock();
} }
~KScopedSchedulerLockAndSleep() { ~KScopedSchedulerLockAndSleep() {
/* Register the sleep. */ // Register the sleep.
if (this->timeout_tick > 0) { if (this->timeout_tick > 0) {
kernel.TimeManager().ScheduleTimeEvent(event_handle, this->thread, this->timeout_tick); kernel.TimeManager().ScheduleTimeEvent(event_handle, this->thread, this->timeout_tick);
} }
/* Unlock the scheduler. */ // Unlock the scheduler.
kernel.GlobalSchedulerContext().scheduler_lock.Unlock(); kernel.GlobalSchedulerContext().scheduler_lock.Unlock();
} }