Sort out weirdness in marker display when hitting early and fix judge code
This commit is contained in:
parent
561455e294
commit
498bddc823
@ -41,6 +41,10 @@
|
||||
- Back
|
||||
- Start Button Action
|
||||
|
||||
## Gameplay
|
||||
- Precise Input handling, the dirty way
|
||||
- Sort out the wierdness when hitting early
|
||||
|
||||
## Misc
|
||||
- Handling Resolution changes
|
||||
- reload preferences on change
|
||||
|
7
TODO.md
7
TODO.md
@ -2,7 +2,12 @@
|
||||
## Misc
|
||||
|
||||
## Gameplay Screen
|
||||
- Precise Input handling, the dirty way
|
||||
- Score
|
||||
- compute
|
||||
- display
|
||||
- Combo
|
||||
- compute
|
||||
- display
|
||||
|
||||
## Results Screen
|
||||
|
||||
|
@ -79,7 +79,7 @@ namespace Gameplay {
|
||||
if (note.timed_judgment) {
|
||||
sprite = marker.get_sprite(
|
||||
judgement_to_animation(note.timed_judgment->judgement),
|
||||
music_time-note.timing+note.timed_judgment->delta
|
||||
music_time-note.timing-note.timed_judgment->delta
|
||||
);
|
||||
} else {
|
||||
sprite = marker.get_sprite(
|
||||
|
@ -25,18 +25,14 @@ namespace Gameplay {
|
||||
}
|
||||
// Numbers from http://544332133981.hatenablog.com/entry/bemani-rank_4
|
||||
// which themselves are apparently from jubeat analyser's code.
|
||||
// Here they are divided by 2 because we are checking against an absolute
|
||||
// offset from the target time position
|
||||
if (delta_abs < sf::milliseconds(21)) {
|
||||
if (delta_abs < sf::milliseconds(42)) {
|
||||
return Judgement::Perfect;
|
||||
} else if (delta_abs < sf::milliseconds(46)) {
|
||||
} else if (delta_abs < sf::milliseconds(92)) {
|
||||
return Judgement::Great;
|
||||
} else if (delta_abs < sf::milliseconds(83)) {
|
||||
} else if (delta_abs < sf::milliseconds(166)) {
|
||||
return Judgement::Good;
|
||||
} else if (delta_abs < sf::milliseconds(250)) {
|
||||
return Judgement::Poor;
|
||||
} else {
|
||||
return Judgement::Miss;
|
||||
return Judgement::Poor;
|
||||
}
|
||||
}
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user