Taiko_Stuff/tja2fumen
1
0
Fork 0
mirror of synced 2025-02-25 14:25:12 +01:00
Code Releases Wiki Activity

Add notes about item byte in fumen files

Browse Source 
See also: https://github.com/vivaria/tja2fumen/issues/17
This commit is contained in:
Viv 2023-06-25 12:14:56 -04:00
parent 52827f1abc
commit 5899593024
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/tja2fumen/converters.py
View File

@ -4,6 +4,7 @@ from tja2fumen.utils import computeSoulGaugeByte
from tja2fumen.constants import TJA_NOTE_TYPES, DIFFICULTY_BYTES, unknownHeaderSample
# Filler metadata that the `writeFumen` function expects
# TODO: Determine how to properly set the item byte (https://github.com/vivaria/tja2fumen/issues/17)
default_note = {'type': '', 'pos': 0.0, 'item': 0, 'padding': 0.0,
'scoreInit': 0, 'scoreDiff': 0, 'duration': 0.0}
default_branch = {'length': 0, 'padding': 0, 'speed': 1.0}

1
testing/test_songs.py
View File

@ -96,5 +96,6 @@ def test_converted_tja_vs_cached_fumen(id_song, tmp_path):
if ca_note['type'] not in ["Balloon", "Kusudama"]:
assert_song_property(co_note, ca_note, 'scoreInit', i_measure, i_branch, i_note)
assert_song_property(co_note, ca_note, 'scoreDiff', i_measure, i_branch, i_note)
# NB: 'item' still needs to be implemented: https://github.com/vivaria/tja2fumen/issues/17
# assert_song_property(co_note, ca_note, 'item', i_measure, i_branch, i_note)