Taiko_Stuff/tja2fumen
1
0
Fork 0
mirror of synced 2024-11-15 01:47:34 +01:00
Code Releases Wiki Activity

Add double Kusudama test

Browse Source
This commit is contained in:
Viv 2023-07-24 16:41:34 -04:00
parent 276bd0b70c
commit 6eb3676343
4 changed files with 36 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
README.md
View File

@ -59,26 +59,26 @@ If there is an unsupported feature that you would like support for, please make
> **Legend**: `✅` = Fully supported, `⚪️` = Ignored, `⚠️` = Incorrect behavior, `❌` = Not supported
| Note/command | tja2fumen | tja2bin | Comments |
|-------------------------------------------------|-----------|---------|----------------------------------------------------------------------|
| `0`, `1`, `2`, `3`, `4` `5`, `6`, `7`, `8`, `9` | `✅` | `✅` | |
| `A`, `B` | `✅` | `❌` | |
| `C`, `D`, `E`, `F`, `G`, `H`, `I` | `⚠️` | `❌` | Replaced by normal notes/rolls in tja2fumen. |
| `9000,`<br>`9008,` | `⚪️` | `❔` | Double Kusudama note to reset accuracy. |
| `#START`, `#END` | `✅` | `✅` | |
| `#START P1`, `START P2` | `✅` | `❔` | |
| `#MEASURE` | `✅` | `✅` | |
| `#BPMCHANGE` | `✅` | `⚠️` | See https://github.com/Fluto/TakoTako/issues/16 |
| `#DELAY` | `✅` | `❌` | |
| `#SCROLL` | `✅` | `✅` | |
| `#GOGOSTART`, `#GOGOEND` | `✅` | `✅` | |
| `#BARLINEOFF`, `#BARLINEON` | `✅` | `✅` | |
| `#BRANCHSTART` | `✅` | `✅` | |
| `#SECTION` | `✅` | `✅` | |
| `#LEVELHOLD` | `❔` | `❔` | |
| `#N`, `#E`, `#M` | `✅` | `✅` | |
| `#BRANCHEND` | `✅` | `✅` | |
| `#BMSCROLL`, `#LYRIC`,<br>`#DIRECTION`, etc. | `⚪️` | `❌` | Other simulator-specific chart commands are not currently supported. |
| Note/command | tja2fumen | tja2bin | Comments |
|-------------------------------------------------|-----------|---------|--------------------------------------------------------------------------------------------------|
| `0`, `1`, `2`, `3`, `4` `5`, `6`, `7`, `8`, `9` | `✅` | `✅` | |
| `A`, `B` | `✅` | `❌` | |
| `C`, `D`, `E`, `F`, `G`, `H`, `I` | `⚠️` | `❌` | Replaced by normal notes/rolls in tja2fumen. |
| `9000,`<br>`9008,` | `⚪️` | `⚠️` | Double Kusudama note treated as 1 drumroll by tja2fumen, but 2 overlapping drumrolls by tja2bin. |
| `#START`, `#END` | `✅` | `✅` | |
| `#START P1`, `START P2` | `✅` | `❔` | |
| `#MEASURE` | `✅` | `✅` | |
| `#BPMCHANGE` | `✅` | `⚠️` | See https://github.com/Fluto/TakoTako/issues/16 |
| `#DELAY` | `✅` | `❌` | |
| `#SCROLL` | `✅` | `✅` | |
| `#GOGOSTART`, `#GOGOEND` | `✅` | `✅` | |
| `#BARLINEOFF`, `#BARLINEON` | `✅` | `✅` | |
| `#BRANCHSTART` | `✅` | `✅` | |
| `#SECTION` | `✅` | `✅` | |
| `#LEVELHOLD` | `❔` | `❔` | |
| `#N`, `#E`, `#M` | `✅` | `✅` | |
| `#BRANCHEND` | `✅` | `✅` | |
| `#BMSCROLL`, `#LYRIC`,<br>`#DIRECTION`, etc. | `⚪️` | `❌` | Other simulator-specific chart commands are not currently supported. |
## Reporting bugs

2
src/tja2fumen/types.py
View File

@ -232,7 +232,7 @@ class FumenHeader:
'Hard': 7000, 'Oni': 8000}[difficulty]
def _get_hp_from_LUTs(self, n_notes, difficulty, stars):
if n_notes > 2500:
if not 0 < n_notes <= 2500:
return
star_to_key = {
'Oni': {1: '17', 2: '17', 3: '17', 4: '17', 5: '17',

14
testing/data/dummy_tjas/notes_double_kusudama.tja Normal file
View File

@ -0,0 +1,14 @@
// This song contains only basic notes.
BPM:120
OFFSET:-1.00
COURSE:Oni
LEVEL:10
BALLOON:8,8
SCOREINIT:400
SCOREDIFF:100
#START
9000,
9008,
#END

1
testing/test_command_support.py
View File

@ -8,6 +8,7 @@ from conftest import convert
@pytest.mark.parametrize('id_song,err_msg', [
['basic_song', None],
['notes_double_kusudama', None],
['notes_hands', None],
['notes_sim_only', None],
['missing_score', None],