Add support for A
/B
notes (hands)
This commit is contained in:
parent
4f269630a5
commit
a4c9fb2b18
@ -52,7 +52,7 @@ If there is an unsupported command or metadata field that you would like support
|
||||
| Note/command | tja2fumen | tja2bin | Comments |
|
||||
| ------------------------------------------------| ----------- | --------- | ----------------------------------------------------- |
|
||||
| `0`, `1`, `2`, `3`, `4` `5`, `6`, `7`, `8`, `9` | `✅` | `✅` | |
|
||||
| `A`, `B` | `❔` | `❔` | Multiplayer note with hands. |
|
||||
| `A`, `B` | `✅` | `❌` | |
|
||||
| `F` | `❔` | `❔` | Hidden ADLIB note. |
|
||||
| `9000,`<br>`9008,` | `⚪️` | `❔` | Double Kusudama note to reset accuracy. |
|
||||
| `#START`, `#END` | `✅` | `✅` | |
|
||||
|
@ -8,8 +8,8 @@ TJA_NOTE_TYPES = {
|
||||
'7': 'Balloon',
|
||||
'8': 'EndDRB',
|
||||
'9': 'Kusudama',
|
||||
'A': 'DON', # hands
|
||||
'B': 'KA', # hands
|
||||
'A': 'DON2', # hands
|
||||
'B': 'KA2', # hands
|
||||
}
|
||||
|
||||
FUMEN_NOTE_TYPES = {
|
||||
|
@ -346,7 +346,8 @@ def convert_tja_to_fumen(tja):
|
||||
current_drumroll = note
|
||||
|
||||
# Track Don/Ka notes (to later compute header values)
|
||||
elif note.note_type.lower() in ['don', 'ka']:
|
||||
elif (note.note_type.lower().startswith('don')
|
||||
or note.note_type.lower().startswith('ka')):
|
||||
total_notes[current_branch] += 1
|
||||
|
||||
# Track branch points (to later compute `#BRANCHSTART p` vals)
|
||||
|
13
testing/data/dummy_tjas/notes_hands.tja
Normal file
13
testing/data/dummy_tjas/notes_hands.tja
Normal file
@ -0,0 +1,13 @@
|
||||
// This song contains only basic notes.
|
||||
BPM:120
|
||||
OFFSET:-1.00
|
||||
|
||||
COURSE:Oni
|
||||
LEVEL:10
|
||||
BALLOON:8,8
|
||||
SCOREINIT:400
|
||||
SCOREDIFF:100
|
||||
|
||||
#START
|
||||
A0B0,
|
||||
#END
|
@ -8,6 +8,7 @@ from conftest import convert
|
||||
|
||||
@pytest.mark.parametrize('id_song,err_msg', [
|
||||
['basic_song', None],
|
||||
['notes_hands', None],
|
||||
['missing_score', None],
|
||||
['missing_balloon', "Not enough values for 'BALLOON:"],
|
||||
['missing_course', "Invalid COURSE value:"],
|
||||
|
Loading…
Reference in New Issue
Block a user