Taiko_Stuff/tja2fumen
1
0
Fork 0
mirror of synced 2025-01-24 07:04:09 +01:00
Code Releases Wiki Activity

testing/: Tighten up tolerance for fumenOffset/pos

Browse Source
This commit is contained in:
Viv 2023-07-08 18:34:03 -04:00
parent 7b31516438
commit ab7708e740
3 changed files with 290 additions and 290 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
testing/data/ia6cho.tja
View File

@ -1,7 +1,7 @@
// This song features mid-measure BPMCHANGE commands. // This song features mid-measure BPMCHANGE commands.
// It also mixes in SCROLL and MEASURE commands next to the BPMCHANGE commands. // It also mixes in SCROLL and MEASURE commands next to the BPMCHANGE commands.
BPM:186 BPM:185.9998
OFFSET:-11.430 OFFSET:-11.4302
COURSE:Edit COURSE:Edit
LEVEL:9 LEVEL:9

572
testing/data/linda.tja
View File

File diff suppressed because it is too large Load Diff

4
testing/test_conversion.py
View File

@ -79,7 +79,7 @@ def test_converted_tja_vs_cached_fumen(id_song, tmp_path, entry_point):
ca_measure = ca_song['measures'][i_measure] ca_measure = ca_song['measures'][i_measure]
# 3a. Check measure metadata # 3a. Check measure metadata
assert_song_property(co_measure, ca_measure, 'bpm', i_measure, abs=0.01) assert_song_property(co_measure, ca_measure, 'bpm', i_measure, abs=0.01)
assert_song_property(co_measure, ca_measure, 'fumenOffset', i_measure, abs=1.0) assert_song_property(co_measure, ca_measure, 'fumenOffset', i_measure, abs=0.15)
assert_song_property(co_measure, ca_measure, 'gogo', i_measure) assert_song_property(co_measure, ca_measure, 'gogo', i_measure)
assert_song_property(co_measure, ca_measure, 'barline', i_measure) assert_song_property(co_measure, ca_measure, 'barline', i_measure)
assert_song_property(co_measure, ca_measure, 'branchInfo', i_measure) assert_song_property(co_measure, ca_measure, 'branchInfo', i_measure)
@ -98,7 +98,7 @@ def test_converted_tja_vs_cached_fumen(id_song, tmp_path, entry_point):
co_note = co_branch[i_note] co_note = co_branch[i_note]
ca_note = ca_branch[i_note] ca_note = ca_branch[i_note]
assert_song_property(co_note, ca_note, 'type', i_measure, i_branch, i_note, func=normalize_type) assert_song_property(co_note, ca_note, 'type', i_measure, i_branch, i_note, func=normalize_type)
assert_song_property(co_note, ca_note, 'pos', i_measure, i_branch, i_note, abs=0.2) assert_song_property(co_note, ca_note, 'pos', i_measure, i_branch, i_note, abs=0.1)
# NB: Drumroll duration doesn't always end exactly on a beat. Plus, TJA charters often eyeball # NB: Drumroll duration doesn't always end exactly on a beat. Plus, TJA charters often eyeball
# drumrolls, leading them to be often off by a 1/4th/8th/16th/32th/etc. These charting errors # drumrolls, leading them to be often off by a 1/4th/8th/16th/32th/etc. These charting errors
# are fixable, but tedious to do when writing tests. So, I've added a try/except so that they # are fixable, but tedious to do when writing tests. So, I've added a try/except so that they