1
0
mirror of synced 2024-12-17 21:35:53 +01:00
tja2fumen/testing
Viv 000125eb10
Ensure that header branch bytes are correctly set for all branching cases (#50)
Some backstory:

- In [#45](https://github.com/vivaria/tja2fumen/pull/45), I reworked the
header parsing code to make sure every header value was correctly
identified.
- In [#46](https://github.com/vivaria/tja2fumen/pull/46), I changed how
the "branch point" header bytes were set by checking if a song contained
only drumroll branching conditions. This fixed drumroll-only songs like
BATTLE NO. 1, Shoutoku Taiko, etc.

However, I missed a corner case in #46 -- songs with `#BRANCHSTART
p,0,0` should still be considered "drumroll only". As well, I neglected
to consider the "percentage only" songs. So, I fixed the header bytes
there, too.

Then, to confirm that my changes do in fact produce correct headers, I
enabled the check for `branch_points` for (most) of the songs in the
test suite. The tests pass. :)
2023-07-20 21:58:58 -04:00
..
data Fix branching behavior for #BRANCHSTART r songs (#46) 2023-07-19 16:47:08 -04:00
conftest.py Adapt release workflow to also act as a test suite (#18) 2023-06-29 01:20:46 -04:00
test_conversion.py Ensure that header branch bytes are correctly set for all branching cases (#50) 2023-07-20 21:58:58 -04:00