1
0
mirror of synced 2024-11-24 07:40:17 +01:00
ImHex/lib/third_party
Bernard Teo dd607621d7
build: Update nativefiledialog and keep dialogs on top (#1771)
This PR updates the nativefiledialog submodule and uses its new feature
to set the ImHex main window as the parent of the dialog window. This
ensures that the dialog stays on top of the main window. This is
currently supported by NFDe on Windows, macOS, and Linux/X11.
Linux/Wayland behaves as it did previously due to limitations in NFDe.

Note that macOS file dialogs have already been parented properly as NFDe
previously used the key window (the window currently receiving keyboard
events) on macOS. However, it's probably better to do the correct thing
and pass the main window to NFDe even on macOS.

### Problem description
The file dialog go behind the main window if the main window is clicked
while the file dialog is open.

### Implementation description
Update nativefiledialog and pass the `GLFWwindow*` of the main window to
the library function.

### Screenshots
Before:


https://github.com/WerWolv/ImHex/assets/6948096/589c3401-702a-4b0a-99ed-02d3e4d9080e

After:


https://github.com/WerWolv/ImHex/assets/6948096/8fef4900-eedc-48d5-8a4e-7bd81e37e3c0

### Additional things
I have tested this on Windows and Linux/X11, but did not test this on
macOS. It would be ideal if someone can help with this. (But as far as
NFDe is concerned, macOS `NSWindow*` handles have been tested (with
SDL2) and works.)

Co-authored-by: Nik <werwolv98@gmail.com>
2024-07-03 05:53:55 +00:00
..
boost fix: Regex crashes with too long input strings 2024-06-07 23:12:18 +02:00
capstone@097c04d941 build: move third party libraries to lib/third_party (#1417) 2023-11-12 02:02:54 +01:00
edlib@931be2b090 feat: Implement Myers' diffing algorithm (#1508) 2024-01-21 18:39:13 +01:00
fmt@0041a40c13 build: Updated ImGui, libfmt and libyara 2024-07-01 22:00:08 +02:00
HashLibPlus@1823dd1162 build: Updated dependencies 2024-03-26 19:47:39 +01:00
imgui build: Updated ImGui, libfmt and libyara 2024-07-01 22:00:08 +02:00
jthread build: move third party libraries to lib/third_party (#1417) 2023-11-12 02:02:54 +01:00
llvm-demangle build: move third party libraries to lib/third_party (#1417) 2023-11-12 02:02:54 +01:00
lunasvg@17b595a6f1 impr: Added support for SVG loading, improved texture loading API 2024-05-01 20:36:10 +02:00
microtar build: move third party libraries to lib/third_party (#1417) 2023-11-12 02:02:54 +01:00
miniaudio build: move third party libraries to lib/third_party (#1417) 2023-11-12 02:02:54 +01:00
nativefiledialog@c099aaee9a build: Update nativefiledialog and keep dialogs on top (#1771) 2024-07-03 05:53:55 +00:00
nlohmann_json build: Updated dependencies 2024-01-25 11:33:34 +01:00
xdgpp@f01f810714 build: move third party libraries to lib/third_party (#1417) 2023-11-12 02:02:54 +01:00
yara build: Updated ImGui, libfmt and libyara 2024-07-01 22:00:08 +02:00