b646ece14b
### Problem description This PR addresses issue #2013 that described a cluttered Event Manager. This is a DX issue and should not impact the users whatsoever. ### Implementation description The changes revolve around three main points: 1. the Event Manager (`event_manager.hpp`) was split into four categories: GUI, Interaction, Lifecycle, and Provider, and two types: Events, and Requests. This results in the following files: - `events_gui.hpp` - `events_interaction.hpp` - `events_lifecycle.hpp` - `events_provider.hpp` - `requests_gui.hpp` - `requests_interaction.hpp` - `requests_lifecycle.hpp` - `requests_provider.hpp` 2. Every event and request now has its own piece of documentation, with a `@brief`, accompanied by a longer comment if needed, and gets its `@param`s described. 3. The old `event_manager.hpp` import was removed and replaced by the correct imports wherever needed, as to reduce spread of those files only to where they are truly useful. ### Additional things The commits have been split into (chrono-)logical steps: - `feat`: split the Event Manager, and replace the imports - `refactor`, `chore`: make various small changes to match the required structure - `docs`: add documentation for events and requests Hopefully, this will help to review the PR. *Note: Beware of very long rebuild times in between the commits, use them sparingly! The Actions will ensure this PR builds anyways* Closes #2013 --------- Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com> Co-authored-by: Nik <werwolv98@gmail.com>
83 lines
2.8 KiB
C++
83 lines
2.8 KiB
C++
#if defined(OS_WEB)
|
|
|
|
#include <emscripten.h>
|
|
#include <emscripten/html5.h>
|
|
|
|
#include <hex/api/imhex_api.hpp>
|
|
#include <hex/api/events/requests_lifecycle.hpp>
|
|
#include <hex/api/task_manager.hpp>
|
|
|
|
#include <window.hpp>
|
|
|
|
#include <init/run.hpp>
|
|
|
|
namespace hex::init {
|
|
|
|
void saveFsData() {
|
|
EM_ASM({
|
|
FS.syncfs(function (err) {
|
|
if (!err)
|
|
return;
|
|
alert("Failed to save permanent file system: "+err);
|
|
});
|
|
});
|
|
}
|
|
|
|
int runImHex() {
|
|
static std::unique_ptr<init::WindowSplash> splashWindow;
|
|
splashWindow = initializeImHex();
|
|
|
|
RequestRestartImHex::subscribe([&] {
|
|
MAIN_THREAD_EM_ASM({
|
|
location.reload();
|
|
});
|
|
});
|
|
|
|
// Draw the splash window while tasks are running
|
|
emscripten_set_main_loop_arg([](void *arg) {
|
|
auto &splashWindow = *reinterpret_cast<std::unique_ptr<init::WindowSplash>*>(arg);
|
|
|
|
FrameResult frameResult = splashWindow->fullFrame();
|
|
if (frameResult == FrameResult::Success) {
|
|
handleFileOpenRequest();
|
|
|
|
// Clean up everything after the main window is closed
|
|
emscripten_set_beforeunload_callback(nullptr, [](int eventType, const void *reserved, void *userData) {
|
|
std::ignore = eventType;
|
|
std::ignore = reserved;
|
|
std::ignore = userData;
|
|
|
|
emscripten_cancel_main_loop();
|
|
|
|
try {
|
|
saveFsData();
|
|
deinitializeImHex();
|
|
return "";
|
|
} catch (const std::exception &e) {
|
|
static std::string message;
|
|
message = hex::format("Failed to deinitialize ImHex!\nThis is just a message warning you of this, the application has already closed, you probably can't do anything about it.\n\nError: {}", e.what());
|
|
return message.c_str();
|
|
}
|
|
});
|
|
|
|
// Delete splash window (do it before creating the main window so glfw destroys the window)
|
|
splashWindow.reset();
|
|
|
|
emscripten_cancel_main_loop();
|
|
|
|
// Main window
|
|
static std::optional<Window> window;
|
|
window.emplace();
|
|
|
|
emscripten_set_main_loop([]() {
|
|
window->fullFrame();
|
|
}, 60, 0);
|
|
}
|
|
}, &splashWindow, 60, 0);
|
|
|
|
return -1;
|
|
}
|
|
|
|
}
|
|
|
|
#endif |