dd607621d7
This PR updates the nativefiledialog submodule and uses its new feature to set the ImHex main window as the parent of the dialog window. This ensures that the dialog stays on top of the main window. This is currently supported by NFDe on Windows, macOS, and Linux/X11. Linux/Wayland behaves as it did previously due to limitations in NFDe. Note that macOS file dialogs have already been parented properly as NFDe previously used the key window (the window currently receiving keyboard events) on macOS. However, it's probably better to do the correct thing and pass the main window to NFDe even on macOS. ### Problem description The file dialog go behind the main window if the main window is clicked while the file dialog is open. ### Implementation description Update nativefiledialog and pass the `GLFWwindow*` of the main window to the library function. ### Screenshots Before: https://github.com/WerWolv/ImHex/assets/6948096/589c3401-702a-4b0a-99ed-02d3e4d9080e After: https://github.com/WerWolv/ImHex/assets/6948096/8fef4900-eedc-48d5-8a4e-7bd81e37e3c0 ### Additional things I have tested this on Windows and Linux/X11, but did not test this on macOS. It would be ideal if someone can help with this. (But as far as NFDe is concerned, macOS `NSWindow*` handles have been tested (with SDL2) and works.) Co-authored-by: Nik <werwolv98@gmail.com> |
||
|---|---|---|
| .. | ||
| external | ||
| libimhex | ||
| third_party | ||