1
0
mirror of synced 2024-12-15 17:21:16 +01:00
ImHex/lib/libimhex
FireNX70 9b9b1aa6cc
fix: Multisampling trying to use larger sample count than supported (#1670)
### Problem description
https://gitlab.freedesktop.org/mesa/mesa/-/issues/11135
It turns out LLVMpipe only supports 4x multisampling. Checking
GL_MAX_SAMPLES seems like the right thing to do.

### Implementation description
~~Right now, I only check GL_MAX_SAMPLES. Depending on the format, we
might need to check GL_MAX_INTEGER_SAMPLES. I don't know how likely it
is that you might want to use a different format in the future,
glGetInternalformativ might be a safer option to retrieve the max number
of samples we can use.~~

Ended up implementing it with glGetInternalformativ.

### Additional things
I guess I could merge the ```if```s at lines 95, 99 and 103 in
imgui_imhex_extensions.cpp while we're at it.

---------

Co-authored-by: Nik <werwolv98@gmail.com>
2024-05-19 14:18:12 +02:00
..
include impr: Added data size widget 2024-05-19 10:21:54 +02:00
source fix: Multisampling trying to use larger sample count than supported (#1670) 2024-05-19 14:18:12 +02:00
CMakeLists.txt impr: Added support for SVG loading, improved texture loading API 2024-05-01 20:36:10 +02:00
LICENSE git: Put libimhex and the ui plugin library under LGPLv2.1 2024-01-22 19:05:04 +01:00