1
0
mirror of synced 2024-12-15 17:21:16 +01:00
ImHex/lib/libimhex/source
FireNX70 9b9b1aa6cc
fix: Multisampling trying to use larger sample count than supported (#1670)
### Problem description
https://gitlab.freedesktop.org/mesa/mesa/-/issues/11135
It turns out LLVMpipe only supports 4x multisampling. Checking
GL_MAX_SAMPLES seems like the right thing to do.

### Implementation description
~~Right now, I only check GL_MAX_SAMPLES. Depending on the format, we
might need to check GL_MAX_INTEGER_SAMPLES. I don't know how likely it
is that you might want to use a different format in the future,
glGetInternalformativ might be a safer option to retrieve the max number
of samples we can use.~~

Ended up implementing it with glGetInternalformativ.

### Additional things
I guess I could merge the ```if```s at lines 95, 99 and 103 in
imgui_imhex_extensions.cpp while we're at it.

---------

Co-authored-by: Nik <werwolv98@gmail.com>
2024-05-19 14:18:12 +02:00
..
api fix: Providers not being closable 2024-05-17 23:51:34 +02:00
data_processor refactor: Get rid of this->m_ 2023-12-19 13:10:25 +01:00
helpers impr: Allow full magic analysis, removed unidentified data from magic report 2024-05-19 10:21:02 +02:00
providers feat: Added simple insert mode to hex editor 2024-03-29 13:22:28 +01:00
subcommands feat: Added short forms for commonly used commands 2024-03-14 18:24:31 +01:00
test tests: Add infrastructure for testing plugins (#1538) 2024-02-26 20:51:08 +01:00
ui fix: Multisampling trying to use larger sample count than supported (#1670) 2024-05-19 14:18:12 +02:00