Nik
58603ed12a
impr: Better experience when first starting ImHex ( #1510 )
2024-01-21 18:39:51 +01:00
Nik
d005b5d2d9
feat: Allow toolbar icons to be modified ( #1509 )
2024-01-21 18:39:32 +01:00
Nik
a13b5bf8c0
feat: Implement Myers' diffing algorithm ( #1508 )
2024-01-21 18:39:13 +01:00
Ada
cc97c0e525
fix: Segfault when launching ImHex with file arguments ( #1501 )
...
d511080814
2024-01-18 11:11:06 +01:00
WerWolv
82a3017629
feat: Added always on top and fullscreen mode toggle
2024-01-15 20:52:08 +01:00
WerWolv
d511080814
impr: Make plugin features and subcommands work in statically linked builds
2024-01-13 00:34:13 +01:00
WerWolv
ea7483f9a7
impr: Get rid of the concept of built-in plugins
...
#1489
2024-01-12 23:03:13 +01:00
WerWolv
72f4331703
feat: Added virtual files to the pattern language
2024-01-11 20:11:22 +01:00
WerWolv
3449525ead
feat: Added drag-n-drop overlay for windows
2024-01-10 23:46:50 +01:00
WerWolv
1c17ec5599
fix: Avoid heap allocations in thread local storage
2024-01-10 20:13:53 +01:00
WerWolv
f518bdadbd
fix: Properly clear thread-local thread name
2024-01-09 21:46:54 +01:00
WerWolv
d5c8021b41
fix: Use a thread-local storage for thread names instead
2024-01-09 16:16:20 +01:00
WerWolv
929b5176ce
impr: Fallback to old thread name API when new one isn't available
2024-01-09 13:43:34 +01:00
WerWolv
dd9a2e1818
fix: Errors being thrown during library init
2024-01-09 11:38:56 +01:00
WerWolv
0b5656dcc4
fix: Manually initialize library plugins
2024-01-09 11:31:56 +01:00
WerWolv
037d77f28e
impr: Improve plugin unload logging
2024-01-09 10:54:53 +01:00
WerWolv
301e95b708
impr: Move plugin unload logging to plugins
2024-01-09 10:53:50 +01:00
WerWolv
874bac7de2
impr: Include thread name in log
2024-01-09 10:39:06 +01:00
WerWolv
bfafc692db
impr: Added icons to all menu items
2024-01-08 21:51:48 +01:00
WerWolv
9530100455
fix: Texture interpreting raw data as structured images
2024-01-08 09:39:01 +01:00
WerWolv
cab329556c
impr: Make sure plugins are only loaded once
2024-01-07 18:45:17 +01:00
WerWolv
1c5d6cbe94
impr: Added error reporting for plugin unloading
2024-01-07 16:07:53 +01:00
WerWolv
576bc80716
impr: Use full windows to draw tutorial popups
2024-01-06 22:54:18 +01:00
WerWolv
f9ab16049b
fix: Make sure plugins are unloaded in opposite load order
2024-01-06 16:09:05 +01:00
WerWolv
464495987a
fix: Crash due to task manager not being fully reset
2024-01-04 21:33:17 +01:00
WerWolv
556fd2bbc3
build: Really only build the things that are necessary
2024-01-04 13:18:27 +01:00
WerWolv
0097d1782e
build: Fix external plugins not having a imhex version set
2024-01-04 12:01:40 +01:00
WerWolv
ebf379f7c1
build: Fix some sdk variables not being set correctly
2024-01-04 10:39:07 +01:00
WerWolv
eca41cac16
build: Fix more link and define issues
2024-01-04 01:06:38 +01:00
WerWolv
a8e2e132d1
build: Fix library linking and define setting issues
2024-01-04 01:01:51 +01:00
WerWolv
ff48d37598
build: Make SDK not try to link to unbundled libraries
2024-01-04 00:37:56 +01:00
WerWolv
e2b7a69fc8
fix: Warnings when trying to load progress for achievements that aren't in save file
2023-12-31 13:53:28 +01:00
Nik
950eaea8af
impr: Make decompression support actually useful ( #1481 )
2023-12-31 11:39:24 +01:00
WerWolv
b76e7ff678
impr: Remove duplicate window name from macOS title bar
2023-12-30 23:52:25 +01:00
Nik
5a0a5ad445
build: Fix macOS M1 build entirely ( #1480 )
2023-12-30 19:11:33 +01:00
WerWolv
af63b42eaf
impr: Make task progress bar show animation when no progress is set
2023-12-28 22:14:45 +01:00
WerWolv
5adeac6bbc
fix: Make sure library plugins are always initialized
2023-12-28 14:59:23 +01:00
WerWolv
3c6f52f5ea
impr: Harden achievement progress store function
2023-12-27 16:57:44 +01:00
WerWolv
874619f62e
impr: Harden settings store function
2023-12-27 16:53:03 +01:00
WerWolv
74b5c93caf
impr: Code style improvements
2023-12-27 16:33:49 +01:00
WerWolv
1cf692cecf
fix: PerProvider move event not being unsubscribed
2023-12-27 11:33:04 +01:00
WerWolv
af5b871383
fix: Provider not having any valid regions by default
2023-12-27 11:31:25 +01:00
WerWolv
37d60411bb
fix: Hyperlink items disappearing inside of scrolling containers
2023-12-27 02:14:38 +01:00
WerWolv
4e0a93fc20
fix: MemoryProvider not having any valid regions
2023-12-27 01:05:34 +01:00
WerWolv
96fe608d60
impr: Switch most usages of modals over to toasts
2023-12-26 00:22:47 +01:00
WerWolv
98bc89cb39
impr: Make sure all views are closed before loading new workspace or layout
2023-12-24 14:51:47 +01:00
WerWolv
e2489151f3
feat: Added decompressing support
2023-12-24 13:14:51 +01:00
WerWolv
9066891ce2
fix: ImHex not starting on some platforms
2023-12-24 12:20:51 +01:00
WerWolv
65e2f1b5af
fix: Synchronized scrolling not working correctly
2023-12-24 00:06:16 +01:00
WerWolv
83f8370e2a
impr: Don't display plugins in the list that couldn't be loaded
2023-12-23 23:12:15 +01:00
WerWolv
fe24db7c57
feat: Move hashes into plugin, merged in extra hashes plugin
2023-12-23 22:01:47 +01:00
Nik
61bfe10bc2
refactor: Rework features that use external libraries into optional plugins ( #1470 )
2023-12-23 21:09:41 +01:00
Nik
84bfd10416
build: Restructured entire custom plugin system ( #1469 )
2023-12-22 23:39:38 +01:00
WerWolv
b934ca6ad3
impr: Allow a entire 64 bit address space to be displayed in the hex editor
2023-12-22 16:58:50 +01:00
Justus Garbe
ad8e3e38f0
Revert pattern language until it's stable again ( #1468 )
...
- Revert pattern language
2023-12-21 22:01:07 +01:00
WerWolv
e2ae567b9f
fix: Logger not printing project prefix properly
2023-12-20 15:10:53 +01:00
WerWolv
e951359a46
feat: Add frame time graph to FPS display
2023-12-20 13:42:42 +01:00
WerWolv
2b5789631f
feat: Added basic toast popups
2023-12-19 23:21:20 +01:00
WerWolv
96db2074c6
feat: Add ignore case and UTF16 search options to sequence searching
2023-12-19 14:34:35 +01:00
WerWolv
c7ab4a4569
refactor: Get rid of this->m_
2023-12-19 13:10:25 +01:00
WerWolv
dd4be3b772
refactor: Make sure unlocalized strings are always actually unlocalized
2023-12-19 12:22:28 +01:00
WerWolv
4973556fc8
impr: Better UI resize handling on welcome screen
2023-12-18 13:08:17 +01:00
WerWolv
450c93e029
impr: Cleanup welcome screen
2023-12-18 11:03:19 +01:00
WerWolv
c1abbfad7d
impr: Make sure welcome screen stays at the back
2023-12-18 10:14:07 +01:00
WerWolv
f2a795c51e
fix: Provider loader interface being closable and not resizing correctly
2023-12-17 23:15:52 +01:00
WerWolv
b1aa4fd3f8
fix: Resize operations not working correctly
...
#1463
2023-12-15 20:59:58 +01:00
WerWolv
78ef5b0d07
fix: ProviderChanged Event not being called correctly when closing first provider
...
Fixes #1421 , Fixes #1416
2023-12-14 20:48:30 +01:00
WerWolv
c1f76be3b7
feat: Display complete window title when hovering over search bar
2023-12-14 13:50:26 +01:00
WerWolv
2ebd3c6f35
impr: Better centering of icons in icon buttons
2023-12-14 13:49:46 +01:00
WerWolv
710ceedf3d
fix: Rare case where workspace was saved to wrong file
2023-12-14 09:36:29 +01:00
WerWolv
5b77f511d3
impr: Added shadow to tutorial popups
2023-12-13 23:44:53 +01:00
WerWolv
f000b6bc0a
feat: Added basic introduction tutorial
2023-12-13 23:03:39 +01:00
WerWolv
346f1362c6
impr: Allow more popups to be closed with Escape
2023-12-13 15:08:27 +01:00
WerWolv
92043a3d23
feat: Added tutorials view
2023-12-13 13:04:59 +01:00
WerWolv
3bc5295eae
impr: Allow tutorials to work correctly with localized strings
2023-12-13 11:48:21 +01:00
WerWolv
5bcfe37b4e
feat: Added tutorial system
2023-12-13 11:24:25 +01:00
WerWolv
c32dad75cd
fix: Remove logging from CLI
2023-12-12 13:20:39 +01:00
WerWolv
1b457dae7d
fix: Workspaces not always loading layout correctly
2023-12-12 00:16:21 +01:00
WerWolv
690b0df932
fix: Crash after restarting ImHex
2023-12-11 23:05:58 +01:00
WerWolv
1e4bb8c91e
impr: Remove Font Awesome
2023-12-11 23:05:35 +01:00
WerWolv
91230ba438
feat: Added workspaces
2023-12-11 15:54:22 +01:00
WerWolv
7a4358a5ec
feat: Added automatic backups
2023-12-11 11:42:33 +01:00
WerWolv
ef7898ea8d
impr: Add support for specifying filtering mode when loading textures
2023-12-09 22:00:35 +01:00
WerWolv
09a148b8a5
impr: Add hint text about font size when no custom font is selected
2023-12-09 12:14:45 +01:00
WerWolv
878f45dd80
fix: Various build errors
2023-12-08 16:22:36 +01:00
WerWolv
b4813660b5
refactor: Better interface for the event system
2023-12-08 10:29:44 +01:00
WerWolv
7f69f8bcdb
impr: More size_t -> u64
2023-12-07 13:02:12 +01:00
WerWolv
3a016da549
impr: Make providers return a 64 bit size on all platforms
2023-12-07 12:06:26 +01:00
WerWolv
9ba6d7ee1e
impr: Added simplified welcome screen
2023-12-07 11:18:49 +01:00
WerWolv
370ca740e3
feat: Allow layouts to be locked
2023-12-06 13:49:58 +01:00
WerWolv
37ac1b66dd
refactor: Task Manager related code
2023-12-06 11:04:35 +01:00
WerWolv
760b8c7a88
impr: Make long running tasks not freeze ImHex, fix saving non-continuous providers
...
Fixes #1454
2023-12-05 14:32:43 +01:00
Nik
f9a9ed4846
impr: Vastly improved 3D Visualizer ( #1456 )
...
Based entirely on @paxcut's amazing PR #1443
---------
Co-authored-by: paxcut <paxcut@outlook.com>
Co-authored-by: paxcut <53811119+paxcut@users.noreply.github.com>
2023-12-05 10:49:51 +01:00
WerWolv
e8f0a3bd23
impr: Force center modal views
2023-12-04 22:32:25 +01:00
WerWolv
08fd09064a
fix: Settings view still using old system and not opening properly
2023-12-04 22:17:43 +01:00
Nik
caee764af3
fix: Crash when destructing a moved plugin
2023-12-04 21:01:48 +01:00
WerWolv
f71fa2f704
impr: Better centered text rendering
2023-12-02 23:46:20 +01:00
WerWolv
e6ad54b53b
fix: Overlays not being applied properly
2023-12-02 18:42:57 +01:00
WerWolv
866cb5706d
feat: Added highlighting rules
2023-12-02 11:09:32 +01:00
WerWolv
2cf642a2a4
build: Updated libwolv
2023-12-01 14:07:10 +01:00
WerWolv
a50bb39978
impr: Further improve compile times
2023-11-30 14:40:07 +01:00
WerWolv
8ee234e5a6
impr: Optimize api includes
2023-11-30 11:23:12 +01:00
WerWolv
e370fdb0fc
build: Add support for unity builds
2023-11-30 10:22:15 +01:00
WerWolv
09904b77eb
feat: Add support for bold and italic fonts
2023-11-29 23:47:37 +01:00
WerWolv
23fc232c47
impr: Try to align additional fonts automatically
2023-11-28 13:52:26 +01:00
WerWolv
c02c27b63d
refactor: Moved over to more flexible font loader
2023-11-28 01:55:41 +01:00
WerWolv
284f8534ab
refactor: Move the builtin plugin specific init tasks to the plugin
2023-11-28 00:19:42 +01:00
WerWolv
1b665fa1b3
fix: Loading files into memory
2023-11-27 15:48:46 +01:00
WerWolv
494223fff6
fix: Provider load interface not opening
2023-11-27 15:34:05 +01:00
Nik
7e660450ed
feat: Implement better and more complete undo/redo stack ( #1433 )
...
This PR aims to implement a more complete undo/redo stack that, unlike
the old one, also supports undoing insertions, deletions and resize
operations
2023-11-25 12:43:48 +01:00
WerWolv
b050039e35
fix: Duplicate shortcuts not highlighting correctly
2023-11-24 20:17:01 +01:00
WerWolv
8bdb39983e
fix: Error being logged when no magic files are found
2023-11-24 11:28:37 +01:00
WerWolv
5a58ed5114
fix: Make sure store and about page are opened correctly
2023-11-23 13:08:45 +01:00
WerWolv
b619744093
fix: Command palette not appearing on Linux
2023-11-23 09:33:47 +01:00
WerWolv
74e246feed
impr: Increase performance when updating task progress
2023-11-23 09:20:26 +01:00
Nik
095da62250
feat: Add Markdown Report export option ( #1441 )
2023-11-22 07:26:31 +00:00
WerWolv
909f4b7fe8
refactor: Rename and update localization system
2023-11-21 14:38:01 +01:00
WerWolv
c89a870fe9
refactor: Streamline entire view system
2023-11-21 13:47:50 +01:00
WerWolv
fc23efdb25
impr: Move OpenGL loaders into header to avoid issues in the future
2023-11-20 23:58:49 +01:00
WerWolv
3da209b562
fix: Web build not working anymore
2023-11-20 23:51:50 +01:00
WerWolv
5daf725ee3
build: Fix building everywhere else
2023-11-20 22:21:12 +01:00
WerWolv
ffbf409174
build: Fix emscripten build
2023-11-20 22:15:16 +01:00
WerWolv
448d792988
fix: Centered text not being centered correctly
2023-11-20 21:40:54 +01:00
WerWolv
836d66a150
fix: Missing include
2023-11-19 16:11:26 +01:00
WerWolv
f9073ee8ee
impr: Prettier data inspector edit button
2023-11-19 16:08:21 +01:00
WerWolv
60b640d9f5
build: Restructure ImGui dependencies, added Readmes and licenses
2023-11-19 11:59:25 +01:00
WerWolv
a3f74098f2
fix: Potential crash when loading null values from settings
2023-11-18 17:23:50 +01:00
WerWolv
8f4839d8ff
impr: Catch exceptions thrown by events
2023-11-18 17:23:36 +01:00
WerWolv
3b01dcf230
feat: Allow hiding data inspector rows
2023-11-18 17:23:15 +01:00
WerWolv
14f728ab76
refactor: Give API files more consistent names
2023-11-18 14:50:43 +01:00
WerWolv
1249eb3261
impr: Optimize includes in often used header files
2023-11-18 14:34:33 +01:00
WerWolv
98e0a62e6e
impr: Make changing shortcuts also adjust the tooltip in the menus
2023-11-18 14:34:16 +01:00
WerWolv
2d45dce075
fix: Shortcuts not working correctly with non-western keyboards
2023-11-17 20:27:42 +01:00
WerWolv
e7bfa483f8
impr: Make settings tab bar always stick to top of window
2023-11-17 16:05:45 +01:00
WerWolv
cec925bcdc
feat: Add shortcut editor to settings
2023-11-17 14:46:21 +01:00
WerWolv
3bd779a607
fix: URL Decoding not working correctly
2023-11-17 13:13:17 +01:00
iTrooz
39252dfe48
refactor: Move custom ImGui functions to ImGuiExt namespace ( #1427 )
...
Co-authored-by: Nik <werwolv98@gmail.com>
2023-11-16 22:24:06 +01:00
WerWolv
21057d51e1
impr: More Welcome Screen UI improvements
2023-11-16 13:23:28 +01:00
WerWolv
f00daf171b
fix: Crash when loading invalid theme file
2023-11-16 09:32:32 +01:00
WerWolv
22eee94436
impr: Better UI for the Welcome screen
2023-11-16 09:32:24 +01:00
WerWolv
a51f9fd90c
impr: Better UI for the settings view
2023-11-15 22:22:57 +01:00
WerWolv
2c0553f8fd
impr: Don't wrap centered text anymore
2023-11-14 23:04:45 +01:00
WerWolv
33e20df511
impr: Make sidebars disableable and resizable
2023-11-14 15:55:25 +01:00
WerWolv
375c74abe5
impr: Add command palette button to the title bar
2023-11-14 00:03:22 +01:00
WerWolv
46b1b0ba17
impr: Use ImGui::SeparatorText to draw headers
2023-11-12 00:57:29 +01:00
WerWolv
ec4942174b
fix: Proxy not being disabled correctly when disabling it in the settings
2023-11-10 21:59:20 +01:00
WerWolv
01f7a09012
fix: Build on non-windows
2023-11-10 21:52:28 +01:00
WerWolv
c35ea228e4
fix: Crash when trying to close providers
2023-11-10 21:03:31 +01:00
WerWolv
498d8c1d65
impr: General code cleanup
2023-11-10 20:47:08 +01:00
WerWolv
3aacf0f1fb
feat: Added Experiments
2023-11-10 14:48:26 +01:00
WerWolv
e18275c1c0
fix: Division by zero when setting page size to 0
2023-11-08 11:14:56 +01:00
WerWolv
ef320b74b0
impr: Handle showing popups when closing unsaved providers better
2023-11-07 15:31:54 +01:00
WerWolv
924b4a9436
impr: Replace various fixed-size boxes with dynamic ones
2023-11-07 00:46:44 +01:00
WerWolv
f49b5efac4
fix: UI issues in the data information view
2023-11-07 00:46:17 +01:00
WerWolv
7efe9acefb
fix: Warnings about missing theme/style handlers being printed on launch
2023-11-06 15:15:18 +01:00
WerWolv
4e4cdcdf61
feat: Added release notes and commits to about page
2023-11-05 19:57:29 +01:00
WerWolv
45fb046a9a
impr: Make events thread safe
2023-11-04 23:16:38 +01:00
WerWolv
c7c01c1f24
build: Removed old jthread search
2023-11-02 20:48:34 +01:00
WerWolv
407ec1ceb6
build: Use custom jthread implementation if standard one is not available
2023-11-02 20:21:38 +01:00
WerWolv
363b07fc0c
impr: Switch to custom std::expected implementation
2023-11-02 08:53:46 +01:00
WerWolv
9617212ef1
impr: Allow visualizers to have optional parameters
2023-10-31 10:56:20 +01:00
WerWolv
c37c53369b
impr: Dock newly opened windows by default
2023-10-30 21:53:44 +01:00
WerWolv
94ad6e6072
fix: Crash on exit
2023-10-30 16:39:57 +01:00
WerWolv
c444ad9280
impr: Bundle default magic file with application
2023-10-29 19:43:45 +01:00
WerWolv
a0178ebab9
fix: File picker not handling supported extensions correctly
...
Fixes #1367
2023-10-26 17:28:36 +02:00
iTrooz
4f2d14e220
fix: fix forwarding multiple arguments to subcommands ( #1388 )
2023-10-24 07:59:23 +00:00
Nik
58189e5403
impr: Allow console output to work when debugging ( #1382 )
2023-10-22 21:39:14 +00:00
WerWolv
c3825fff65
fix: Actually fix dropdown default values
2023-10-22 17:51:00 +02:00
WerWolv
c51db87c34
fix: Language setting not defaulting to English anymore
2023-10-22 17:31:53 +02:00
Nik
7fe9a768d4
impr: Rewrote entire settings API and UI ( #1378 )
2023-10-21 21:07:33 +00:00
Nik
f114239f51
feat: Added Auto Updater for Windows, macOS and Ubuntu ( #1377 )
2023-10-21 18:40:24 +00:00
WerWolv
c46e445a04
impr: Store achievement progress immediately when unlocking one
2023-10-20 13:34:45 +02:00
WerWolv
5227887dbf
impr: Added more fine-grained colors to themes
2023-10-20 12:30:21 +02:00
WerWolv
c9cd7ad4a6
fix: Data processor recursion detector triggering too soon
2023-10-19 23:34:05 +02:00
WerWolv
da1b53420f
feat: Added debug variables to aid with development
2023-10-13 23:46:48 +02:00
lomekragow
7fc2ff3002
fix: Event unsubscribe not working correcetly when using same key for multiple events ( #1309 )
...
<!--
Please provide as much information as possible about what your PR aims
to do.
PRs with no description will most likely be closed until more
information is provided.
If you're planing on changing fundamental behaviour or add big new
features, please open a GitHub Issue first before starting to work on
it.
If it's not something big and you still want to contact us about it,
feel free to do so !
-->
### Problem description
<!-- Describe the bug that you fixed/feature request that you
implemented, or link to an existing issue describing it -->
Fixed possible bug of `EventManager::unsubscribe`
`std::map` only allows unique key, but the same token can subscribe to
multiple events.
1a2a926b77/lib/libimhex/include/hex/api/event.hpp (L104-L107)1a2a926b77/lib/libimhex/include/hex/api/event.hpp (L122-L134)
2023-10-07 23:35:35 +02:00
WerWolv
ed8c0794bb
fix: Querying default folder paths not working right on the web
2023-10-04 16:10:14 +02:00
iTrooz
d15bd4771d
feat: Support for building ImHex for the web ( #1328 )
...
Co-authored-by: WerWolv <werwolv98@gmail.com>
Co-authored-by: AnnsAnn <git@annsann.eu>
2023-10-04 12:00:32 +02:00
WerWolv
a62ede7840
fix: Properly fix possibility of no provider being selected when closing one
2023-10-01 20:56:25 +02:00
WerWolv
bcab657a06
fix: No provider being selected in some cases when closing a provider
2023-10-01 20:18:26 +02:00
WerWolv
51880fc2a8
build: Fixed build/install of refactored forwarder
2023-09-27 15:13:58 +02:00
StarrFox
25ddaa08dc
build: Fix building with capstone < 5 ( #1323 )
...
<!--
Please provide as much information as possible about what your PR aims
to do.
PRs with no description will most likely be closed until more
information is provided.
If you're planing on changing fundamental behaviour or add big new
features, please open a GitHub Issue first before starting to work on
it.
If it's not something big and you still want to contact us about it,
feel free to do so !
-->
### Problem description
<!-- Describe the bug that you fixed/feature request that you
implemented, or link to an existing issue describing it -->
This might fix building with capstone 4 as discussed in
https://discord.com/channels/789833418631675954/1155669027306340393/1155669027306340393
### Implementation description
<!-- Explain what you did to correct the problem -->
moves the max definition inside the if statement that checks for
capstone 5
2023-09-25 21:52:28 +02:00
WerWolv
f79e2df11a
feat: Added shortcut to switch between providers
2023-09-24 18:11:17 +02:00
paxcut
c577a42f62
impr: Refactoring of floating point tool to decrease code complexity. ( #1275 )
...
I noticed the bad score on code factor so I reorganized it to make it
more readable and maintainable. In order to break down the big function
into it much smaller parts I encapsulated all the variables that the
functions need to access in two classes, one for the imgui related
statics and the other for non-static variables.
When writing the smaller functions I was noticed that there was room to
simplify the existing algorithms by writing functions that could be
called by parts that previously shared no code. I tested the changes the
same way I tested the original and it seems to work the same way but
maybe a bit faster. Although it may be possible to further optimize the
present code code factor no longer flags the function at all.
2023-09-20 10:48:44 +02:00
Lennard Fonteijn
ad69ac84b1
feat: Added hex::group attribute and various fixes ( #1302 )
...
As discussed (many times) on Discord, does the same as the new favorite
tag, but instead allows you to add multiple groups.
Initially, this would cause some insane issues with draw/reset
(apparantly) fighting eachother in the pattern drawer. After a lot of
trial and error, I decided to rewrite the flow that is responsible for
calling reset. Now evaluating patterns is the one to decide when the
reset happens, not the core "game"-loop.
To make sure that draw and reset can never happen at the same time, the
mutex originally used for the favorites has been repurposed. Due to the
restructuring, the mutex in the favorite-task is no longer needed, as
that will only ever kick-off after reset is called and if there are
actually patterns, which can never line up to be accessed on different
threads at the same time.
Last but not least, I noticed that hard crashes could result in your
config file getting overridden. I added a check to prevent that.
Last I issue I can see is that if you use an excessive amount of
favorites/groups, a crash can still happen, but it only happens when you
close the program (occasionally, but unpredictable). Before, this would
happen if you ran the evaluation a second time. I boiled the cause of
the crash down to these lines of code in evaluator.cpp >
patternDestroyed:
```cpp
if (pattern->isPatternLocal()) {
if (auto it = this->m_patternLocalStorage.find(pattern->getHeapAddress()); it != this->m_patternLocalStorage.end()) {
auto &[key, data] = *it;
data.referenceCount--;
if (data.referenceCount == 0)
this->m_patternLocalStorage.erase(it);
} else if (!this->m_evaluated) {
err::E0001.throwError(fmt::format("Double free of variable named '{}'.", pattern->getVariableName()));
}
}
```
Specifically, trying to access the `*it` is the reason for the crash
(this was also the cause of the crashes before my fixes, but then during
evaluation).
I'm suspecting the root cause is somewhere in the `.clone` methods of
the patterns. I'd say that for now a crash when closing the program is
more acceptable than during evaluation (which can even happen if you use
favorites).
2023-09-16 13:09:59 +02:00
WerWolv
d011f37658
impr: Added better provider documentation
2023-09-08 21:59:27 +02:00
WerWolv
1bb0a72bed
fix: Issues with various float nodes
2023-09-04 19:59:09 +02:00
WerWolv
563ff5a774
fix: Future proof the previous fix
2023-09-03 16:18:29 +02:00
WerWolv
dc5e5344c5
fix: ImHex not starting at all anymore when launched through the explorer
2023-09-03 14:07:47 +02:00
WerWolv
632ca944de
impr: Align log output better
2023-09-03 11:45:20 +02:00
WerWolv
eba8c82699
fix: Crash when using provider overlays
2023-09-03 10:26:25 +02:00
iTrooz
be3ac26306
fix: Remove remannts of #680 bugfix ( #1282 )
2023-09-02 22:59:09 +02:00
WerWolv
58cef2361b
impr: Added hint when patterns are still loading
2023-08-30 10:04:06 +02:00
WerWolv
550392c8d6
fix: Texture loading from romfs
2023-08-26 23:43:35 +02:00
WerWolv
ba66005585
impr: Various code cleanup
2023-08-26 12:54:52 +02:00
Justus Garbe
bfc835fc54
fix: add new capstone options and fixed overextending name array
2023-08-26 12:21:44 +02:00
iTrooz
32d6ac2241
feat: move PerProvider data to new provider when saving memory provider into file provider ( #1264 )
2023-08-26 01:47:44 +02:00
WerWolv
758cdd91f3
impr: Make sure logs are always output immediately
2023-08-26 01:44:10 +02:00
WerWolv
6e81ce152e
impr: Get rid of some manual memory management
2023-08-25 23:54:39 +02:00
iTrooz
175e66a60e
feat: Do not save memory providers as recent entries ( #1259 )
2023-08-25 15:35:15 +02:00
