Viv
3e33d5c634
Fix errors in ia6cho charts
...
The official fumen had some issues where a note ended up in the wrong measure:
- Expected: pos 0.0 on the next measure
- Actual: pos 645 on the prev measure (impossible pos)
They're the same pos, but only pos 0.0 is possible to express in TJA charts, so the fumens themselves had to be updated.
Also, the TJA chart had errors, too:
- The BPMs/SCROLLs in the BPMCHANGE section were incorrect
- Some drumrolls were too short
Fixing these errors caused the failing test to pass.
2023-06-29 19:47:25 -04:00
Viv
ea701a5c63
tests/: Increase the tolerance for drumroll duration
...
Again, I encountered a large mismatch where an official fumen didn't land on the expected beat.
2023-06-29 19:47:25 -04:00
Viv
91ad789d10
tests/: Don't halt early if there's a len(notes) mistmatch
2023-06-29 19:47:25 -04:00
Viv
712cdc0a14
tests/: Don't halt early if there's a len(measures) mismatch
2023-06-29 19:47:25 -04:00
Viv
8b302e876f
tests/: Use readable name for song variables
2023-06-29 19:47:25 -04:00
Viv
3f981236e3
tests/: Add sorting for generated songs
...
This makes things nicer to debug, since we're following an expected order.
2023-06-29 15:40:05 -04:00
Viv
305b70eb27
tests/: Compare only the non-empty measures
2023-06-29 15:39:39 -04:00
Viv
0bef98c10d
Stop hardcoding song['length']
...
Instead, rely on len(song['measures') as the single source of truth for measures
2023-06-29 15:19:51 -04:00
Viv
6286a3a78d
Reorder test functions
2023-06-29 15:19:51 -04:00
Viv
af91e9fe47
tests: Import from src.tja2fumen
...
This will _actually_ perform an in-place test run, rather than importing from the installed package. This is necessary for PyCharm's coverage to ework correctly.
2023-06-29 14:10:25 -04:00
Viv
2f06ee433c
Add raises=AssertionError to ia6cho xfail entry
2023-06-29 02:01:38 -04:00
Viv
5a1d7c9aa3
Add ia6cho to test suite as XFAIL
2023-06-29 02:01:29 -04:00
vivaria
e528f48e1d
Adapt release workflow to also act as a test suite ( #18 )
2023-06-29 01:20:46 -04:00
Viv
88031074a6
Rename test_songs -> test_conversion
2023-06-27 18:32:35 -04:00
Viv
26b23ece19
Use LUT-based method for soul gauge bytes
...
The new CSV files are lookup tables generated using the following script:
https://github.com/vivaria/tja2fumen/issues/14#issuecomment-1606418746
Fixes #14 .
2023-06-25 21:54:12 -04:00
Viv
a28a8da8da
test_songs.py: Remove now-unnecessary header length check
2023-06-25 13:40:56 -04:00
Viv
f9760f46ce
test_songs.py: Add strict case for TJA-converted headers
2023-06-25 13:40:56 -04:00
Viv
27b6dbe9d6
Move checkValidHeader into testing code
2023-06-25 13:40:56 -04:00
Viv
69af60e4e3
Improve readability of header processing code
...
- header -> headerPadding
- headerUnknown -> headerMetadata
- Add more thorough comments about the meaning of various header bytes
2023-06-25 13:40:56 -04:00
Viv
5899593024
Add notes about item byte in fumen files
...
See also: https://github.com/vivaria/tja2fumen/issues/17
2023-06-25 13:40:56 -04:00
Viv
2e54975534
Add first tja-fumen pair (mikdp) to test
2023-06-25 13:40:56 -04:00
Viv
3b88104578
Add test to compare converted TJAs to fumens
2023-06-25 12:01:58 -04:00
